deployment: add service ports to hybrid common service overlays#14215
Conversation
PR SummaryLow Risk Overview This brings core and mempool in line with other hybrid service overlays (e.g. gateway, committer) that already declare named ClusterIP ports for in-cluster access. Reviewed by Cursor Bugbot for commit dbe50c3. Bugbot is set up for automated code reviews on this repo. Configure here. |
e724308 to
d024716
Compare
136955c to
338b58e
Compare
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit d024716. Configure here.
| - name: mempool-p2p-config | ||
| port: 53200 | ||
| targetPort: 53200 | ||
| protocol: TCP |
There was a problem hiding this comment.
Service port exposed without matching application port config
Medium Severity
The mempool-p2p-config service port (53200) is added to the common overlay, but mempool_p2p_config.network_config.port is never set in the common sequencerConfig. Production environments (mainnet, sepolia-alpha, sepolia-integration) only include this common config with no overrides for mempool. The replacer config template contains an unresolved placeholder ($$$_MEMPOOL_P2P_CONFIG-NETWORK_CONFIG-PORT_$$$) for this value. Only the testing environment explicitly sets this port to 53200. This means the Kubernetes service will expose port 53200 in production, but the application may not be configured to bind to it, potentially causing an unresolved placeholder error at startup or silent misconfiguration.
Reviewed by Cursor Bugbot for commit d024716. Configure here.
d024716 to
c9d7cb9
Compare
2c1fc8c to
a757795
Compare
c9d7cb9 to
3440377
Compare
a757795 to
5f0a09b
Compare
3440377 to
29cead0
Compare
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
5f0a09b to
e847ef3
Compare
29cead0 to
dbe50c3
Compare



Devops repo counterpart: https://github.com/starkware-industries/sequencer-devops/pull/729