Skip to content

deployment: add service ports to hybrid common service overlays#14215

Open
nimrod-starkware wants to merge 1 commit into
05-28-deployment_extract_common_env_to_hybrid_common_common.yamlfrom
05-27-deployment_add_service_ports_to_hybrid_common_service_overlays
Open

deployment: add service ports to hybrid common service overlays#14215
nimrod-starkware wants to merge 1 commit into
05-28-deployment_extract_common_env_to_hybrid_common_common.yamlfrom
05-27-deployment_add_service_ports_to_hybrid_common_service_overlays

Conversation

@nimrod-starkware
Copy link
Copy Markdown
Contributor

@nimrod-starkware nimrod-starkware commented May 27, 2026

@reviewable-StarkWare
Copy link
Copy Markdown

This change is Reviewable

Copy link
Copy Markdown
Contributor Author

nimrod-starkware commented May 27, 2026

@cursor
Copy link
Copy Markdown

cursor Bot commented May 27, 2026

PR Summary

Low Risk
Pure deployment YAML exposing ports that already exist in sequencer config; no application or security logic changes.

Overview
Adds explicit Kubernetes service.ports blocks to the hybrid common overlays for core and mempool, so those workloads expose the same TCP ports already referenced in sequencerConfig (batcher, class-manager, consensus P2P, state-sync, signature-manager, storage readers on core; mempool and mempool P2P on mempool).

This brings core and mempool in line with other hybrid service overlays (e.g. gateway, committer) that already declare named ClusterIP ports for in-cluster access.

Reviewed by Cursor Bugbot for commit dbe50c3. Bugbot is set up for automated code reviews on this repo. Configure here.

@nimrod-starkware nimrod-starkware force-pushed the 05-27-deployment_add_service_ports_to_hybrid_common_service_overlays branch from e724308 to d024716 Compare May 28, 2026 07:07
@nimrod-starkware nimrod-starkware force-pushed the 05-26-deployment_define_common_env branch from 136955c to 338b58e Compare May 28, 2026 07:07
Copy link
Copy Markdown

@cursor cursor Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit d024716. Configure here.

- name: mempool-p2p-config
port: 53200
targetPort: 53200
protocol: TCP
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Service port exposed without matching application port config

Medium Severity

The mempool-p2p-config service port (53200) is added to the common overlay, but mempool_p2p_config.network_config.port is never set in the common sequencerConfig. Production environments (mainnet, sepolia-alpha, sepolia-integration) only include this common config with no overrides for mempool. The replacer config template contains an unresolved placeholder ($$$_MEMPOOL_P2P_CONFIG-NETWORK_CONFIG-PORT_$$$) for this value. Only the testing environment explicitly sets this port to 53200. This means the Kubernetes service will expose port 53200 in production, but the application may not be configured to bind to it, potentially causing an unresolved placeholder error at startup or silent misconfiguration.

Fix in Cursor Fix in Web

Reviewed by Cursor Bugbot for commit d024716. Configure here.

@nimrod-starkware nimrod-starkware force-pushed the 05-27-deployment_add_service_ports_to_hybrid_common_service_overlays branch from d024716 to c9d7cb9 Compare May 28, 2026 08:20
@nimrod-starkware nimrod-starkware force-pushed the 05-26-deployment_define_common_env branch 2 times, most recently from 2c1fc8c to a757795 Compare May 28, 2026 08:45
@nimrod-starkware nimrod-starkware force-pushed the 05-27-deployment_add_service_ports_to_hybrid_common_service_overlays branch from c9d7cb9 to 3440377 Compare May 28, 2026 08:45
@nimrod-starkware nimrod-starkware force-pushed the 05-26-deployment_define_common_env branch from a757795 to 5f0a09b Compare May 28, 2026 11:55
@nimrod-starkware nimrod-starkware force-pushed the 05-27-deployment_add_service_ports_to_hybrid_common_service_overlays branch from 3440377 to 29cead0 Compare May 28, 2026 11:55
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@nimrod-starkware nimrod-starkware changed the base branch from 05-26-deployment_define_common_env to graphite-base/14215 May 28, 2026 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants