deployment: add startup probe to hybrid environment overlays#14188
Conversation
This stack of pull requests is managed by Graphite. Learn more about stacking. |
PR SummaryLow Risk Overview Pods will not be treated as failed during slow boot: the probe calls Reviewed by Cursor Bugbot for commit e507038. Bugbot is set up for automated code reviews on this repo. Configure here. |
d8e23d7 to
83f75be
Compare
b5bfb54 to
2aa4c85
Compare
dorimedini-starkware
left a comment
There was a problem hiding this comment.
@dorimedini-starkware reviewed 3 files and all commit messages, and made 1 comment.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on idan-starkware, matanl-starkware, and nimrod-starkware).
deployments/sequencer/configs/overlays/hybrid/mainnet/common.yaml line 29 at r1 (raw file):
failureThreshold: 30 periodSeconds: 5 timeoutSeconds: 2
I notice these are not alphabetical, this yml is not auto-generated, right?
can you add a test that verifies all manual ymls are sorted? (since this is under the deployments directory, I guess you can do it in python)
not blocking this PR - this is a side quest. it will make reviewing easier (when reviewing this PR i would like to remember "1,30,5,2", and the rely on alphabetical order to make sure the same values go to the same fields)
Code quote:
startupProbe:
enabled: true
path: /monitoring/alive
successThreshold: 1
failureThreshold: 30
periodSeconds: 5
timeoutSeconds: 22aa4c85 to
9581509
Compare
83f75be to
190ea79
Compare
dorimedini-starkware
left a comment
There was a problem hiding this comment.
@dorimedini-starkware reviewed 3 files and all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on idan-starkware, matanl-starkware, and nimrod-starkware).
d5d5810 to
d3e90a7
Compare
02c9169 to
4c02805
Compare
d3e90a7 to
e507038
Compare
Merge activity
|
dorimedini-starkware
left a comment
There was a problem hiding this comment.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on idan-starkware, matanl-starkware, and nimrod-starkware).
nimrod-starkware
left a comment
There was a problem hiding this comment.
@nimrod-starkware resolved 1 discussion.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on idan-starkware and matanl-starkware).

Cross-repo PR: https://github.com/starkware-industries/sequencer-devops/pull/713
Cross-repo PR: https://github.com/starkware-industries/sequencer-devops/pull/713