Skip to content

deployment: add startup probe to hybrid environment overlays#14188

Merged
nimrod-starkware merged 1 commit into
main-v0.14.3from
05-25-deployment_add_startup_probe_to_hybrid_environment_overlays
May 28, 2026
Merged

deployment: add startup probe to hybrid environment overlays#14188
nimrod-starkware merged 1 commit into
main-v0.14.3from
05-25-deployment_add_startup_probe_to_hybrid_environment_overlays

Conversation

@nimrod-starkware
Copy link
Copy Markdown
Contributor

@nimrod-starkware nimrod-starkware commented May 25, 2026

@reviewable-StarkWare
Copy link
Copy Markdown

This change is Reviewable

@cursor
Copy link
Copy Markdown

cursor Bot commented May 25, 2026

PR Summary

Low Risk
Operational-only Kubernetes probe settings; no application logic, auth, or chain config changes beyond rollout behavior during pod startup.

Overview
Enables Kubernetes startup probes on hybrid sequencer deployments for mainnet, sepolia-alpha, and sepolia-integration by adding the same startupProbe block to each environment’s common.yaml overlay.

Pods will not be treated as failed during slow boot: the probe calls /monitoring/alive on the existing monitoring port (8082), with 5s intervals, 2s timeouts, and up to 30 failures (~2.5 minutes max startup) before Kubernetes gives up. This overrides the layout default of an empty startupProbe: {} for these networks only.

Reviewed by Cursor Bugbot for commit e507038. Bugbot is set up for automated code reviews on this repo. Configure here.

Copy link
Copy Markdown
Collaborator

@dorimedini-starkware dorimedini-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dorimedini-starkware reviewed 3 files and all commit messages, and made 1 comment.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on idan-starkware, matanl-starkware, and nimrod-starkware).


deployments/sequencer/configs/overlays/hybrid/mainnet/common.yaml line 29 at r1 (raw file):

  failureThreshold: 30
  periodSeconds: 5
  timeoutSeconds: 2

I notice these are not alphabetical, this yml is not auto-generated, right?
can you add a test that verifies all manual ymls are sorted? (since this is under the deployments directory, I guess you can do it in python)
not blocking this PR - this is a side quest. it will make reviewing easier (when reviewing this PR i would like to remember "1,30,5,2", and the rely on alphabetical order to make sure the same values go to the same fields)

Code quote:

startupProbe:
  enabled: true
  path: /monitoring/alive
  successThreshold: 1
  failureThreshold: 30
  periodSeconds: 5
  timeoutSeconds: 2

@nimrod-starkware nimrod-starkware force-pushed the 05-25-deployment_add_startup_probe_to_hybrid_environment_overlays branch from 2aa4c85 to 9581509 Compare May 28, 2026 07:07
@nimrod-starkware nimrod-starkware force-pushed the 05-25-deployment_add_monitoring_endpoint_port_to_hybrid_environment_overlays branch from 83f75be to 190ea79 Compare May 28, 2026 07:07
Copy link
Copy Markdown
Collaborator

@dorimedini-starkware dorimedini-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dorimedini-starkware reviewed 3 files and all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on idan-starkware, matanl-starkware, and nimrod-starkware).

@nimrod-starkware nimrod-starkware force-pushed the 05-25-deployment_add_startup_probe_to_hybrid_environment_overlays branch 2 times, most recently from d5d5810 to d3e90a7 Compare May 28, 2026 08:45
@nimrod-starkware nimrod-starkware force-pushed the 05-25-deployment_add_monitoring_endpoint_port_to_hybrid_environment_overlays branch from 02c9169 to 4c02805 Compare May 28, 2026 08:45
@nimrod-starkware nimrod-starkware changed the base branch from 05-25-deployment_add_monitoring_endpoint_port_to_hybrid_environment_overlays to main-v0.14.3 May 28, 2026 09:09
@nimrod-starkware nimrod-starkware force-pushed the 05-25-deployment_add_startup_probe_to_hybrid_environment_overlays branch from d3e90a7 to e507038 Compare May 28, 2026 09:09
@graphite-app
Copy link
Copy Markdown

graphite-app Bot commented May 28, 2026

Merge activity

  • May 28, 9:10 AM UTC: Graphite rebased this pull request, because this pull request is set to merge when ready.

Copy link
Copy Markdown
Collaborator

@dorimedini-starkware dorimedini-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on idan-starkware, matanl-starkware, and nimrod-starkware).

Copy link
Copy Markdown
Contributor Author

@nimrod-starkware nimrod-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nimrod-starkware resolved 1 discussion.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on idan-starkware and matanl-starkware).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants