Skip to content

deployment: add monitoring endpoint port to hybrid environment overlays#14187

Merged
nimrod-starkware merged 1 commit into
main-v0.14.3from
05-25-deployment_add_monitoring_endpoint_port_to_hybrid_environment_overlays
May 28, 2026
Merged

deployment: add monitoring endpoint port to hybrid environment overlays#14187
nimrod-starkware merged 1 commit into
main-v0.14.3from
05-25-deployment_add_monitoring_endpoint_port_to_hybrid_environment_overlays

Conversation

@nimrod-starkware
Copy link
Copy Markdown
Contributor

@nimrod-starkware nimrod-starkware commented May 25, 2026

@reviewable-StarkWare
Copy link
Copy Markdown

This change is Reviewable

@cursor
Copy link
Copy Markdown

cursor Bot commented May 25, 2026

PR Summary

Low Risk
Kubernetes Service port additions only; no sequencer logic, auth, or chain config changes.

Overview
Adds a service.ports entry for monitoring-endpoint (TCP 8082 → container 8082) to the hybrid sequencer common.yaml overlays for mainnet, sepolia-alpha, and sepolia-integration, so the Kubernetes Service exposes the sequencer monitoring/metrics port in those environments.

Sequencer app config and env blocks are unchanged; only Service port exposure is added, aligned with the commented example in the hybrid layout.

Reviewed by Cursor Bugbot for commit 4c02805. Bugbot is set up for automated code reviews on this repo. Configure here.

Copy link
Copy Markdown
Collaborator

@dorimedini-starkware dorimedini-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dorimedini-starkware reviewed 3 files and all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on idan-starkware and matanl-starkware).

@nimrod-starkware nimrod-starkware force-pushed the 05-25-deployment_add_service_ports_to_hybrid_environment_overlays branch from e20360d to 2221ad8 Compare May 28, 2026 07:07
@nimrod-starkware nimrod-starkware force-pushed the 05-25-deployment_add_monitoring_endpoint_port_to_hybrid_environment_overlays branch from 83f75be to 190ea79 Compare May 28, 2026 07:07
Copy link
Copy Markdown
Collaborator

@dorimedini-starkware dorimedini-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dorimedini-starkware reviewed 3 files and all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on idan-starkware and matanl-starkware).

@nimrod-starkware nimrod-starkware changed the base branch from 05-25-deployment_add_service_ports_to_hybrid_environment_overlays to main May 28, 2026 08:01
@nimrod-starkware nimrod-starkware force-pushed the 05-25-deployment_add_monitoring_endpoint_port_to_hybrid_environment_overlays branch from 190ea79 to 02c9169 Compare May 28, 2026 08:20
Copy link
Copy Markdown
Collaborator

@dorimedini-starkware dorimedini-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dorimedini-starkware made 1 comment.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on idan-starkware, matanl-starkware, and nimrod-starkware).


a discussion (no related file):
rebase over 0.14.3 pls

@nimrod-starkware nimrod-starkware changed the base branch from main to graphite-base/14187 May 28, 2026 08:44
@nimrod-starkware nimrod-starkware force-pushed the 05-25-deployment_add_monitoring_endpoint_port_to_hybrid_environment_overlays branch from 02c9169 to 4c02805 Compare May 28, 2026 08:45
@nimrod-starkware nimrod-starkware changed the base branch from graphite-base/14187 to main-v0.14.3 May 28, 2026 08:45
Copy link
Copy Markdown
Contributor Author

@nimrod-starkware nimrod-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nimrod-starkware made 1 comment.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on dorimedini-starkware, idan-starkware, and matanl-starkware).


a discussion (no related file):

Previously, dorimedini-starkware wrote…

rebase over 0.14.3 pls

Done.

Copy link
Copy Markdown
Collaborator

@dorimedini-starkware dorimedini-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dorimedini-starkware resolved 1 discussion.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on idan-starkware and matanl-starkware).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants