Skip to content

deployment: move network and consensus ports to hybrid environment overlays#14183

Merged
nimrod-starkware merged 1 commit into
mainfrom
05-25-deployment_add_storage_reader_state_sync_network_and_consensus_ports_to_hybrid_environment_overlays
May 28, 2026
Merged

deployment: move network and consensus ports to hybrid environment overlays#14183
nimrod-starkware merged 1 commit into
mainfrom
05-25-deployment_add_storage_reader_state_sync_network_and_consensus_ports_to_hybrid_environment_overlays

Conversation

@nimrod-starkware
Copy link
Copy Markdown
Contributor

@nimrod-starkware nimrod-starkware commented May 25, 2026

@reviewable-StarkWare
Copy link
Copy Markdown

This change is Reviewable

@nimrod-starkware nimrod-starkware force-pushed the 05-25-deployment_add_storage_reader_state_sync_network_and_consensus_ports_to_hybrid_environment_overlays branch from ad8129b to 7b0b0a0 Compare May 25, 2026 08:44
@nimrod-starkware nimrod-starkware changed the title deployment: add storage_reader, state_sync network and consensus ports to hybrid environment overlays deployment: move network and consensus ports to hybrid environment overlays May 25, 2026
@nimrod-starkware nimrod-starkware self-assigned this May 25, 2026
@nimrod-starkware nimrod-starkware marked this pull request as ready for review May 25, 2026 08:47
@cursor
Copy link
Copy Markdown

cursor Bot commented May 25, 2026

PR Summary

Medium Risk
Production hybrid deployments depend on correct listener ports for consensus and state sync; misconfiguration could break node connectivity until rolled back.

Overview
Adds hybrid core service overlay port and networking settings for mainnet, sepolia-alpha, and sepolia-integration so consensus, state sync, batcher/class storage readers, and RPC listen addresses are defined per environment instead of relying on shared defaults.

Each overlay now sets consensus_manager_config.network_config.port 53080, batcher/class storage reader ports 55011 / 55210, and state sync P2P port 55010, RPC 8090, and storage reader 55012. Mainnet enables state sync network_config (#is_none: false); sepolia-alpha and sepolia-integration keep state sync network config disabled (#is_none: true) while still pinning the port values for when devops wires services up.

This matches the paired devops work to expose the same ports in Kubernetes.

Reviewed by Cursor Bugbot for commit e267b09. Bugbot is set up for automated code reviews on this repo. Configure here.

Copy link
Copy Markdown

@cursor cursor Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 7b0b0a0. Configure here.

Copy link
Copy Markdown
Collaborator

@dorimedini-starkware dorimedini-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dorimedini-starkware reviewed 3 files and all commit messages, and made 2 comments.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on idan-starkware, matanl-starkware, and nimrod-starkware).


a discussion (no related file):
general question: is there a config that is common for all networks? because all these values are identical.. is this a planned feature? part of the jsonnet migration?

@nimrod-starkware nimrod-starkware changed the base branch from 05-25-deployment_add_component_ports_and_urls_to_hybrid_environment_overlays to graphite-base/14183 May 28, 2026 05:54
@nimrod-starkware nimrod-starkware force-pushed the 05-25-deployment_add_storage_reader_state_sync_network_and_consensus_ports_to_hybrid_environment_overlays branch from 6a1e8cc to e267b09 Compare May 28, 2026 05:55
@nimrod-starkware nimrod-starkware changed the base branch from graphite-base/14183 to main May 28, 2026 05:55
Copy link
Copy Markdown
Contributor Author

@nimrod-starkware nimrod-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nimrod-starkware made 2 comments.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on dorimedini-starkware, idan-starkware, and matanl-starkware).


a discussion (no related file):

Previously, dorimedini-starkware wrote…

general question: is there a config that is common for all networks? because all these values are identical.. is this a planned feature? part of the jsonnet migration?

Yes, see this.
It's in this stack...

Copy link
Copy Markdown
Collaborator

@dorimedini-starkware dorimedini-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dorimedini-starkware resolved 2 discussions.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on idan-starkware and matanl-starkware).

@nimrod-starkware nimrod-starkware added this pull request to the merge queue May 28, 2026
Merged via the queue into main with commit d1fb3ca May 28, 2026
53 of 64 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants