Skip to content

deployment: extract mempool common config#14247

Open
nimrod-starkware wants to merge 1 commit into
05-28-deployment_extract_gateway_common_configfrom
05-28-deployment_extract_mempool_common_config
Open

deployment: extract mempool common config#14247
nimrod-starkware wants to merge 1 commit into
05-28-deployment_extract_gateway_common_configfrom
05-28-deployment_extract_mempool_common_config

Conversation

@nimrod-starkware
Copy link
Copy Markdown
Contributor

No description provided.

Copy link
Copy Markdown
Contributor Author

nimrod-starkware commented May 28, 2026

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

@reviewable-StarkWare
Copy link
Copy Markdown

This change is Reviewable

@nimrod-starkware nimrod-starkware self-assigned this May 28, 2026
@nimrod-starkware nimrod-starkware marked this pull request as ready for review May 28, 2026 13:26
@cursor
Copy link
Copy Markdown

cursor Bot commented May 28, 2026

PR Summary

Low Risk
Config-only refactor with no intended runtime behavior change; risk is limited to a mis-merged include path breaking deployment for those environments.

Overview
Deduplicates hybrid mempool deployment config by moving the shared mempool service definition into configs/overlays/hybrid/common/services/mempool.yaml and wiring mainnet, sepolia-alpha, and sepolia-integration overlays to it via include:.

Per-environment mempool.yaml files no longer repeat configList, component URLs/ports, or mempool_config.dynamic_config.transaction_ttl; they only reference the common file, matching how other hybrid services (e.g. gateway, committer) are structured.

Reviewed by Cursor Bugbot for commit bc3fd9d. Bugbot is set up for automated code reviews on this repo. Configure here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants