Skip to content

deployment: make gcpPodMonitoring enable configurable#14240

Open
nimrod-starkware wants to merge 1 commit into
05-28-deployment_fix_storage_reader_portfrom
nimrod/fix-enabled-gcp-pod
Open

deployment: make gcpPodMonitoring enable configurable#14240
nimrod-starkware wants to merge 1 commit into
05-28-deployment_fix_storage_reader_portfrom
nimrod/fix-enabled-gcp-pod

Conversation

@nimrod-starkware
Copy link
Copy Markdown
Contributor

No description provided.

@reviewable-StarkWare
Copy link
Copy Markdown

This change is Reviewable

Copy link
Copy Markdown
Contributor Author

nimrod-starkware commented May 28, 2026

@nimrod-starkware nimrod-starkware self-assigned this May 28, 2026
@nimrod-starkware nimrod-starkware marked this pull request as ready for review May 28, 2026 11:56
@cursor
Copy link
Copy Markdown

cursor Bot commented May 28, 2026

PR Summary

Low Risk
YAML-only change to observability defaults; main operational risk is unintended PodMonitoring CR creation if missing enabled is treated as true elsewhere—worth confirming renderer defaults before rollout.

Overview
Removes the hardcoded gcpPodMonitoring.enabled: false entry from all six hybrid sequencer service layout files (committer, core, gateway, l1, mempool, sierra-compiler). Each file still documents scrape spec (port 8082, /monitoring/metrics, etc.); only the per-service “always off” flag is dropped.

That matches the deployment docs pattern where gcpPodMonitoring.enabled is the switch for creating GCP PodMonitoring CRs, so hybrid services are no longer forced disabled at the preset layer and enablement can be controlled via overrides or environment-specific values (as in the consolidated layout, which still shows enabled: false explicitly).

Reviewed by Cursor Bugbot for commit 8fad7cb. Bugbot is set up for automated code reviews on this repo. Configure here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants