Skip to content

deployment: support include directive in common yaml loader#14242

Open
nimrod-starkware wants to merge 2 commits into
main-v0.14.3from
05-28-deployment_support_include_directive_in_common_yaml_loader
Open

deployment: support include directive in common yaml loader#14242
nimrod-starkware wants to merge 2 commits into
main-v0.14.3from
05-28-deployment_support_include_directive_in_common_yaml_loader

Conversation

@nimrod-starkware
Copy link
Copy Markdown
Contributor

No description provided.

@reviewable-StarkWare
Copy link
Copy Markdown

This change is Reviewable

@nimrod-starkware nimrod-starkware marked this pull request as ready for review May 28, 2026 13:24
@nimrod-starkware nimrod-starkware self-assigned this May 28, 2026
@cursor
Copy link
Copy Markdown

cursor Bot commented May 28, 2026

PR Summary

Medium Risk
Changes how layout/overlay common config is assembled; mis-resolved includes or merge order could alter deployed sequencer settings without touching service YAML.

Overview
Common YAML loading now resolves include: fragments the same way service configs already do, instead of reading a single file with yaml.safe_load.

_load_common_yaml takes an optional config_base_dir and uses DeploymentConfigLoader._load_one_file_with_includes before CommonConfig validation. merge_configs passes config_base_dir when loading layout and overlay common.yaml paths so relative includes resolve from the deployment root.

Reviewed by Cursor Bugbot for commit 11f665a. Bugbot is set up for automated code reviews on this repo. Configure here.

@nimrod-starkware nimrod-starkware changed the base branch from 05-25-deployment_add_gcp_pod_monitoring_to_hybrid_environment_overlays to main-v0.14.3 May 28, 2026 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants