Skip to content

deployment: add liveness probe to hybrid environment overlays#14191

Merged
nimrod-starkware merged 1 commit into
main-v0.14.3from
05-25-deployment_add_liveness_probe_to_hybrid_environment_overlays
May 28, 2026
Merged

deployment: add liveness probe to hybrid environment overlays#14191
nimrod-starkware merged 1 commit into
main-v0.14.3from
05-25-deployment_add_liveness_probe_to_hybrid_environment_overlays

Conversation

@nimrod-starkware
Copy link
Copy Markdown
Contributor

@nimrod-starkware nimrod-starkware commented May 25, 2026

@reviewable-StarkWare
Copy link
Copy Markdown

This change is Reviewable

@cursor
Copy link
Copy Markdown

cursor Bot commented May 25, 2026

PR Summary

Medium Risk
Liveness on production hybrid sequencer environments can restart pods after probe failures; mis-tuned thresholds or a flaky /monitoring/alive endpoint could cause unnecessary restarts during incidents.

Overview
Enables Kubernetes liveness probes on hybrid sequencer deployments for mainnet, sepolia-alpha, and sepolia-integration by adding the same livenessProbe block to each environment’s common.yaml overlay.

Each overlay now probes /monitoring/alive (matching startup) with a 10s period, 5 consecutive failures before restart, and a 3s timeout. Readiness and startup probe settings in those files are unchanged.

This turns on automatic pod restart when the process stops responding on the monitoring port, whereas previously only startup/readiness were configured in these three overlays.

Reviewed by Cursor Bugbot for commit 6b358a7. Bugbot is set up for automated code reviews on this repo. Configure here.

Copy link
Copy Markdown
Collaborator

@dorimedini-starkware dorimedini-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dorimedini-starkware reviewed 3 files and all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on idan-starkware and matanl-starkware).

@nimrod-starkware nimrod-starkware force-pushed the 05-25-deployment_add_readiness_probe_to_hybrid_environment_overlays branch from c4f112d to a1fa8c7 Compare May 28, 2026 07:07
@nimrod-starkware nimrod-starkware force-pushed the 05-25-deployment_add_liveness_probe_to_hybrid_environment_overlays branch from d83a51d to b31f574 Compare May 28, 2026 07:07
Copy link
Copy Markdown
Collaborator

@dorimedini-starkware dorimedini-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dorimedini-starkware reviewed 3 files and all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on idan-starkware and matanl-starkware).

@nimrod-starkware nimrod-starkware force-pushed the 05-25-deployment_add_readiness_probe_to_hybrid_environment_overlays branch from a1fa8c7 to e851af2 Compare May 28, 2026 08:20
@nimrod-starkware nimrod-starkware force-pushed the 05-25-deployment_add_liveness_probe_to_hybrid_environment_overlays branch 2 times, most recently from 920c50e to bcd275f Compare May 28, 2026 08:45
@nimrod-starkware nimrod-starkware force-pushed the 05-25-deployment_add_readiness_probe_to_hybrid_environment_overlays branch from e851af2 to 5c3ae4b Compare May 28, 2026 08:45
@graphite-app graphite-app Bot changed the base branch from 05-25-deployment_add_readiness_probe_to_hybrid_environment_overlays to graphite-base/14191 May 28, 2026 10:11
@nimrod-starkware nimrod-starkware force-pushed the 05-25-deployment_add_liveness_probe_to_hybrid_environment_overlays branch from bcd275f to 6b358a7 Compare May 28, 2026 11:20
@graphite-app graphite-app Bot changed the base branch from graphite-base/14191 to main-v0.14.3 May 28, 2026 11:20
@graphite-app
Copy link
Copy Markdown

graphite-app Bot commented May 28, 2026

Merge activity

  • May 28, 11:20 AM UTC: Graphite rebased this pull request, because this pull request is set to merge when ready.

Copy link
Copy Markdown
Collaborator

@dorimedini-starkware dorimedini-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on idan-starkware and matanl-starkware).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants