Skip to content

deployment: extract core common config#14248

Open
nimrod-starkware wants to merge 1 commit into
05-28-deployment_extract_mempool_common_configfrom
05-28-deployment_extract_core_common_config
Open

deployment: extract core common config#14248
nimrod-starkware wants to merge 1 commit into
05-28-deployment_extract_mempool_common_configfrom
05-28-deployment_extract_core_common_config

Conversation

@nimrod-starkware
Copy link
Copy Markdown
Contributor

No description provided.

Copy link
Copy Markdown
Contributor Author

nimrod-starkware commented May 28, 2026

@reviewable-StarkWare
Copy link
Copy Markdown

This change is Reviewable

@nimrod-starkware nimrod-starkware self-assigned this May 28, 2026
@nimrod-starkware nimrod-starkware marked this pull request as ready for review May 28, 2026 13:26
@cursor
Copy link
Copy Markdown

cursor Bot commented May 28, 2026

PR Summary

Low Risk
Config-only DRY refactor with no application code changes; deploy risk is limited to overlay merge/include behavior if misconfigured.

Overview
Introduces configs/overlays/hybrid/common/services/core.yaml and points mainnet, sepolia-alpha, and sepolia-integration core.yaml overlays at it via include, so shared hybrid core sequencer settings live in one place.

Each environment file now only overrides what differs—batcher concurrency/workers, partial-block hash anchors, min_l2_gas_price_per_height, default committee, and state-sync/network flags—instead of repeating the full shared block (component URLs/ports, consensus timeouts, bouncer caps, class manager limits, etc.). configList is defined once in the common file and dropped from the per-env copies.

Reviewed by Cursor Bugbot for commit fe8122d. Bugbot is set up for automated code reviews on this repo. Configure here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants