Skip to content

deployment: add readiness probe to hybrid environment overlays#14190

Merged
nimrod-starkware merged 1 commit into
main-v0.14.3from
05-25-deployment_add_readiness_probe_to_hybrid_environment_overlays
May 28, 2026
Merged

deployment: add readiness probe to hybrid environment overlays#14190
nimrod-starkware merged 1 commit into
main-v0.14.3from
05-25-deployment_add_readiness_probe_to_hybrid_environment_overlays

Conversation

@nimrod-starkware
Copy link
Copy Markdown
Contributor

@nimrod-starkware nimrod-starkware commented May 25, 2026

@reviewable-StarkWare
Copy link
Copy Markdown

This change is Reviewable

@cursor
Copy link
Copy Markdown

cursor Bot commented May 25, 2026

PR Summary

Low Risk
Kubernetes deployment overlay only; no application logic changes, with modest rollout behavior impact if /monitoring/ready is misconfigured.

Overview
Adds an enabled readiness probe on /monitoring/ready to the hybrid sequencer common overlays for mainnet, sepolia-alpha, and sepolia-integration, alongside the existing startup probe on /monitoring/alive.

Probe settings are aligned across environments: 5s period, 2s timeout, success threshold 2, failure threshold 3. Pods should only receive traffic once the sequencer reports ready, improving rolling updates and avoiding routing to instances that are up but not yet serving.

Reviewed by Cursor Bugbot for commit d451897. Bugbot is set up for automated code reviews on this repo. Configure here.

Copy link
Copy Markdown
Collaborator

@dorimedini-starkware dorimedini-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dorimedini-starkware reviewed 3 files and all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on idan-starkware and matanl-starkware).

@nimrod-starkware nimrod-starkware force-pushed the 05-25-deployment_add_readiness_probe_to_hybrid_environment_overlays branch from c4f112d to a1fa8c7 Compare May 28, 2026 07:07
@nimrod-starkware nimrod-starkware force-pushed the 05-25-deployment_add_startup_probe_to_hybrid_environment_overlays branch from 2aa4c85 to 9581509 Compare May 28, 2026 07:07
Copy link
Copy Markdown
Collaborator

@dorimedini-starkware dorimedini-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dorimedini-starkware reviewed 3 files and all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on idan-starkware and matanl-starkware).

@nimrod-starkware nimrod-starkware force-pushed the 05-25-deployment_add_startup_probe_to_hybrid_environment_overlays branch from 9581509 to d5d5810 Compare May 28, 2026 08:20
@nimrod-starkware nimrod-starkware force-pushed the 05-25-deployment_add_readiness_probe_to_hybrid_environment_overlays branch from a1fa8c7 to e851af2 Compare May 28, 2026 08:20
@nimrod-starkware nimrod-starkware force-pushed the 05-25-deployment_add_startup_probe_to_hybrid_environment_overlays branch from d5d5810 to d3e90a7 Compare May 28, 2026 08:45
@nimrod-starkware nimrod-starkware force-pushed the 05-25-deployment_add_readiness_probe_to_hybrid_environment_overlays branch from e851af2 to 5c3ae4b Compare May 28, 2026 08:45
@graphite-app graphite-app Bot changed the base branch from 05-25-deployment_add_startup_probe_to_hybrid_environment_overlays to graphite-base/14190 May 28, 2026 09:09
@nimrod-starkware nimrod-starkware force-pushed the 05-25-deployment_add_readiness_probe_to_hybrid_environment_overlays branch from 5c3ae4b to d451897 Compare May 28, 2026 10:11
@graphite-app graphite-app Bot changed the base branch from graphite-base/14190 to main-v0.14.3 May 28, 2026 10:12
@graphite-app
Copy link
Copy Markdown

graphite-app Bot commented May 28, 2026

Merge activity

  • May 28, 10:12 AM UTC: Graphite rebased this pull request, because this pull request is set to merge when ready.

Copy link
Copy Markdown
Collaborator

@dorimedini-starkware dorimedini-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on idan-starkware and matanl-starkware).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants