Skip to content

deployment: add gcp pod monitoring to hybrid environment overlays#14192

Merged
nimrod-starkware merged 1 commit into
main-v0.14.3from
05-25-deployment_add_gcp_pod_monitoring_to_hybrid_environment_overlays
May 28, 2026
Merged

deployment: add gcp pod monitoring to hybrid environment overlays#14192
nimrod-starkware merged 1 commit into
main-v0.14.3from
05-25-deployment_add_gcp_pod_monitoring_to_hybrid_environment_overlays

Conversation

@nimrod-starkware
Copy link
Copy Markdown
Contributor

@nimrod-starkware nimrod-starkware commented May 25, 2026

@reviewable-StarkWare
Copy link
Copy Markdown

This change is Reviewable

@nimrod-starkware nimrod-starkware self-assigned this May 26, 2026
@nimrod-starkware nimrod-starkware marked this pull request as ready for review May 26, 2026 06:29
@cursor
Copy link
Copy Markdown

cursor Bot commented May 26, 2026

PR Summary

Low Risk
Observability-only Helm overlay changes; no application logic, auth, or runtime behavior changes beyond enabling metrics scraping.

Overview
Enables GCP PodMonitoring in the shared hybrid overlay configs for mainnet, sepolia-alpha, and sepolia-integration, turning on metrics collection that the chart already supports but leaves off by default.

Each overlay now sets gcpPodMonitoring.enabled: true with a single scrape endpoint on port 8082 at /monitoring/metrics every 10s, aligned with the existing monitoring service port and probe paths in those files.

Reviewed by Cursor Bugbot for commit 1c7704b. Bugbot is set up for automated code reviews on this repo. Configure here.

Copy link
Copy Markdown

@cursor cursor Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 77b2c59. Configure here.

Comment thread deployments/sequencer/configs/overlays/hybrid/mainnet/common.yaml
@nimrod-starkware nimrod-starkware force-pushed the 05-25-deployment_add_liveness_probe_to_hybrid_environment_overlays branch from 0a4630d to d83a51d Compare May 27, 2026 06:27
@nimrod-starkware nimrod-starkware force-pushed the 05-25-deployment_add_gcp_pod_monitoring_to_hybrid_environment_overlays branch from 77b2c59 to 60cdcb3 Compare May 27, 2026 06:27
Copy link
Copy Markdown
Collaborator

@dorimedini-starkware dorimedini-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dorimedini-starkware reviewed 3 files and all commit messages, and made 1 comment.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on idan-starkware, matanl-starkware, and nimrod-starkware).

Comment thread deployments/sequencer/configs/overlays/hybrid/mainnet/common.yaml
@nimrod-starkware nimrod-starkware force-pushed the 05-25-deployment_add_liveness_probe_to_hybrid_environment_overlays branch from d83a51d to b31f574 Compare May 28, 2026 07:07
@nimrod-starkware nimrod-starkware force-pushed the 05-25-deployment_add_gcp_pod_monitoring_to_hybrid_environment_overlays branch from 60cdcb3 to 0095911 Compare May 28, 2026 07:07
Copy link
Copy Markdown
Collaborator

@dorimedini-starkware dorimedini-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dorimedini-starkware reviewed 3 files and all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on idan-starkware, matanl-starkware, and nimrod-starkware).

@nimrod-starkware nimrod-starkware force-pushed the 05-25-deployment_add_liveness_probe_to_hybrid_environment_overlays branch from b31f574 to 920c50e Compare May 28, 2026 08:20
@nimrod-starkware nimrod-starkware force-pushed the 05-25-deployment_add_gcp_pod_monitoring_to_hybrid_environment_overlays branch from 0095911 to be28414 Compare May 28, 2026 08:20
@nimrod-starkware nimrod-starkware force-pushed the 05-25-deployment_add_gcp_pod_monitoring_to_hybrid_environment_overlays branch from be28414 to f040425 Compare May 28, 2026 08:45
@nimrod-starkware nimrod-starkware force-pushed the 05-25-deployment_add_liveness_probe_to_hybrid_environment_overlays branch from 920c50e to bcd275f Compare May 28, 2026 08:45
@graphite-app graphite-app Bot changed the base branch from 05-25-deployment_add_liveness_probe_to_hybrid_environment_overlays to graphite-base/14192 May 28, 2026 11:19
@nimrod-starkware nimrod-starkware force-pushed the 05-25-deployment_add_gcp_pod_monitoring_to_hybrid_environment_overlays branch from f040425 to 87bd0a1 Compare May 28, 2026 11:55
@nimrod-starkware nimrod-starkware changed the base branch from graphite-base/14192 to 05-25-deployment_add_liveness_probe_to_hybrid_environment_overlays May 28, 2026 11:55
Copy link
Copy Markdown
Contributor Author

@nimrod-starkware nimrod-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nimrod-starkware made 1 comment.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on dorimedini-starkware, idan-starkware, and matanl-starkware).

Comment thread deployments/sequencer/configs/overlays/hybrid/mainnet/common.yaml
Copy link
Copy Markdown
Collaborator

@dorimedini-starkware dorimedini-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dorimedini-starkware resolved 1 discussion.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on idan-starkware and matanl-starkware).

@graphite-app graphite-app Bot changed the base branch from 05-25-deployment_add_liveness_probe_to_hybrid_environment_overlays to main-v0.14.3 May 28, 2026 13:02
@nimrod-starkware nimrod-starkware force-pushed the 05-25-deployment_add_gcp_pod_monitoring_to_hybrid_environment_overlays branch from 87bd0a1 to 1c7704b Compare May 28, 2026 13:03
@graphite-app
Copy link
Copy Markdown

graphite-app Bot commented May 28, 2026

Merge activity

  • May 28, 1:03 PM UTC: Graphite rebased this pull request, because this pull request is set to merge when ready.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants