Skip to content

deployment: add service ports to hybrid common service overlays#14209

Closed
nimrod-starkware wants to merge 1 commit into
05-26-deployment_define_common_envfrom
05-27-deployment_add_service_ports_to_hybrid_common_service_overlays
Closed

deployment: add service ports to hybrid common service overlays#14209
nimrod-starkware wants to merge 1 commit into
05-26-deployment_define_common_envfrom
05-27-deployment_add_service_ports_to_hybrid_common_service_overlays

Conversation

@nimrod-starkware
Copy link
Copy Markdown
Contributor

No description provided.

@reviewable-StarkWare
Copy link
Copy Markdown

This change is Reviewable

Copy link
Copy Markdown
Contributor Author

nimrod-starkware commented May 27, 2026

@nimrod-starkware nimrod-starkware self-assigned this May 27, 2026
@nimrod-starkware nimrod-starkware marked this pull request as ready for review May 27, 2026 07:30
@cursor
Copy link
Copy Markdown

cursor Bot commented May 27, 2026

PR Summary

Low Risk
Deployment-only service port wiring with no application or security logic changes; misaligned ports could affect cluster connectivity.

Overview
The hybrid common service overlays now declare Kubernetes service.ports for core and mempool, where the base layout left ports empty.

For core, nine named TCP ports are exposed (batcher, storage readers, class manager, consensus P2P, signature manager, and state-sync RPC/network/storage), matching the component and static config ports already set in the same overlay.

For mempool, the service exposes the main mempool port and mempool-p2p-config (53200), consistent with existing components.mempool wiring.

Reviewed by Cursor Bugbot for commit e015994. Bugbot is set up for automated code reviews on this repo. Configure here.

@nimrod-starkware
Copy link
Copy Markdown
Contributor Author

Reverted — include order conflict: common/common.yaml's service.ports=[monitoring-endpoint] is brought into the service include chain via common_node.yaml and overwrites the service-specific ports. The migration is not safe without addressing include ordering first.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants