Skip to content

starknet_os: os resources test - create fixed deployable account#14173

Open
dorimedini-starkware wants to merge 1 commit into
mainfrom
05-24-starknet_os_os_resources_test_-_create_fixed_deployable_account
Open

starknet_os: os resources test - create fixed deployable account#14173
dorimedini-starkware wants to merge 1 commit into
mainfrom
05-24-starknet_os_os_resources_test_-_create_fixed_deployable_account

Conversation

@dorimedini-starkware
Copy link
Copy Markdown
Collaborator

No description provided.

@reviewable-StarkWare
Copy link
Copy Markdown

This change is Reviewable

@cursor
Copy link
Copy Markdown

cursor Bot commented May 24, 2026

PR Summary

Low Risk
Test-only fixtures and static loaders; no production OS or runtime behavior changes in this diff.

Overview
Adds a fixed, precompiled deployable account for Starknet OS flow tests so deployment resource measurements stay deterministic.

New assets under crates/starknet_os_flow_tests/resources/: deployable_for_resource_measurement.cairo (minimal account with __validate__, __validate_deploy__, __execute__, constructor, and span-calldata entry points) plus checked-in Sierra/CASM JSON (compiler v2.17.0). special_contracts.rs exposes DEPLOYABLE_FOR_RESOURCE_MEASUREMENT_CONTRACT_SIERRA and _CASM via LazyLock (currently #[expect(dead_code)] until wired into tests) and reuses a CompilerContractClass type alias for existing loaders.

Reviewed by Cursor Bugbot for commit 6593ca5. Bugbot is set up for automated code reviews on this repo. Configure here.

@dorimedini-starkware dorimedini-starkware force-pushed the 05-24-starknet_os_os_resources_test_-_create_fixed_deployable_account branch 2 times, most recently from 6266963 to b45291c Compare May 25, 2026 09:48
@dorimedini-starkware dorimedini-starkware force-pushed the 05-21-starknet_os_os_resources_test_-_library_call branch 2 times, most recently from 7facbbd to bf48e42 Compare May 25, 2026 15:37
@dorimedini-starkware dorimedini-starkware force-pushed the 05-24-starknet_os_os_resources_test_-_create_fixed_deployable_account branch from b45291c to 91c50c1 Compare May 25, 2026 15:37
Copy link
Copy Markdown
Collaborator

@Yoni-Starkware Yoni-Starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

@Yoni-Starkware reviewed 5 files and all commit messages, and made 1 comment.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on dorimedini-starkware).

@dorimedini-starkware dorimedini-starkware force-pushed the 05-21-starknet_os_os_resources_test_-_library_call branch from bf48e42 to fea1c50 Compare May 28, 2026 16:18
@dorimedini-starkware dorimedini-starkware force-pushed the 05-24-starknet_os_os_resources_test_-_create_fixed_deployable_account branch from 91c50c1 to 92f7798 Compare May 28, 2026 16:18
@dorimedini-starkware dorimedini-starkware changed the base branch from 05-21-starknet_os_os_resources_test_-_library_call to graphite-base/14173 May 29, 2026 14:04
@dorimedini-starkware dorimedini-starkware force-pushed the 05-24-starknet_os_os_resources_test_-_create_fixed_deployable_account branch from 92f7798 to 6593ca5 Compare May 29, 2026 14:04
@dorimedini-starkware dorimedini-starkware changed the base branch from graphite-base/14173 to main May 29, 2026 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants