Skip to content

starknet_os: os resources test - invoke tx calldata factor#14150

Open
dorimedini-starkware wants to merge 1 commit into
05-24-starknet_os_os_resources_test_-_l1_handler_tx_constant_factorfrom
05-24-starknet_os_os_resources_test_-_invoke_tx_calldata_factor
Open

starknet_os: os resources test - invoke tx calldata factor#14150
dorimedini-starkware wants to merge 1 commit into
05-24-starknet_os_os_resources_test_-_l1_handler_tx_constant_factorfrom
05-24-starknet_os_os_resources_test_-_invoke_tx_calldata_factor

Conversation

@dorimedini-starkware
Copy link
Copy Markdown
Collaborator

No description provided.

@reviewable-StarkWare
Copy link
Copy Markdown

This change is Reviewable

Copy link
Copy Markdown
Collaborator Author

dorimedini-starkware commented May 24, 2026

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

@cursor
Copy link
Copy Markdown

cursor Bot commented May 24, 2026

PR Summary

Low Risk
Regression-test and versioned-constants tuning for OS resource accounting; no runtime auth or execution-path logic changes beyond updated cost tables.

Overview
Extends the OS execute_txs_inner regression test for invoke transactions so it no longer only pins the constant overhead: it runs two minimal invokes (one extra calldata felt), subtracts blockifier business logic, and writes both the constant cost and the scaled calldata factor resources into versioned constants (scaling factor 2 unchanged).

The checked-in blockifier_versioned_constants_0_14_4.json update reflects that measurement—invoke calldata_factor n_steps moves from 11 to 15 (still 1 poseidon_builtin per factor unit).

Reviewed by Cursor Bugbot for commit 482f32d. Bugbot is set up for automated code reviews on this repo. Configure here.

Copy link
Copy Markdown

@cursor cursor Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 2 potential issues.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 04d3d51. Configure here.

Comment thread crates/starknet_os_flow_tests/src/os_resources_test.rs
Comment thread crates/starknet_os_flow_tests/src/os_resources_test.rs
@dorimedini-starkware dorimedini-starkware force-pushed the 05-24-starknet_os_os_resources_test_-_invoke_tx_calldata_factor branch from 04d3d51 to 5af6585 Compare May 24, 2026 10:15
@dorimedini-starkware dorimedini-starkware force-pushed the 05-24-starknet_os_os_resources_test_-_l1_handler_tx_constant_factor branch 2 times, most recently from 3e2e6c5 to cb37a07 Compare May 24, 2026 20:08
@dorimedini-starkware dorimedini-starkware force-pushed the 05-24-starknet_os_os_resources_test_-_invoke_tx_calldata_factor branch 2 times, most recently from 4a6103f to 5e52dfb Compare May 28, 2026 16:18
@dorimedini-starkware dorimedini-starkware force-pushed the 05-24-starknet_os_os_resources_test_-_l1_handler_tx_constant_factor branch from 22ef08b to 92ed53b Compare May 29, 2026 14:04
@dorimedini-starkware dorimedini-starkware force-pushed the 05-24-starknet_os_os_resources_test_-_invoke_tx_calldata_factor branch from 5e52dfb to 482f32d Compare May 29, 2026 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants