Skip to content

starknet_os: os resources test - deploy account tx constant factor#14148

Open
dorimedini-starkware wants to merge 1 commit into
05-24-starknet_os_os_resources_test_-_declare_txfrom
05-24-starknet_os_os_resources_test_-_deploy_account_tx_constant_factor
Open

starknet_os: os resources test - deploy account tx constant factor#14148
dorimedini-starkware wants to merge 1 commit into
05-24-starknet_os_os_resources_test_-_declare_txfrom
05-24-starknet_os_os_resources_test_-_deploy_account_tx_constant_factor

Conversation

@dorimedini-starkware
Copy link
Copy Markdown
Collaborator

No description provided.

@reviewable-StarkWare
Copy link
Copy Markdown

This change is Reviewable

Copy link
Copy Markdown
Collaborator Author

dorimedini-starkware commented May 24, 2026

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

@cursor
Copy link
Copy Markdown

cursor Bot commented May 24, 2026

PR Summary

Low Risk
Test and versioned-constants calibration only; no runtime execution-path changes beyond updated fee/resource constants for DeployAccount OS scaffolding.

Overview
Extends the OS execute_txs_inner regression test to cover deploy account transactions alongside invoke and declare, using the same methodology (full OS trace minus blockifier execute/validate resources).

The flow test now builds a minimal deploy-account tx (stable class hash, non-trivial salt, funded address in a prior block), runs it in the measurement block, and writes the measured constant OS overhead into execute_txs_inner for DeployAccount while keeping the existing calldata scaling factor of 2. blockifier_versioned_constants_0_14_4.json is updated accordingly (higher n_steps and adjusted range-check / Pedersen builtin counts).

A stub __validate_deploy__ entry point is added to the Cairo1 OS resources test account contract so deploy-account validation succeeds during the measurement run.

Reviewed by Cursor Bugbot for commit 8ac7b12. Bugbot is set up for automated code reviews on this repo. Configure here.

@dorimedini-starkware dorimedini-starkware force-pushed the 05-24-starknet_os_os_resources_test_-_declare_tx branch from fbfd93e to f4340dd Compare May 24, 2026 10:15
@dorimedini-starkware dorimedini-starkware force-pushed the 05-24-starknet_os_os_resources_test_-_deploy_account_tx_constant_factor branch 2 times, most recently from 4a8df3d to dc5adbd Compare May 24, 2026 20:08
@dorimedini-starkware dorimedini-starkware force-pushed the 05-24-starknet_os_os_resources_test_-_declare_tx branch from 25d975a to 96d404c Compare May 28, 2026 16:18
@dorimedini-starkware dorimedini-starkware force-pushed the 05-24-starknet_os_os_resources_test_-_deploy_account_tx_constant_factor branch from dc5adbd to 67b8cfa Compare May 28, 2026 16:18
@dorimedini-starkware dorimedini-starkware force-pushed the 05-24-starknet_os_os_resources_test_-_deploy_account_tx_constant_factor branch from 67b8cfa to 8ac7b12 Compare May 29, 2026 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants