Skip to content

starknet_os: os resources test - add sha512#14256

Open
dorimedini-starkware wants to merge 1 commit into
05-24-starknet_os_generalize_sha_resource_test_to_include_sha512from
05-27-starknet_os_os_resources_test_-_add_sha512
Open

starknet_os: os resources test - add sha512#14256
dorimedini-starkware wants to merge 1 commit into
05-24-starknet_os_generalize_sha_resource_test_to_include_sha512from
05-27-starknet_os_os_resources_test_-_add_sha512

Conversation

@dorimedini-starkware
Copy link
Copy Markdown
Collaborator

No description provided.

@reviewable-StarkWare
Copy link
Copy Markdown

This change is Reviewable

Copy link
Copy Markdown
Collaborator Author

dorimedini-starkware commented May 28, 2026

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

@cursor
Copy link
Copy Markdown

cursor Bot commented May 28, 2026

PR Summary

Low Risk
Test-only changes to syscall resource measurement fixtures; no production OS or fee logic behavior changes in this diff.

Overview
Extends the OS syscall resource regression harness to cover Sha512ProcessBlock, matching the existing SHA-256 virtual-builtin path.

The Cairo OsResourcesTestContract now invokes sha512_process_block_syscall during __execute__. In os_resources_test, Sha512ProcessBlock is moved from unmeasurable syscalls into SYSCALLS_WITH_VIRTUAL_BUILTINS, and virtual-builtin overhead is applied via a shared sha_overhead_from_measurement helper using SHA512_BATCH_RESOURCES_LINEAR and SHA512_BLOCK_TO_ROUND (same pattern as SHA-256).

Reviewed by Cursor Bugbot for commit 84b8e52. Bugbot is set up for automated code reviews on this repo. Configure here.

@dorimedini-starkware dorimedini-starkware force-pushed the 05-27-starknet_os_os_resources_test_-_add_sha512 branch from 603a864 to 84b8e52 Compare May 29, 2026 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants