Skip to content

starknet_os: os resources test - add 3 more syscalls#14138

Open
dorimedini-starkware wants to merge 1 commit into
05-23-starknet_os_os_resources_test_-_remove_all_fee_transfer_syscallsfrom
05-23-starknet_os_os_resources_test_-_add_3_more_syscalls
Open

starknet_os: os resources test - add 3 more syscalls#14138
dorimedini-starkware wants to merge 1 commit into
05-23-starknet_os_os_resources_test_-_remove_all_fee_transfer_syscallsfrom
05-23-starknet_os_os_resources_test_-_add_3_more_syscalls

Conversation

@dorimedini-starkware
Copy link
Copy Markdown
Collaborator

No description provided.

Copy link
Copy Markdown
Collaborator Author

dorimedini-starkware commented May 24, 2026

@reviewable-StarkWare
Copy link
Copy Markdown

This change is Reviewable

@dorimedini-starkware dorimedini-starkware self-assigned this May 24, 2026
@dorimedini-starkware dorimedini-starkware marked this pull request as ready for review May 24, 2026 07:03
@cursor
Copy link
Copy Markdown

cursor Bot commented May 24, 2026

PR Summary

Medium Risk
Updates syscall gas and OS resource tables used for fee accounting and client-side proving allowlists; incorrect values would misprice transactions or reject valid proofs.

Overview
Extends the OS resources measurement harness so __execute__ on OsResourcesTestContract also exercises get_block_hash, get_class_hash_at, and get_execution_info_v2, and drops those selectors from the “unmeasurable” list in test_os_resources_regression.

Measured OS step/builtin costs for GetBlockHash, GetClassHashAt, and GetExecutionInfo are updated in blockifier_versioned_constants_0_14_4.json, with matching syscall gas constants in Cairo constants.cairo. OS / virtual OS program hashes (program_hash.json, allowed virtual OS list, and the 0.14.3→0.14.4 diff snapshot) are refreshed to match the rebuilt OS artifact.

Reviewed by Cursor Bugbot for commit edfe6a8. Bugbot is set up for automated code reviews on this repo. Configure here.

@dorimedini-starkware dorimedini-starkware force-pushed the 05-23-starknet_os_os_resources_test_-_remove_all_fee_transfer_syscalls branch from cd7ac82 to 72d6d62 Compare May 24, 2026 20:08
@dorimedini-starkware dorimedini-starkware force-pushed the 05-23-starknet_os_os_resources_test_-_add_3_more_syscalls branch from e55a063 to 01423bf Compare May 24, 2026 20:08
@dorimedini-starkware dorimedini-starkware force-pushed the 05-23-starknet_os_os_resources_test_-_remove_all_fee_transfer_syscalls branch from 72d6d62 to ba9b395 Compare May 25, 2026 09:48
@dorimedini-starkware dorimedini-starkware force-pushed the 05-23-starknet_os_os_resources_test_-_add_3_more_syscalls branch from 01423bf to 5d943b5 Compare May 25, 2026 09:48
Comment thread crates/blockifier/resources/versioned_constants_diff_regression/0.14.2_0.14.3.txt Outdated
Copy link
Copy Markdown
Collaborator

@Yoni-Starkware Yoni-Starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Yoni-Starkware reviewed 4 files and all commit messages, and made 1 comment.
Reviewable status: 4 of 6 files reviewed, 2 unresolved discussions (waiting on dorimedini-starkware).


crates/blockifier_test_utils/resources/feature_contracts/cairo1/os_resources_test_contract.cairo line 104 at r1 (raw file):

        // get execution info syscall.
        get_execution_info_v2_syscall().unwrap_syscall();

Same OS impl though

Suggestion:

get_execution_info_v3_syscall()

@dorimedini-starkware dorimedini-starkware force-pushed the 05-23-starknet_os_os_resources_test_-_remove_all_fee_transfer_syscalls branch from ba9b395 to 1f21bca Compare May 28, 2026 16:18
@dorimedini-starkware dorimedini-starkware force-pushed the 05-23-starknet_os_os_resources_test_-_add_3_more_syscalls branch from 5d943b5 to 1510ab1 Compare May 28, 2026 16:18
Copy link
Copy Markdown

@cursor cursor Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 1510ab1. Configure here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants