Skip to content

starknet_os: os resources test - library call#14129

Open
dorimedini-starkware wants to merge 1 commit into
05-21-starknet_os_initial_test_measure_call_contract_resourcesfrom
05-21-starknet_os_os_resources_test_-_library_call
Open

starknet_os: os resources test - library call#14129
dorimedini-starkware wants to merge 1 commit into
05-21-starknet_os_initial_test_measure_call_contract_resourcesfrom
05-21-starknet_os_os_resources_test_-_library_call

Conversation

@dorimedini-starkware
Copy link
Copy Markdown
Collaborator

No description provided.

@reviewable-StarkWare
Copy link
Copy Markdown

This change is Reviewable

Copy link
Copy Markdown
Collaborator Author

dorimedini-starkware commented May 21, 2026

@dorimedini-starkware dorimedini-starkware force-pushed the 05-21-starknet_os_os_resources_test_-_library_call branch from 8b1afb6 to a3596f2 Compare May 24, 2026 06:50
@dorimedini-starkware dorimedini-starkware force-pushed the 05-21-starknet_os_initial_test_measure_call_contract_resources branch from a5cf1a7 to c7c8260 Compare May 24, 2026 06:50
@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 24, 2026

Artifacts upload workflows:

@cursor
Copy link
Copy Markdown

cursor Bot commented May 24, 2026

PR Summary

Medium Risk
Changes consensus-relevant syscall gas and OS program hashes for 0.14.4; incorrect values could break fee accounting or client proving compatibility.

Overview
Adds LibraryCall to the OS resources regression harness so its overhead is measured end-to-end instead of being skipped.

The measurement contract now invokes library_call_syscall during __execute__, and LibraryCall is removed from the unmeasurable syscall list. Calibrated costs land in 0.14.4 versioned constants (874 OS steps, down from 879) and in Cairo OS constants (LIBRARY_CALL_GAS_COST 88660, down from 89160). Rebuilt Starknet OS artifacts update program_hash.json and the third allowed virtual OS program hash to match the new virtual_os build.

Reviewed by Cursor Bugbot for commit 346f65f. Bugbot is set up for automated code reviews on this repo. Configure here.

@dorimedini-starkware dorimedini-starkware force-pushed the 05-21-starknet_os_os_resources_test_-_library_call branch from a3596f2 to ec08192 Compare May 24, 2026 10:15
@dorimedini-starkware dorimedini-starkware force-pushed the 05-21-starknet_os_initial_test_measure_call_contract_resources branch from c7c8260 to bd46d55 Compare May 24, 2026 10:15
@dorimedini-starkware dorimedini-starkware changed the base branch from 05-21-starknet_os_initial_test_measure_call_contract_resources to graphite-base/14129 May 24, 2026 11:40
@dorimedini-starkware dorimedini-starkware force-pushed the 05-21-starknet_os_os_resources_test_-_library_call branch from ec08192 to b88d6c1 Compare May 24, 2026 13:12
@dorimedini-starkware dorimedini-starkware changed the base branch from graphite-base/14129 to 05-21-starknet_os_initial_test_measure_call_contract_resources May 24, 2026 13:12
@dorimedini-starkware dorimedini-starkware force-pushed the 05-21-starknet_os_initial_test_measure_call_contract_resources branch from ae772fc to 6a1a1c1 Compare May 24, 2026 17:03
@dorimedini-starkware dorimedini-starkware force-pushed the 05-21-starknet_os_os_resources_test_-_library_call branch from b88d6c1 to 24bc2a4 Compare May 24, 2026 17:03
@dorimedini-starkware dorimedini-starkware force-pushed the 05-21-starknet_os_os_resources_test_-_library_call branch from 24bc2a4 to 7facbbd Compare May 25, 2026 09:48
@dorimedini-starkware dorimedini-starkware force-pushed the 05-21-starknet_os_initial_test_measure_call_contract_resources branch from 6a1a1c1 to 2dc8f91 Compare May 25, 2026 09:48
Copy link
Copy Markdown

@cursor cursor Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 7facbbd. Configure here.

Comment thread crates/blockifier/resources/versioned_constants_diff_regression/0.14.2_0.14.3.txt Outdated
@dorimedini-starkware dorimedini-starkware force-pushed the 05-21-starknet_os_os_resources_test_-_library_call branch from 7facbbd to bf48e42 Compare May 25, 2026 15:37
@dorimedini-starkware dorimedini-starkware changed the base branch from 05-21-starknet_os_initial_test_measure_call_contract_resources to graphite-base/14129 May 25, 2026 15:51
Copy link
Copy Markdown
Collaborator

@Yoni-Starkware Yoni-Starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Yoni-Starkware reviewed 5 files and all commit messages, and made 1 comment.
Reviewable status: 5 of 6 files reviewed, 1 unresolved discussion (waiting on dorimedini-starkware).

Comment thread crates/blockifier/resources/versioned_constants_diff_regression/0.14.2_0.14.3.txt Outdated
Copy link
Copy Markdown
Collaborator

@Yoni-Starkware Yoni-Starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

@Yoni-Starkware made 1 comment.
Reviewable status: 5 of 6 files reviewed, 1 unresolved discussion (waiting on dorimedini-starkware).

@dorimedini-starkware dorimedini-starkware force-pushed the 05-21-starknet_os_os_resources_test_-_library_call branch from fea1c50 to 346f65f Compare May 29, 2026 14:04
@dorimedini-starkware dorimedini-starkware changed the base branch from graphite-base/14129 to 05-21-starknet_os_initial_test_measure_call_contract_resources May 29, 2026 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants