Skip to content

starknet_os: os resources test - support virtual builtins, add sha256#14141

Open
dorimedini-starkware wants to merge 1 commit into
05-23-starknet_os_define_sha256_batch_resources_constantsfrom
05-23-starknet_os_os_resources_test_-_support_virtual_builtins_add_sha256
Open

starknet_os: os resources test - support virtual builtins, add sha256#14141
dorimedini-starkware wants to merge 1 commit into
05-23-starknet_os_define_sha256_batch_resources_constantsfrom
05-23-starknet_os_os_resources_test_-_support_virtual_builtins_add_sha256

Conversation

@dorimedini-starkware
Copy link
Copy Markdown
Collaborator

No description provided.

Copy link
Copy Markdown
Collaborator Author

dorimedini-starkware commented May 24, 2026

@reviewable-StarkWare
Copy link
Copy Markdown

This change is Reviewable

@dorimedini-starkware dorimedini-starkware self-assigned this May 24, 2026
@dorimedini-starkware dorimedini-starkware marked this pull request as ready for review May 24, 2026 07:03
@cursor
Copy link
Copy Markdown

cursor Bot commented May 24, 2026

PR Summary

Medium Risk
Touches fee/versioned constants (program hashes, SHA256 gas and OS resource tables) used for proving and charging, though changes are driven by measurement and hash regeneration rather than new runtime logic.

Overview
Extends OS syscall resource regression to SHA256 by treating it as a virtual builtin: OsLogger only sees syscall setup, so measured costs are adjusted with SHA256_BATCH_RESOURCES_LINEAR / SHA256_BLOCK_TO_ROUND (7 blocks per round) and public BUILTIN_INSTANCE_SIZES. The Cairo1 os resources test contract now invokes sha256_process_block_syscall; Sha256ProcessBlock is removed from unmeasurable syscalls.

Versioned constants 0.14.4 and Cairo OS constants pick up refreshed OS / virtual OS program hashes, lower SHA256_PROCESS_BLOCK gas, and updated Sha256ProcessBlock step/builtin counts (e.g. 1853 steps, 1114 bitwise). test_finalize_sha256 uses the shared SHA256_BLOCK_TO_ROUND constant instead of a local 7.

Reviewed by Cursor Bugbot for commit 2144fa8. Bugbot is set up for automated code reviews on this repo. Configure here.

Copy link
Copy Markdown

@cursor cursor Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 035e95f. Configure here.

Comment thread crates/starknet_os_flow_tests/src/os_resources_test.rs
@dorimedini-starkware dorimedini-starkware force-pushed the 05-23-starknet_os_os_resources_test_-_support_virtual_builtins_add_sha256 branch from 90ce97f to b11e870 Compare May 24, 2026 20:08
@dorimedini-starkware dorimedini-starkware force-pushed the 05-23-starknet_os_define_sha256_batch_resources_constants branch 2 times, most recently from 908973c to fd6b95e Compare May 28, 2026 16:18
@dorimedini-starkware dorimedini-starkware force-pushed the 05-23-starknet_os_os_resources_test_-_support_virtual_builtins_add_sha256 branch from b11e870 to 61ef5ef Compare May 28, 2026 16:18
@dorimedini-starkware dorimedini-starkware force-pushed the 05-23-starknet_os_define_sha256_batch_resources_constants branch from fd6b95e to 062b998 Compare May 29, 2026 14:04
@dorimedini-starkware dorimedini-starkware force-pushed the 05-23-starknet_os_os_resources_test_-_support_virtual_builtins_add_sha256 branch from 61ef5ef to 2144fa8 Compare May 29, 2026 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants