starknet_committer,apollo_committer: add timers for fetch patricia paths

[ArielElp]

No description provided.

[reviewable-StarkWare]

This change is 

[ArielElp]

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

• apollo_committer,starknet_committer: use blockifier's AccessedKeys #14252
• apollo_committer: add new request handler #14003
• apollo_committer: add request_paths_and_commit_block tests #14208
• starknet_committer: delete patricia paths on reverts #14002
• starknet_committer,apollo_committer: add timers for fetch patricia paths #14189 👈 (View in Graphite)
• starknet_committer: underlying logic of the new read witnesses and commit endpoint #14001
• starknet_committer: extract metadata construction to a function #14000
• starknet_committer: extract commit plan to commit_or_load #13999
• starknet_committer: read and write patricia paths to index db #13998
• apollo_committer_types: add patricia proofs request and response types #13996 : 1 other dependent PR (#13997 )
• starknet_committer: add patricia paths forest reader/writer traits #13995
• starknet_committer: define StarknetForestProofs serde #13994
• starknet_committer: compute and store accessed keys digest #13993
• starknet_committer: add utility that returns sorted leaf indices #13992
• starknet_committer: abstract fetch_all_patricia_paths #13991
• starknet_patricia_storage: two layer storage #13990
• starknet_committer: move fetch_patricia_paths tests #13960
• starknet_committer: fetch patricia paths tests #13959
• starknet_committer: support both layouts in fetch_patricia_paths #13958
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

[cursor]

PR Summary

Low Risk
Observability-only changes around existing witness fetch calls; commit semantics and storage writes are unchanged.

Overview
Adds os_input-gated timing for the two Patricia witness collection passes in read_paths_and_commit_block: pre-commit roots, then post-commit roots with serialized forest overlay. End-to-end block timing now starts before the first witness fetch instead of after it.

Extends block measurement types with FetchWitnessesFirstPass / FetchWitnessesSecondPass actions, durations, and a first-pass witness count on BlockModificationsCounts. StarknetForestProofs::len() centralizes witness sizing for logs and timers; commit logging uses that count instead of manually summing trie proof parts. commit.rs uses ..Default::default() when setting modification counts so witness fields stay default outside the OS path. Benchmark CLI tests and an os_input feature re-export are updated accordingly; metrics export for witness timings is left as a TODO on update_metrics.

^{Reviewed by Cursor Bugbot for commit c760241. Bugbot is set up for automated code reviews on this repo. Configure here.}

[yoavGrs]

@yoavGrs made 1 comment and resolved 1 discussion.
Reviewable status: 3 of 7 files reviewed, 2 unresolved discussions (waiting on ArielElp).

---

crates/starknet_committer/src/block_committer/measurements_util.rs line 82 at r4 (raw file):

Previously, ArielElp wrote…

to avoid cfg(feature=os_input) on callsite

you mean, in committer_cli?
IMO we should keep it the way it was.

[ArielElp]

@ArielElp made 1 comment.
Reviewable status: 2 of 7 files reviewed, 1 unresolved discussion (waiting on yoavGrs).

---

crates/starknet_committer/src/block_committer/measurements_util.rs line 82 at r4 (raw file):

Previously, yoavGrs wrote…

you mean, in committer_cli?
IMO we should keep it the way it was.

Done.

[cursor]

Cursor Bugbot has reviewed your changes and found 1 potential issue.

^{❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.}

^{Reviewed by Cursor Bugbot for commit 64c906d. Configure here.}

[yoavGrs]

@yoavGrs reviewed 5 files and all commit messages, made 2 comments, and resolved 1 discussion.
Reviewable status: 6 of 7 files reviewed, 3 unresolved discussions (waiting on ArielElp).

---

crates/starknet_committer/src/block_committer/commit.rs line 242 at r7 (raw file):

        classes_trie: n_classes_trie_modifications,
        emptied_storage_leaves,
        ..Default::default()

We don't have the number of witnesses?

---

crates/starknet_committer_cli/src/utils_test.rs line 20 at r7 (raw file):

const N_EMPTY_LEAVES: usize = 10;
#[cfg(feature = "os_input")]
const N_WITNESSES: usize = 0;

Give an interesting value.

Code quote:

const N_WITNESSES: usize = 0;