Skip to content

starknet_committer: read and write patricia paths to index db#13998

Merged
ArielElp merged 1 commit into
mainfrom
ariel/index_db_read_and_write_proofs
May 28, 2026
Merged

starknet_committer: read and write patricia paths to index db#13998
ArielElp merged 1 commit into
mainfrom
ariel/index_db_read_and_write_proofs

Conversation

@ArielElp
Copy link
Copy Markdown
Contributor

@ArielElp ArielElp commented May 7, 2026

No description provided.

Copy link
Copy Markdown
Contributor Author

ArielElp commented May 7, 2026

@reviewable-StarkWare
Copy link
Copy Markdown

This change is Reviewable

@ArielElp ArielElp force-pushed the ariel/patricia_proofs_db_keys branch from dfd62d8 to c672275 Compare May 7, 2026 12:40
@ArielElp ArielElp force-pushed the ariel/index_db_read_and_write_proofs branch 2 times, most recently from c3b74da to 7eb2f0e Compare May 14, 2026 08:43
@ArielElp ArielElp force-pushed the ariel/patricia_proofs_db_keys branch from c672275 to 765284d Compare May 14, 2026 08:43
@ArielElp ArielElp force-pushed the ariel/index_db_read_and_write_proofs branch from 7eb2f0e to 82e9411 Compare May 18, 2026 11:56
@ArielElp ArielElp force-pushed the ariel/patricia_proofs_db_keys branch from 765284d to 2562066 Compare May 18, 2026 11:56
@ArielElp ArielElp force-pushed the ariel/index_db_read_and_write_proofs branch from 82e9411 to ff1915d Compare May 18, 2026 13:52
@ArielElp ArielElp force-pushed the ariel/patricia_proofs_db_keys branch 2 times, most recently from d34fe2c to 509ef2f Compare May 19, 2026 06:55
@ArielElp ArielElp force-pushed the ariel/index_db_read_and_write_proofs branch from ff1915d to 1a13989 Compare May 19, 2026 06:55
@ArielElp ArielElp force-pushed the ariel/patricia_proofs_db_keys branch from 509ef2f to 4f7483a Compare May 19, 2026 07:08
@ArielElp ArielElp force-pushed the ariel/index_db_read_and_write_proofs branch from 1a13989 to 1fd4ef8 Compare May 19, 2026 07:08
@ArielElp ArielElp force-pushed the ariel/index_db_read_and_write_proofs branch 2 times, most recently from 6bcc7c0 to 57671ad Compare May 26, 2026 11:42
@ArielElp ArielElp force-pushed the ariel/patricia_proofs_db_keys branch from 6506c10 to 5a5e21c Compare May 26, 2026 11:42
@ArielElp ArielElp force-pushed the ariel/index_db_read_and_write_proofs branch 3 times, most recently from a2756a6 to d645ed9 Compare May 27, 2026 07:23
@ArielElp ArielElp force-pushed the ariel/patricia_proofs_db_keys branch from 267f776 to df115c1 Compare May 27, 2026 07:23
@ArielElp ArielElp force-pushed the ariel/index_db_read_and_write_proofs branch from d645ed9 to 9dad213 Compare May 27, 2026 09:45
@ArielElp ArielElp force-pushed the ariel/patricia_proofs_db_keys branch from df115c1 to 777d9c0 Compare May 27, 2026 09:45
Copy link
Copy Markdown

@cursor cursor Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 9dad213. Configure here.

Comment thread crates/starknet_committer/src/db/forest_trait.rs Outdated
@ArielElp ArielElp force-pushed the ariel/index_db_read_and_write_proofs branch from 9dad213 to 83bf995 Compare May 27, 2026 11:52
@ArielElp ArielElp force-pushed the ariel/patricia_proofs_db_keys branch from 777d9c0 to 27c8153 Compare May 27, 2026 11:52
@ArielElp ArielElp force-pushed the ariel/index_db_read_and_write_proofs branch from 83bf995 to d5690c8 Compare May 27, 2026 12:00
@ArielElp ArielElp force-pushed the ariel/patricia_proofs_db_keys branch from 27c8153 to afa6924 Compare May 27, 2026 12:00
@ArielElp ArielElp force-pushed the ariel/index_db_read_and_write_proofs branch from d5690c8 to c15a08f Compare May 27, 2026 12:20
@ArielElp ArielElp force-pushed the ariel/patricia_proofs_db_keys branch 2 times, most recently from 6303205 to 3ef582d Compare May 27, 2026 12:24
@ArielElp ArielElp force-pushed the ariel/index_db_read_and_write_proofs branch from c15a08f to 321f8e6 Compare May 27, 2026 12:25
@ArielElp ArielElp force-pushed the ariel/patricia_proofs_db_keys branch from 3ef582d to 99c87bd Compare May 27, 2026 14:31
@ArielElp ArielElp force-pushed the ariel/index_db_read_and_write_proofs branch from 321f8e6 to 8d443ea Compare May 27, 2026 14:31
Copy link
Copy Markdown
Collaborator

@dorimedini-starkware dorimedini-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dorimedini-starkware reviewed 1 file and all commit messages, and made 2 comments.
Reviewable status: 1 of 2 files reviewed, 2 unresolved discussions (waiting on ArielElp and yoavGrs).


crates/starknet_committer/src/db/index_db/db.rs at r4 (raw file):
a lot of gated code here: separate module?

Comment thread crates/starknet_committer/src/db/forest_trait.rs Outdated
Copy link
Copy Markdown
Collaborator

@dorimedini-starkware dorimedini-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dorimedini-starkware reviewed all commit messages.
Reviewable status: 1 of 2 files reviewed, 2 unresolved discussions (waiting on yoavGrs).

Copy link
Copy Markdown
Contributor Author

@ArielElp ArielElp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ArielElp made 2 comments.
Reviewable status: 0 of 2 files reviewed, 2 unresolved discussions (waiting on dorimedini-starkware and yoavGrs).


crates/starknet_committer/src/db/index_db/db.rs at r4 (raw file):

Previously, dorimedini-starkware wrote…

a lot of gated code here: separate module?

A bit annoying here since a separate module would need access to the internal storage, which means adding gated pub(crate) getters which I'd rather avoid.

Comment thread crates/starknet_committer/src/db/forest_trait.rs Outdated
Copy link
Copy Markdown
Collaborator

@dorimedini-starkware dorimedini-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dorimedini-starkware reviewed 2 files and all commit messages, and resolved 2 discussions.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on ArielElp).

@github-actions
Copy link
Copy Markdown

Artifacts upload workflows:

Copy link
Copy Markdown
Collaborator

@dorimedini-starkware dorimedini-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dorimedini-starkware reviewed 9 files and all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on ArielElp).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants