starknet_committer: read and write patricia paths to index db#13998
Conversation
dfd62d8 to
c672275
Compare
c3b74da to
7eb2f0e
Compare
c672275 to
765284d
Compare
7eb2f0e to
82e9411
Compare
765284d to
2562066
Compare
82e9411 to
ff1915d
Compare
d34fe2c to
509ef2f
Compare
ff1915d to
1a13989
Compare
509ef2f to
4f7483a
Compare
1a13989 to
1fd4ef8
Compare
6bcc7c0 to
57671ad
Compare
6506c10 to
5a5e21c
Compare
a2756a6 to
d645ed9
Compare
267f776 to
df115c1
Compare
d645ed9 to
9dad213
Compare
df115c1 to
777d9c0
Compare
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 9dad213. Configure here.
9dad213 to
83bf995
Compare
777d9c0 to
27c8153
Compare
83bf995 to
d5690c8
Compare
27c8153 to
afa6924
Compare
d5690c8 to
c15a08f
Compare
6303205 to
3ef582d
Compare
c15a08f to
321f8e6
Compare
3ef582d to
99c87bd
Compare
321f8e6 to
8d443ea
Compare
dorimedini-starkware
left a comment
There was a problem hiding this comment.
@dorimedini-starkware reviewed 1 file and all commit messages, and made 2 comments.
Reviewable status: 1 of 2 files reviewed, 2 unresolved discussions (waiting on ArielElp and yoavGrs).
crates/starknet_committer/src/db/index_db/db.rs at r4 (raw file):
a lot of gated code here: separate module?
dorimedini-starkware
left a comment
There was a problem hiding this comment.
@dorimedini-starkware reviewed all commit messages.
Reviewable status: 1 of 2 files reviewed, 2 unresolved discussions (waiting on yoavGrs).
ArielElp
left a comment
There was a problem hiding this comment.
@ArielElp made 2 comments.
Reviewable status: 0 of 2 files reviewed, 2 unresolved discussions (waiting on dorimedini-starkware and yoavGrs).
crates/starknet_committer/src/db/index_db/db.rs at r4 (raw file):
Previously, dorimedini-starkware wrote…
a lot of gated code here: separate module?
A bit annoying here since a separate module would need access to the internal storage, which means adding gated pub(crate) getters which I'd rather avoid.
dorimedini-starkware
left a comment
There was a problem hiding this comment.
@dorimedini-starkware reviewed 2 files and all commit messages, and resolved 2 discussions.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on ArielElp).
|
Artifacts upload workflows: |
dorimedini-starkware
left a comment
There was a problem hiding this comment.
@dorimedini-starkware reviewed 9 files and all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on ArielElp).


No description provided.