starknet_committer: define StarknetForestProofs serde

[ArielElp]

No description provided.

[reviewable-StarkWare]

This change is 

[ArielElp]

• apollo_committer_types: add patricia proofs request and response types #13996 : 2 dependent PRs (#13997 , #13998 )
• starknet_committer: add patricia paths forest reader/writer traits #13995
• starknet_committer: define StarknetForestProofs serde #13994 👈 (View in Graphite)
• starknet_committer: compute and store accessed keys digest #13993
• starknet_committer: add utility that returns sorted leaf indices #13992
• starknet_committer: abstract fetch_all_patricia_paths #13991
• starknet_patricia_storage: two layer storage #13990
• starknet_committer: move fetch_patricia_paths tests #13960
• starknet_committer: fetch patricia paths tests #13959
• starknet_committer: support both layouts in fetch_patricia_paths #13958
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

[cursor]

PR Summary

Medium Risk
New wire format for state-commitment witnesses must stay compatible with OS expectations; mistakes could break proving input, though scope is feature-gated and covered by round-trip tests.

Overview
Adds zstd-compressed bincode serialization for StarknetForestProofs behind the os_input feature, producing DbValue payloads aligned with OS Patricia witness layout (classes/contract inner nodes, contract leaves, per-contract storage proofs).

serialize flattens preimage maps via flatten_preimages and packs a four-part tuple; deserialize rebuilds maps and rejects duplicate node hashes, contract leaves, or storage witnesses. Optional bincode and zstd deps are wired into os_input; Debug/PartialEq are added on proof structs and extend is made public for tests and callers.

Round-trip rstest cases cover empty/partial/full forest proof shapes when os_input is enabled in tests.

^{Reviewed by Cursor Bugbot for commit 1f3d5ed. Bugbot is set up for automated code reviews on this repo. Configure here.}

[dorimedini-starkware]

@dorimedini-starkware reviewed 5 files and all commit messages, made 2 comments, and resolved 4 discussions.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on ArielElp).

---

crates/starknet_committer/src/patricia_merkle_tree/starknet_forest_proofs_serde.rs line 67 at r6 (raw file):

            .collect();

        bincode::serialize(&(classes, contract_nodes, contract_leaves, storage))

general question: why did you choose this crate to convert to/from bytes?

Code quote:

bincode

---

crates/starknet_committer/src/patricia_merkle_tree/starknet_forest_proofs_serde.rs line 105 at r6 (raw file):

        let mut contracts_trie_storage_proofs = HashMap::new();
        for (addr, facts) in storage {

why not do the same into_iter().try_fold pattern as above?

Code quote:

        let mut contracts_trie_storage_proofs = HashMap::new();
        for (addr, facts) in storage {

[yoavGrs]

@yoavGrs made 1 comment.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on ArielElp and dorimedini-starkware).

---

crates/starknet_committer/src/patricia_merkle_tree/starknet_forest_proofs_serde.rs line 67 at r6 (raw file):

Previously, dorimedini-starkware wrote…

general question: why did you choose this crate to convert to/from bytes?

What about this approach:

sequencer/crates/apollo_storage/src/accessed_keys.rs

Lines 14 to 15 in 9bf46f6

	let bytes = serde_json::to_vec(self)?;
	let compressed = compress(bytes.as_slice())?;

[ArielElp]

@ArielElp made 2 comments.
Reviewable status: 5 of 6 files reviewed, 2 unresolved discussions (waiting on dorimedini-starkware).

---

crates/starknet_committer/src/patricia_merkle_tree/starknet_forest_proofs_serde.rs line 67 at r6 (raw file):

Previously, yoavGrs wrote…

What about this approach:

sequencer/crates/apollo_storage/src/accessed_keys.rs

Lines 14 to 15 in 9bf46f6

	let bytes = serde_json::to_vec(self)?;
	let compressed = compress(bytes.as_slice())?;

Just a simple approach to storage that was recommended by AI. Given that everything is experimental and gated, it seemed weird to deep dive into the best representation. I'm fine with Yoav's suggestion too, though JSON is probably somewhat wasteful. Up to you.

Regarding compression, this is probably a must, given that we suspect this will be a non-trivial storage increase that we may need to prune regularly, but we can also compress bincode's bytes. Did it for now.

---

crates/starknet_committer/src/patricia_merkle_tree/starknet_forest_proofs_serde.rs line 105 at r6 (raw file):

Previously, dorimedini-starkware wrote…

why not do the same into_iter().try_fold pattern as above?

No good reason, changed.

[dorimedini-starkware]

@dorimedini-starkware reviewed 3 files and all commit messages, and resolved 2 discussions.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on ArielElp).

[github-actions]

Artifacts upload workflows:

• Started at 2026-05-27T15:31:11Z
• Started at 2026-05-27T15:47:24Z
• Started at 2026-05-27T16:20:12Z

[dorimedini-starkware]

@dorimedini-starkware reviewed 3 files and all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on ArielElp).