starknet_committer: add patricia paths forest reader/writer traits

[ArielElp]

No description provided.

[reviewable-StarkWare]

This change is 

[ArielElp]

• apollo_committer_types: add patricia proofs request and response types #13996 : 2 dependent PRs (#13997 , #13998 )
• starknet_committer: add patricia paths forest reader/writer traits #13995 👈 (View in Graphite)
• starknet_committer: define StarknetForestProofs serde #13994
• starknet_committer: compute and store accessed keys digest #13993
• starknet_committer: add utility that returns sorted leaf indices #13992
• starknet_committer: abstract fetch_all_patricia_paths #13991
• starknet_patricia_storage: two layer storage #13990
• starknet_committer: move fetch_patricia_paths tests #13960
• starknet_committer: fetch patricia paths tests #13959
• starknet_committer: support both layouts in fetch_patricia_paths #13958
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

[ArielElp]

@ArielElp made 3 comments.
Reviewable status: 2 of 3 files reviewed, 4 unresolved discussions (waiting on dorimedini-starkware).

---

crates/starknet_committer/src/db/forest_trait_witnesses.rs line 31 at r3 (raw file):

just so I understand: this enum is just to allow a single function to do both revert and commit?

Yes (maybe more specifically, a single function that does all the writes)

i.e. a "revert" is a reverse commit?

In the standard commit flow this is true, so you don't need a special treatment for reverts at the API level.

I changed the names a bit and added an explicit type for the Write variant, I think it's clearer now.

---

crates/starknet_committer/src/db/forest_trait_witnesses.rs line 53 at r3 (raw file):

Previously, dorimedini-starkware wrote…

shouldn't this be mutable? non-blocking, can be done later anyway

No, we only read from this layer (a few PRs from away)

---

crates/starknet_committer/src/db/forest_trait_witnesses.rs line 57 at r3 (raw file):

Previously, dorimedini-starkware wrote…

why optionally?

Not optionally indeed, removed.

[dorimedini-starkware]

@dorimedini-starkware reviewed 1 file and all commit messages, and resolved 3 discussions.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on ArielElp).

[dorimedini-starkware]

@dorimedini-starkware reviewed 1 file and all commit messages, and made 1 comment.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on ArielElp).

[dorimedini-starkware]

@dorimedini-starkware reviewed 1 file and all commit messages, and made 1 comment.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on ArielElp).

---

crates/starknet_committer/src/db/index_db/db.rs line 89 at r6 (raw file):

/// Prefix for accessed-keys digest metadata (committed per block).
#[cfg_attr(not(feature = "os_input"), allow(dead_code))]

we try to use expect when we can, to catch redundant annotations as they come

Suggestion:

expect(dead_code)

[ArielElp]

@ArielElp made 1 comment.
Reviewable status: 2 of 3 files reviewed, 2 unresolved discussions (waiting on dorimedini-starkware).

---

crates/starknet_committer/src/db/index_db/db.rs line 89 at r6 (raw file):

Previously, dorimedini-starkware wrote…

we try to use expect when we can, to catch redundant annotations as they come

Done.

[dorimedini-starkware]

@dorimedini-starkware reviewed 1 file and all commit messages, and resolved 1 discussion.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on ArielElp).

[cursor]

Cursor Bugbot has reviewed your changes and found 1 potential issue.

^{❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.}

^{Reviewed by Cursor Bugbot for commit c0fd617. Configure here.}

[ArielElp]

@ArielElp resolved 1 discussion.
Reviewable status: 2 of 3 files reviewed, 1 unresolved discussion (waiting on dorimedini-starkware).

[dorimedini-starkware]

@dorimedini-starkware reviewed 1 file and all commit messages, and made 1 comment.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on ArielElp).

---

crates/starknet_committer/src/db/index_db/db.rs line 96 at r9 (raw file):

pub(crate) static PATRICIA_PATHS_PREFIX: LazyLock<[u8; 32]> = LazyLock::new(|| {
    (Felt::from_bytes_be(&ACCESSED_KEYS_DIGEST_METADATA_PREFIX) + Felt::ONE).to_bytes_be()
});

Suggestion:

/// Prefix for Patricia proofs payload (per block).
#[cfg_attr(not(feature = "os_input"), expect(dead_code))]
pub(crate) static PATRICIA_PATHS_PREFIX: LazyLock<[u8; 32]> = LazyLock::new(|| {
    (Felt::from_bytes_be(&ACCESSED_KEYS_DIGEST_METADATA_PREFIX) + Felt::ONE).to_bytes_be()
});

[ArielElp]

@ArielElp made 1 comment.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on dorimedini-starkware).

---

crates/starknet_committer/src/db/index_db/db.rs line 96 at r9 (raw file):

pub(crate) static PATRICIA_PATHS_PREFIX: LazyLock<[u8; 32]> = LazyLock::new(|| {
    (Felt::from_bytes_be(&ACCESSED_KEYS_DIGEST_METADATA_PREFIX) + Felt::ONE).to_bytes_be()
});

at the moment it is still not used, this is changed up the stack (2 PRs up)

[dorimedini-starkware]

@dorimedini-starkware resolved 1 discussion.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on ArielElp).

[ArielElp]

@ArielElp resolved 1 discussion.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on ArielElp).