apollo_committer_types: add patricia proofs request and response types

[ArielElp]

No description provided.

[reviewable-StarkWare]

This change is 

[ArielElp]

• apollo_committer_types: add patricia proofs request and response types #13996 : 2 dependent PRs (#13997 , #13998 ) 👈 (View in Graphite)
• starknet_committer: add patricia paths forest reader/writer traits #13995
• starknet_committer: define StarknetForestProofs serde #13994
• starknet_committer: compute and store accessed keys digest #13993
• starknet_committer: add utility that returns sorted leaf indices #13992
• starknet_committer: abstract fetch_all_patricia_paths #13991
• starknet_patricia_storage: two layer storage #13990
• starknet_committer: move fetch_patricia_paths tests #13960
• starknet_committer: fetch patricia paths tests #13959
• starknet_committer: support both layouts in fetch_patricia_paths #13958
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

[cursor]

PR Summary

Medium Risk
Touches committer error surfaces and serializes Patricia witness blobs for OS input; behavior is feature-gated but affects how block commit data is represented and validated.

Overview
Adds an os_input feature to apollo_committer_types so commit flows can request a block commit together with Patricia trie witnesses for OS input.

Under that feature, new ReadPathsAndCommitBlockRequest / ReadPathsAndCommitBlockResponse types wrap the existing commit payload plus AccessedKeys and return global_root with StarknetForestProofs. CommitterError gains OS-input-specific cases for Patricia path collection failures, accessed-keys digest mismatches, and missing stored proofs.

In starknet_committer, StarknetForestProofs (and related proof structs) are Clone, and serde is wired through the existing zstd-compressed bincode DbValue encoding so these witnesses can cross API boundaries. CI for the OS-input workflow now tracks apollo_committer_types / starknet_committer and runs cargo test for both with os_input.

^{Reviewed by Cursor Bugbot for commit 2be9832. Bugbot is set up for automated code reviews on this repo. Configure here.}

[dorimedini-starkware]

@dorimedini-starkware reviewed 2 files and all commit messages.
Reviewable status: all files reviewed, 6 unresolved discussions (waiting on ArielElp).

[dorimedini-starkware]

@dorimedini-starkware made 1 comment.
Reviewable status: all files reviewed, 6 unresolved discussions (waiting on ArielElp).

---

crates/starknet_committer/src/block_committer/input.rs line 84 at r6 (raw file):

Previously, yoavGrs wrote…

Yes, in the blockifier, with the same name

@ArielElp please reuse

[dorimedini-starkware]

@dorimedini-starkware reviewed 2 files and all commit messages.
Reviewable status: all files reviewed, 6 unresolved discussions (waiting on ArielElp).

[ArielElp]

@ArielElp made 5 comments.
Reviewable status: all files reviewed, 6 unresolved discussions (waiting on dorimedini-starkware).

---

crates/apollo_committer_types/src/committer_types.rs at r6 (raw file):

Previously, dorimedini-starkware wrote…

borderline - these additions can stay here, or, can move to a new gated module... your call, but if this module will end up adding more gated stuff I would just create a new module in advance

There are no more additions on the top of the stack so I'm keeping it.

---

crates/starknet_committer/src/block_committer/input.rs line 84 at r6 (raw file):

Previously, dorimedini-starkware wrote…

@ArielElp please reuse

Done

---

crates/starknet_committer/src/patricia_merkle_tree/starknet_forest_proofs_serde.rs line 137 at r6 (raw file):

Previously, dorimedini-starkware wrote…

don't use inline please

Done.

---

crates/starknet_committer/src/patricia_merkle_tree/starknet_forest_proofs_serde.rs line 139 at r6 (raw file):

Previously, dorimedini-starkware wrote…

not sure it's useful for you, but FYI: you can use #[serde(remote = "Self")] to be able to define these custom serde impls AND derive the serde traits at the same time

Gotcha, but as you said, either this or the above bincode doesn't correspond to the derived implementation.

---

crates/starknet_committer/src/patricia_merkle_tree/types.rs at r6 (raw file):

Previously, dorimedini-starkware wrote…

ouch x2
are these clones really necessary? the objects can be huge..

It doesn't seem to be used anywhere in the stack. More of an apparent convention that every component's request/response type derives from clone (the new ReadPathsAndCommitBlockRequest will be a variant of CommitterRequest that currently derives from Clone, to satisfy it, I need clone on these structs). That said, nothing seems to clone CommitterRequest, so we may change that, maybe higher up?

[github-actions]

Artifacts upload workflows:

• Started at 2026-05-28T08:07:27Z
• Started at 2026-05-28T08:58:41Z
• Started at 2026-05-28T08:58:57Z
• Started at 2026-05-28T10:29:40Z
• Started at 2026-05-28T11:40:30Z

[yoavGrs]

@yoavGrs made 1 comment.
Reviewable status: 2 of 7 files reviewed, 6 unresolved discussions (waiting on ArielElp and dorimedini-starkware).

---

crates/starknet_committer/src/patricia_merkle_tree/types.rs at r6 (raw file):

Previously, ArielElp wrote…

It doesn't seem to be used anywhere in the stack. More of an apparent convention that every component's request/response type derives from clone (the new ReadPathsAndCommitBlockRequest will be a variant of CommitterRequest that currently derives from Clone, to satisfy it, I need clone on these structs). That said, nothing seems to clone CommitterRequest, so we may change that, maybe higher up?

You need it for the infra, to pass the requests/responses across the channels.

[dorimedini-starkware]

@dorimedini-starkware reviewed 5 files and all commit messages, and resolved 5 discussions.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on ArielElp).

[ArielElp]

@ArielElp made 1 comment.
Reviewable status: 6 of 8 files reviewed, 1 unresolved discussion (waiting on dorimedini-starkware and yoavGrs).

---

crates/apollo_committer_types/Cargo.toml line 10 at r6 (raw file):

Previously, dorimedini-starkware wrote…

now that this is here, please add this crate to Yoav's workflow testing this feature

Done, I think.

[dorimedini-starkware]

@dorimedini-starkware reviewed 2 files and all commit messages, and resolved 1 discussion.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on ArielElp).

[dorimedini-starkware]

@dorimedini-starkware reviewed 1 file and all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on ArielElp).

[dorimedini-starkware]

@dorimedini-starkware reviewed 2 files and all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on ArielElp).