starknet_committer: db keys for proofs and accessed keys digest

[ArielElp]

No description provided.

[reviewable-StarkWare]

This change is 

[ArielElp]

• starknet_committer: db keys for proofs and accessed keys digest #13997 👈 (View in Graphite)
• apollo_committer_types: add patricia proofs request and response types #13996 : 1 other dependent PR (#13998 )
• starknet_committer: add patricia paths forest reader/writer traits #13995
• starknet_committer: define StarknetForestProofs serde #13994
• starknet_committer: compute and store accessed keys digest #13993
• starknet_committer: add utility that returns sorted leaf indices #13992
• starknet_committer: abstract fetch_all_patricia_paths #13991
• starknet_patricia_storage: two layer storage #13990
• starknet_committer: move fetch_patricia_paths tests #13960
• starknet_committer: fetch patricia paths tests #13959
• starknet_committer: support both layouts in fetch_patricia_paths #13958
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

[cursor]

Duplicated key-building logic already exists in helper function

Low Severity

patricia_proofs_db_key reimplements the same key-construction logic as the existing metadata_block_number_key helper (prefix + block number bytes + 24-byte padding into a 64-byte vec). It could delegate to that helper and wrap the result in DbKey, avoiding duplicated logic that could drift out of sync.

 

^{Reviewed by Cursor Bugbot for commit 3ef582d. Configure here.}

[cursor]

Cursor Bugbot has reviewed your changes and found 1 potential issue.

There are 2 total unresolved issues (including 1 from previous review).

^{❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.}

^{Reviewed by Cursor Bugbot for commit d02b777. Configure here.}

[cursor]

Feature-gated import breaks non-os_input compilation

High Severity

The DbBlockNumber import was changed from unconditional to #[cfg(feature = "os_input")], but metadata_block_number_key at line 349 uses DbBlockNumber in its signature without any feature gate. That function is called from the non-gated ForestMetadata::metadata_key match arms for StateDiffHash and StateRoot. This breaks compilation when the os_input feature is not enabled.

Additional Locations (1)

• crates/starknet_committer/src/db/index_db/db.rs#L348-L349

 

^{Reviewed by Cursor Bugbot for commit d02b777. Configure here.}

[dorimedini-starkware]

@dorimedini-starkware reviewed all commit messages and made 1 comment.
Reviewable status: 0 of 1 files reviewed, 3 unresolved discussions (waiting on ArielElp and yoavGrs).

---

a discussion (no related file):
isn't this PR a subset of [this one](https://reviewable.io/reviews/starkware-libs/sequencer/13995...?

[ArielElp]

@ArielElp made 1 comment.
Reviewable status: 0 of 1 files reviewed, 3 unresolved discussions (waiting on dorimedini-starkware and yoavGrs).

---

a discussion (no related file):

Previously, dorimedini-starkware wrote…

isn't this PR a subset of [this one](https://reviewable.io/reviews/starkware-libs/sequencer/13995...?

Yeah, I'm not really sure what happened here, I think the original intention was for this PR to contain all the prefixes as they're not really related to the forest trait changes. Given that the previous one was already checked, I'm moving the new prefix there and closing this PR.