starknet_committer: abstract fetch_all_patricia_paths

[ArielElp]

No description provided.

[ArielElp]

• apollo_committer_types: add patricia proofs request and response types #13996 : 2 dependent PRs (#13997 , #13998 )
• starknet_committer: add patricia paths forest reader/writer traits #13995
• starknet_committer: define StarknetForestProofs serde #13994
• starknet_committer: compute and store accessed keys digest #13993
• starknet_committer: add utility that returns sorted leaf indices #13992
• starknet_committer: abstract fetch_all_patricia_paths #13991 👈 (View in Graphite)
• starknet_patricia_storage: two layer storage #13990
• starknet_committer: move fetch_patricia_paths tests #13960
• starknet_committer: fetch patricia paths tests #13959
• starknet_committer: support both layouts in fetch_patricia_paths #13958
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

[reviewable-StarkWare]

This change is 

[cursor]

PR Summary

Medium Risk
Touches Merkle proof / witness path assembly for block commitment; behavior should match FactsNodeLayout but layout abstraction increases the chance of subtle type or conversion mismatches for other layouts later.

Overview
fetch_all_patricia_paths is now public and generic over DbLayout, so Patricia path fetching for classes, contracts, and per-contract storage tries uses each layout’s DB leaf types and node layout instead of hardcoding FactsNodeLayout and concrete leaf types.

Contract trie leaves are read through AsRef<ContractState> for storage roots and converted with Into<ContractState> when building proof maps. fetch_previous_and_new_patricia_paths is unchanged in behavior but calls fetch_all_patricia_paths::<FactsNodeLayout> and is documented as facts-layout storage only.

^{Reviewed by Cursor Bugbot for commit 780c725. Bugbot is set up for automated code reviews on this repo. Configure here.}

[yoavGrs]

@yoavGrs reviewed 1 file and all commit messages, and made 1 comment.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on ArielElp).

---

crates/starknet_committer/src/patricia_merkle_tree/tree.rs line 129 at r1 (raw file):

        // prove regarding the contract storage.
        let Some(storage_root_hash) =
            leaves.get(idx).map(|leaf| leaf.clone().into().storage_root_hash)

Can you avoid cloning?

Code quote:

leaf.clone().into().storage_root_hash

[ArielElp]

@ArielElp partially reviewed 1 file and made 1 comment.
Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on yoavGrs).

---

crates/starknet_committer/src/patricia_merkle_tree/tree.rs line 129 at r1 (raw file):

Previously, yoavGrs wrote…

Can you avoid cloning?

Replaced the Clone bound with AsRef to circumvent cloning

[yoavGrs]

@yoavGrs reviewed 1 file and all commit messages, made 1 comment, and resolved 1 discussion.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on ArielElp).

[dorimedini-starkware]

@dorimedini-starkware reviewed 1 file and all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on ArielElp).