starknet_committer: compute and store accessed keys digest#13993
Conversation
68fbdbc to
b0885bd
Compare
35ba931 to
19be0db
Compare
b0885bd to
b925279
Compare
19be0db to
7768006
Compare
PR SummaryMedium Risk Overview Also notes a future Reviewed by Cursor Bugbot for commit 5ab5e3f. Bugbot is set up for automated code reviews on this repo. Configure here. |
yoavGrs
left a comment
There was a problem hiding this comment.
@yoavGrs reviewed 2 files and all commit messages, and made 1 comment.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on ArielElp).
crates/starknet_committer/src/db/serde_db_utils.rs line 60 at r1 (raw file):
) -> [u8; 32] { let mut class_hashes: Vec<ClassHash> = class_hashes.iter().copied().collect(); class_hashes.sort();
In the previous PR you sort it. Define a "sorted" struct?
Code quote:
class_hashes.sort();7768006 to
88273cc
Compare
13ea978 to
d58523d
Compare
88273cc to
482d5eb
Compare
22efed7 to
093fc19
Compare
dorimedini-starkware
left a comment
There was a problem hiding this comment.
@dorimedini-starkware reviewed 2 files and all commit messages, made 1 comment, and resolved 3 discussions.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on ArielElp).
crates/starknet_committer/src/db/serde_db_utils.rs line 63 at r4 (raw file):
Previously, ArielElp wrote…
AI decision, it's supposed to be marginally faster, and you know there are no duplications here (it's the keys from a HashMap).
but with a HashMap, order is not well defined, and you could get different digests for the same input. right?
ArielElp
left a comment
There was a problem hiding this comment.
@ArielElp made 1 comment.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on dorimedini-starkware).
crates/starknet_committer/src/db/serde_db_utils.rs line 63 at r4 (raw file):
Previously, dorimedini-starkware wrote…
but with a HashMap, order is not well defined, and you could get different digests for the same input. right?
Hence the sort, sort unstable is just about ordering of equal elements
2e17706 to
300a545
Compare
11d186a to
c9ac657
Compare
300a545 to
c381bc4
Compare
c9ac657 to
5a5ff22
Compare
c381bc4 to
1b083d2
Compare
5a5ff22 to
bfb567c
Compare
1b083d2 to
9885436
Compare
dorimedini-starkware
left a comment
There was a problem hiding this comment.
@dorimedini-starkware reviewed 1 file and all commit messages, and made 1 comment.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on ArielElp).
crates/starknet_committer/src/db/serde_db_utils.rs line 63 at r4 (raw file):
Previously, ArielElp wrote…
Hence the sort, sort unstable is just about ordering of equal elements
ah, right.
why not use a BTreeMap in your struct though?
9885436 to
4a95405
Compare
bfb567c to
7b6b74f
Compare
|
Artifacts upload workflows: |
ArielElp
left a comment
There was a problem hiding this comment.
@ArielElp made 1 comment.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on dorimedini-starkware).
crates/starknet_committer/src/db/serde_db_utils.rs line 63 at r4 (raw file):
Previously, dorimedini-starkware wrote…
ah, right.
why not use a BTreeMap in your struct though?
The fields here eventually go to the various fetch_patricia_paths functions that expect HashMap, I didn't want to change multiple signatures just for the digest.
dorimedini-starkware
left a comment
There was a problem hiding this comment.
@dorimedini-starkware made 1 comment.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on ArielElp).
crates/starknet_committer/src/db/serde_db_utils.rs line 63 at r4 (raw file):
Previously, ArielElp wrote…
The fields here eventually go to the various fetch_patricia_paths functions that expect HashMap, I didn't want to change multiple signatures just for the digest.
mmmmm can you add a TODO to do it separately? I see no harm in changing all the signatures to BTreeMap, unless there is some storage-backed object that is already in storage with a HashMap or something non backwards-compatible like that
ArielElp
left a comment
There was a problem hiding this comment.
@ArielElp made 1 comment.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on dorimedini-starkware).
crates/starknet_committer/src/db/serde_db_utils.rs line 63 at r4 (raw file):
Previously, dorimedini-starkware wrote…
mmmmm can you add a TODO to do it separately? I see no harm in changing all the signatures to BTreeMap, unless there is some storage-backed object that is already in storage with a HashMap or something non backwards-compatible like that
Done.
7b6b74f to
22afd6e
Compare
dorimedini-starkware
left a comment
There was a problem hiding this comment.
@dorimedini-starkware reviewed 1 file and all commit messages, and resolved 1 discussion.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on ArielElp).
22afd6e to
5ab5e3f
Compare
dorimedini-starkware
left a comment
There was a problem hiding this comment.
@dorimedini-starkware reviewed 1 file and all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on ArielElp).

No description provided.