Open
Conversation
This was referenced Apr 10, 2026
Contributor
Author
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
This was referenced Apr 10, 2026
dannykopping
approved these changes
Apr 13, 2026
| // statusCapturingWriter wraps http.ResponseWriter to capture the status code. | ||
| // It also implements http.Flusher to support streaming responses. | ||
| // It implements http.Flusher to support streaming and http.Hijacker to | ||
| // satisfy the FullResponseWriter lint rule. |
Collaborator
There was a problem hiding this comment.
"to satisfy the FullResponseWriter lint rule"
I don't see any details about this; can you elaborate pls?
Contributor
Author
There was a problem hiding this comment.
circuitbreaker/circuitbreaker.go:106:6: ruleguard: ResponseWriter "statusCapturingWriter" must implement http.Flusher and http.Hijacker (gocritic)
I believe rule is simply that anythink that linter believes is ResponeWriter must implement Flusherand Hijacker
500e5f2 to
e699dc7
Compare
e6ef1aa to
9edf045
Compare
e699dc7 to
3ab6cdb
Compare
9edf045 to
2d8a18a
Compare
3ab6cdb to
bf78587
Compare
2d8a18a to
09d6738
Compare
09d6738 to
8e41c92
Compare
bf78587 to
0eee3af
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

All lint errors are now resolved — 0 remaining.