Conversation
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
| // Methods provide package-specific reads and rewrites while preserving the | ||
| // original body for upstream pass-through. | ||
| type MessagesRequestPayload []byte | ||
| type RequestPayload []byte |
There was a problem hiding this comment.
This is kind of at odds with #257 where errorResponse became chatCompletionResponseError.
Let's pick one approach and use it consistently.
There was a problem hiding this comment.
Thanks, good catch. There are 2 different rules:
- errname: error types need to have Error suffix
- exported stutter: exported symbols cannot start with package name
RequestPayload types are exported so it is enforced while error types from #257 are internal.
I'll update #257 to match stutter rule even thou error types are not exported.
95d767c to
523ed94
Compare
31f8bd5 to
240e79c
Compare
523ed94 to
6139b9e
Compare
240e79c to
02b6daf
Compare
6139b9e to
d91d17a
Compare
d91d17a to
9e01fa4
Compare

handled via pipe read side); properly checked errors from circuitbreaker.Execute and responseCopier.forwardResp in tests
NewRequestPayload); recorder.RecorderWrapper → recorder.WrappedRecorder (+ constructor NewWrappedRecorder)