Skip to content

chore: lint fixes part 5#257

Open
pawbana wants to merge 3 commits intopb/coder-lint-fix4from
pb/coder-lint-fix5
Open

chore: lint fixes part 5#257
pawbana wants to merge 3 commits intopb/coder-lint-fix4from
pb/coder-lint-fix5

Conversation

@pawbana
Copy link
Copy Markdown
Contributor

@pawbana pawbana commented Apr 10, 2026

  • errname (3): UnknownRoute → ErrUnknownRoute; errorResponse → responseError (chatcompletions); ErrorResponse → responseError (messages)
  • slog field names (4): "%+v" nested slog.F → direct value; requestPath/upstreamPath → request_path/upstream_path (snake_case)
  • slog message length (5): "failed to flush" → "failed to flush event stream"; "stream failed" → "stream processing failed" (2x); "unknown error" → "unknown stream error" (2x)
  • slog message case (1): "MCP client initialized" → "mcp client initialized"
  • gosec G115 (4): added nolint:gosec for test constant uint32→int32 conversions
  • errcheck (1): explicitly discarded RecordInterceptionEnded return value
  • ineffassign (3): propagated streamCtx.Err() to interceptionErr instead of dead lastErr; added nolint:ineffassign for intentional prompt/promptFound resets

Copy link
Copy Markdown
Contributor Author

pawbana commented Apr 10, 2026

@pawbana pawbana force-pushed the pb/coder-lint-fix4 branch from edd1f90 to e1765bc Compare April 13, 2026 11:30
@pawbana pawbana force-pushed the pb/coder-lint-fix5 branch from 31f8bd5 to 240e79c Compare April 13, 2026 11:30
@pawbana pawbana force-pushed the pb/coder-lint-fix5 branch from 240e79c to 02b6daf Compare April 13, 2026 11:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants