Skip to content

chore: lint fixes part 2#254

Open
pawbana wants to merge 1 commit intopb/coder-lint-fix1from
pb/coder-lint-fix2
Open

chore: lint fixes part 2#254
pawbana wants to merge 1 commit intopb/coder-lint-fix1from
pb/coder-lint-fix2

Conversation

@pawbana
Copy link
Copy Markdown
Contributor

@pawbana pawbana commented Apr 10, 2026 •
edited
Loading

  • var-naming: HttpErr → HTTPErr, inputJson → inputJSON, strJson → strJSON, Name_ → NameStr (Go naming conventions)
  • var-declaration: removed redundant []string type annotation
  • unconvert: removed unnecessary string() conversion
  • sprintfQuotedString: "%s" → %q (4 locations)
  • elseif: else { if } → else if
  • early-return: inverted conditions to eliminate else blocks (3 locations)
  • superfluous-else: removed else after break/continue (2 locations)
  • unnecessary-stmt: single-case switch → if type assertion (4 locations)
  • empty-block: added nolint directive for intentionally swallowed panic recovery

@pawbana Graphite App
Copy link
Copy Markdown
Contributor Author

pawbana commented Apr 10, 2026 •
edited
Loading

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

This was referenced Apr 10, 2026
Open
Open
@pawbana pawbana changed the title chore: lint fix1 chore: manual lint fix 1 Apr 10, 2026
@pawbana pawbana force-pushed the pb/coder-lint-fix2 branch from a5dbc5a to f5e7578 Compare April 10, 2026 11:25
@pawbana pawbana force-pushed the pb/coder-lint-fix1 branch from a599656 to bdb5386 Compare April 10, 2026 11:28
@pawbana pawbana force-pushed the pb/coder-lint-fix2 branch from f5e7578 to 2220451 Compare April 10, 2026 11:28
@pawbana pawbana force-pushed the pb/coder-lint-fix1 branch from bdb5386 to 2bc6469 Compare April 10, 2026 12:23
@pawbana pawbana force-pushed the pb/coder-lint-fix2 branch from 2220451 to 6c82ff7 Compare April 10, 2026 12:23
@pawbana pawbana mentioned this pull request Apr 10, 2026
Open
@pawbana pawbana changed the title chore: manual lint fix 1 chore: lint fixes part 2 Apr 10, 2026
@pawbana pawbana force-pushed the pb/coder-lint-fix1 branch from 2bc6469 to 7f9ee40 Compare April 10, 2026 12:30
@pawbana pawbana force-pushed the pb/coder-lint-fix2 branch from 6c82ff7 to 3f49be8 Compare April 10, 2026 12:30
This was referenced Apr 10, 2026
Open
Open
Open
Open
Open
Open
Open
Open
@pawbana pawbana marked this pull request as ready for review April 10, 2026 22:12
@pawbana pawbana mentioned this pull request Apr 13, 2026
Open
dannykopping
dannykopping approved these changes Apr 13, 2026
View reviewed changes
Copy link
Copy Markdown
Collaborator

@dannykopping dannykopping left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 👍

@pawbana pawbana force-pushed the pb/coder-lint-fix1 branch from 7f9ee40 to fd707a7 Compare April 13, 2026 11:30
@pawbana pawbana force-pushed the pb/coder-lint-fix2 branch from 3f49be8 to 5c0d4f3 Compare April 13, 2026 11:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dannykopping dannykopping dannykopping approved these changes

@ssncferreira ssncferreira Awaiting requested review from ssncferreira

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@pawbana @dannykopping