Open
Conversation
This was referenced Apr 10, 2026
Contributor
Author
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
This was referenced Apr 10, 2026
| func newBridgeTestServer( | ||
| t *testing.T, | ||
| ctx context.Context, | ||
| t *testing.T, |
Collaborator
There was a problem hiding this comment.
Was this picked up by a linter? Seems like an unneccesary change.
Contributor
Author
There was a problem hiding this comment.
I believe it this regarding this point:
context-as-argument (2): moved context.Context to first parameter in newBridgeTestServer and newMockUpstream, updated ~60 call sites
linter rule is that context needs to be first argument IIRC.
edd1f90 to
e1765bc
Compare
ead0336 to
e63a56f
Compare
dannykopping
approved these changes
Apr 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

newPassthroughRouter to avoid shadowing the provider package