Skip to content

chore: lint fixes part 7#259

Open
pawbana wants to merge 1 commit intopb/coder-lint-fix6from
pb/coder-lint-fix7
Open

chore: lint fixes part 7#259
pawbana wants to merge 1 commit intopb/coder-lint-fix6from
pb/coder-lint-fix7

Conversation

@pawbana
Copy link
Copy Markdown
Contributor

@pawbana pawbana commented Apr 10, 2026

  • bodyclose (65 → 0): changed makeRequest to return (*http.Response, error) so callers properly handle errors and close response bodies; updated all ~55 call sites across bridge_test.go,
    circuit_breaker_test.go, metrics_test.go, responses_test.go, trace_test.go, apidump_test.go;

refactored circuit breaker doRequest helpers to return int (status code) since they fully consume and close the
body; added defer resp.Body.Close() for http.ReadResponse, setupInjectedToolTest, and middleware test responses; added nolint for nil-response error case in RoundTrip test

Copy link
Copy Markdown
Contributor Author

pawbana commented Apr 10, 2026

@pawbana pawbana force-pushed the pb/coder-lint-fix6 branch from 95d767c to 523ed94 Compare April 13, 2026 11:30
@pawbana pawbana force-pushed the pb/coder-lint-fix7 branch 2 times, most recently from 0abaee3 to c270a4e Compare April 13, 2026 11:41
@pawbana pawbana force-pushed the pb/coder-lint-fix6 branch 2 times, most recently from 6139b9e to d91d17a Compare April 13, 2026 13:19
@pawbana pawbana force-pushed the pb/coder-lint-fix7 branch from c270a4e to 90dd71d Compare April 13, 2026 13:19
@pawbana pawbana force-pushed the pb/coder-lint-fix6 branch from d91d17a to 9e01fa4 Compare April 13, 2026 13:39
@pawbana pawbana force-pushed the pb/coder-lint-fix7 branch from 90dd71d to 3dbff3c Compare April 13, 2026 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants