Skip to content

test: add TestAppServer builder#31425

Merged
anp-oai merged 1 commit into
mainfrom
codex/test-app-server-builder
Jul 7, 2026
Merged

test: add TestAppServer builder#31425
anp-oai merged 1 commit into
mainfrom
codex/test-app-server-builder

Conversation

@anp-oai

@anp-oai anp-oai commented Jul 7, 2026

Copy link
Copy Markdown
Collaborator

Why

Test callers need one composable way to create app-server fixtures instead of a growing family of overlapping constructor implementations.

What

  • add a feature-complete TestAppServer::builder()
  • make the default builder own a temporary CODEX_HOME and select the automatic test environment
  • expose builder knobs for no automatic environment, explicit CODEX_HOME, program, arguments, plugin startup tasks, environment overrides, managed config, and JSON logging
  • keep the existing public constructor surface, but route every constructor through the builder so the new path is exercised immediately
  • remove the redundant private constructor ladders; caller migration and public constructor removal live in the optional cleanup stack

Validation

  • just test -p codex-app-server (940/941 before updating the expected builder error wording)
  • just test -p codex-app-server auto_env_rejects_explicit_environment_config
  • just fix -p codex-app-server
  • just fmt

Follow-up stacks

Cleanup, optional for the benchmark work:

  1. #31451 test: migrate TestAppServer callers to builder
  2. #31452 test: remove TestAppServer constructors

Benchmark infrastructure:

  1. #31427 test: add delayed exec-server transport
  2. #31295 bench: add cold skill load macrobenchmark
  3. #31428 bench: add e2e benchmark entrypoints
  4. #31429 ci: smoke Bazel e2e benchmarks

@anp-oai anp-oai force-pushed the codex/test-app-server-builder branch 2 times, most recently from 717dcfb to 229d5b7 Compare July 7, 2026 18:14
anp-oai added a commit that referenced this pull request Jul 7, 2026
## Why

Remote-executor integration tests need one host-agnostic exec-server
fixture target instead of a Windows-only wrapper.

## What

- rename the testing binary target to exec-server
- make the fixture source and target host-agnostic
- update Windows remote-executor test wiring to use the shared target

## Validation

- bazel build //codex-rs/exec-server/testing:exec-server
- bazel cquery --config=ci-windows-cross
'set(//codex-rs/exec-server/testing:exec-server
//codex-rs/core/tests/remote_env_windows:smoke-test)'

## Stack

1. [#31422 test: generalize exec-server
fixture](#31422)
2. [#31425 test: add TestAppServer
builder](#31425)
3. [#31427 test: add delayed exec-server
transport](#31427)
4. [#31295 bench: add cold skill load
macrobenchmark](#31295)
5. [#31428 bench: add e2e benchmark
entrypoints](#31428)
6. [#31429 ci: smoke Bazel e2e
benchmarks](#31429)
Base automatically changed from codex/executor-test-fixture to main July 7, 2026 18:21
@anp-oai anp-oai force-pushed the codex/test-app-server-builder branch 2 times, most recently from a285d5e to 12510ad Compare July 7, 2026 19:04
@anp-oai anp-oai marked this pull request as ready for review July 7, 2026 20:33
@anp-oai

anp-oai commented Jul 7, 2026

Copy link
Copy Markdown
Collaborator Author

@codex review

@chatgpt-codex-connector

Copy link
Copy Markdown
Contributor

Codex Review: Didn't find any major issues. Hooray!

Reviewed commit: 12510ad531

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@anp-oai anp-oai force-pushed the codex/test-app-server-builder branch from 12510ad to ae9a4a1 Compare July 7, 2026 22:10
@anp-oai anp-oai enabled auto-merge (squash) July 7, 2026 22:10
@anp-oai anp-oai merged commit 9222493 into main Jul 7, 2026
35 checks passed
@anp-oai anp-oai deleted the codex/test-app-server-builder branch July 7, 2026 22:20
@github-actions github-actions Bot locked and limited conversation to collaborators Jul 7, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants