test: add TestAppServer builder#31425
Merged
Merged
Conversation
This was referenced Jul 7, 2026
717dcfb to
229d5b7
Compare
This was referenced Jul 7, 2026
anp-oai
added a commit
that referenced
this pull request
Jul 7, 2026
## Why Remote-executor integration tests need one host-agnostic exec-server fixture target instead of a Windows-only wrapper. ## What - rename the testing binary target to exec-server - make the fixture source and target host-agnostic - update Windows remote-executor test wiring to use the shared target ## Validation - bazel build //codex-rs/exec-server/testing:exec-server - bazel cquery --config=ci-windows-cross 'set(//codex-rs/exec-server/testing:exec-server //codex-rs/core/tests/remote_env_windows:smoke-test)' ## Stack 1. [#31422 test: generalize exec-server fixture](#31422) 2. [#31425 test: add TestAppServer builder](#31425) 3. [#31427 test: add delayed exec-server transport](#31427) 4. [#31295 bench: add cold skill load macrobenchmark](#31295) 5. [#31428 bench: add e2e benchmark entrypoints](#31428) 6. [#31429 ci: smoke Bazel e2e benchmarks](#31429)
a285d5e to
12510ad
Compare
Collaborator
Author
|
@codex review |
Contributor
|
Codex Review: Didn't find any major issues. Hooray! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
sayan-oai
approved these changes
Jul 7, 2026
12510ad to
ae9a4a1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Test callers need one composable way to create app-server fixtures instead of a growing family of overlapping constructor implementations.
What
Validation
Follow-up stacks
Cleanup, optional for the benchmark work:
Benchmark infrastructure: