test: remove TestAppServer constructors#31452
Merged
Merged
Conversation
This was referenced Jul 7, 2026
anp-oai
force-pushed
the
codex/test-app-server-builder-callers
branch
2 times, most recently
from
dce1084 to
50462a1
Compare
anp-oai
force-pushed
the
codex/test-app-server-builder-remove-constructors
branch
from
32d3544 to
ff0feeb
Compare
anp-oai
force-pushed
the
codex/test-app-server-builder-callers
branch
from
50462a1 to
87b5a6a
Compare
anp-oai
force-pushed
the
codex/test-app-server-builder-remove-constructors
branch
from
ff0feeb to
1df264a
Compare
anp-oai
added a commit
that referenced
this pull request
Jul 7, 2026
## Why Test callers need one composable way to create app-server fixtures instead of a growing family of overlapping constructor implementations. ## What - add a feature-complete TestAppServer::builder() - make the default builder own a temporary CODEX_HOME and select the automatic test environment - expose builder knobs for no automatic environment, explicit CODEX_HOME, program, arguments, plugin startup tasks, environment overrides, managed config, and JSON logging - keep the existing public constructor surface, but route every constructor through the builder so the new path is exercised immediately - remove the redundant private constructor ladders; caller migration and public constructor removal live in the optional cleanup stack ## Validation - just test -p codex-app-server (940/941 before updating the expected builder error wording) - just test -p codex-app-server auto_env_rejects_explicit_environment_config - just fix -p codex-app-server - just fmt ## Follow-up stacks Cleanup, optional for the benchmark work: 1. [#31451 test: migrate TestAppServer callers to builder](#31451) 2. [#31452 test: remove TestAppServer constructors](#31452) Benchmark infrastructure: 1. [#31427 test: add delayed exec-server transport](#31427) 2. [#31295 bench: add cold skill load macrobenchmark](#31295) 3. [#31428 bench: add e2e benchmark entrypoints](#31428) 4. [#31429 ci: smoke Bazel e2e benchmarks](#31429)
anp-oai
force-pushed
the
codex/test-app-server-builder-callers
branch
from
87b5a6a to
035504b
Compare
anp-oai
force-pushed
the
codex/test-app-server-builder-remove-constructors
branch
from
1df264a to
2712ad9
Compare
anp-oai
force-pushed
the
codex/test-app-server-builder-callers
branch
from
035504b to
5d76622
Compare
anp-oai
force-pushed
the
codex/test-app-server-builder-remove-constructors
branch
from
2712ad9 to
94846ae
Compare
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 94846aef93
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
anp-oai
added a commit
that referenced
this pull request
Jul 8, 2026
anp-oai
force-pushed
the
codex/test-app-server-builder-callers
branch
from
5d76622 to
ed08452
Compare
anp-oai
added a commit
that referenced
this pull request
Jul 8, 2026
## Why Keep the TestAppServer builder API change reviewable by moving the repository-wide caller migration into a mechanical follow-up. ## What - replace TestAppServer constructor callsites with equivalent builder chains - preserve each caller's automatic-environment, args, program, env, managed-config, plugin-startup, and JSON-logging behavior - make no TestAppServer implementation changes ## Validation - cargo check -p codex-app-server --tests ## Cleanup stack 1. [#31425 test: add TestAppServer builder](#31425) 2. [#31451 test: migrate TestAppServer callers to builder](#31451) 3. [#31452 test: remove TestAppServer constructors](#31452)
anp-oai
added a commit
that referenced
this pull request
Jul 8, 2026
anp-oai
force-pushed
the
codex/test-app-server-builder-remove-constructors
branch
from
9b8e165 to
9d02706
Compare
Collaborator
Author
|
@codex review |
sayan-oai
approved these changes
Jul 8, 2026
anp-oai
force-pushed
the
codex/test-app-server-builder-remove-constructors
branch
from
9d02706 to
c2e6259
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Finish the TestAppServer builder migration after every caller has moved off the compatibility constructors.
What
Validation
Cleanup stack