test: add delayed exec-server transport#31427
Merged
Merged
Conversation
This was referenced Jul 7, 2026
anp-oai
force-pushed
the
codex/test-app-server-builder
branch
from
3503ccf to
717dcfb
Compare
anp-oai
force-pushed
the
codex/test-app-server-rpc-delay
branch
from
a9701fb to
97c4357
Compare
anp-oai
force-pushed
the
codex/test-app-server-builder
branch
from
717dcfb to
229d5b7
Compare
anp-oai
force-pushed
the
codex/test-app-server-rpc-delay
branch
from
97c4357 to
ede6cf5
Compare
anp-oai
added a commit
that referenced
this pull request
Jul 7, 2026
## Why Remote-executor integration tests need one host-agnostic exec-server fixture target instead of a Windows-only wrapper. ## What - rename the testing binary target to exec-server - make the fixture source and target host-agnostic - update Windows remote-executor test wiring to use the shared target ## Validation - bazel build //codex-rs/exec-server/testing:exec-server - bazel cquery --config=ci-windows-cross 'set(//codex-rs/exec-server/testing:exec-server //codex-rs/core/tests/remote_env_windows:smoke-test)' ## Stack 1. [#31422 test: generalize exec-server fixture](#31422) 2. [#31425 test: add TestAppServer builder](#31425) 3. [#31427 test: add delayed exec-server transport](#31427) 4. [#31295 bench: add cold skill load macrobenchmark](#31295) 5. [#31428 bench: add e2e benchmark entrypoints](#31428) 6. [#31429 ci: smoke Bazel e2e benchmarks](#31429)
anp-oai
force-pushed
the
codex/test-app-server-builder
branch
from
229d5b7 to
a285d5e
Compare
anp-oai
force-pushed
the
codex/test-app-server-rpc-delay
branch
from
ede6cf5 to
36ec068
Compare
anp-oai
force-pushed
the
codex/test-app-server-builder
branch
from
a285d5e to
12510ad
Compare
anp-oai
force-pushed
the
codex/test-app-server-rpc-delay
branch
from
36ec068 to
ec6b04b
Compare
anp-oai
force-pushed
the
codex/test-app-server-builder
branch
from
12510ad to
ae9a4a1
Compare
anp-oai
added a commit
that referenced
this pull request
Jul 7, 2026
## Why Test callers need one composable way to create app-server fixtures instead of a growing family of overlapping constructor implementations. ## What - add a feature-complete TestAppServer::builder() - make the default builder own a temporary CODEX_HOME and select the automatic test environment - expose builder knobs for no automatic environment, explicit CODEX_HOME, program, arguments, plugin startup tasks, environment overrides, managed config, and JSON logging - keep the existing public constructor surface, but route every constructor through the builder so the new path is exercised immediately - remove the redundant private constructor ladders; caller migration and public constructor removal live in the optional cleanup stack ## Validation - just test -p codex-app-server (940/941 before updating the expected builder error wording) - just test -p codex-app-server auto_env_rejects_explicit_environment_config - just fix -p codex-app-server - just fmt ## Follow-up stacks Cleanup, optional for the benchmark work: 1. [#31451 test: migrate TestAppServer callers to builder](#31451) 2. [#31452 test: remove TestAppServer constructors](#31452) Benchmark infrastructure: 1. [#31427 test: add delayed exec-server transport](#31427) 2. [#31295 bench: add cold skill load macrobenchmark](#31295) 3. [#31428 bench: add e2e benchmark entrypoints](#31428) 4. [#31429 ci: smoke Bazel e2e benchmarks](#31429)
anp-oai
force-pushed
the
codex/test-app-server-rpc-delay
branch
from
ec6b04b to
0db9962
Compare
anp-oai
added a commit
that referenced
this pull request
Jul 8, 2026
anp-oai
commented
Jul 8, 2026
anp-oai
added a commit
that referenced
this pull request
Jul 8, 2026
anp-oai
force-pushed
the
codex/test-app-server-rpc-delay
branch
from
6de2022 to
f19d63b
Compare
anp-oai
commented
Jul 8, 2026
Collaborator
Author
|
@codex review |
anp-oai
added a commit
that referenced
this pull request
Jul 8, 2026
anp-oai
force-pushed
the
codex/test-app-server-rpc-delay
branch
from
f19d63b to
c1c3ef0
Compare
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: f19d63b2b5
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
anp-oai
added a commit
that referenced
this pull request
Jul 8, 2026
anp-oai
force-pushed
the
codex/test-app-server-rpc-delay
branch
from
c1c3ef0 to
24376ad
Compare
Contributor
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: f19d63b2b5
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
anp-oai
added a commit
that referenced
this pull request
Jul 8, 2026
anp-oai
force-pushed
the
codex/test-app-server-rpc-delay
branch
from
24376ad to
9d3680d
Compare
jif-oai
approved these changes
Jul 8, 2026
jif-oai
left a comment
jif-oai
left a comment
Collaborator
There was a problem hiding this comment.
Pre-approving to unblock
anp-oai
added a commit
that referenced
this pull request
Jul 8, 2026
anp-oai
force-pushed
the
codex/test-app-server-rpc-delay
branch
from
9d3680d to
627bca3
Compare
anp-oai
added a commit
that referenced
this pull request
Jul 8, 2026
anp-oai
force-pushed
the
codex/test-app-server-rpc-delay
branch
from
627bca3 to
4e273d8
Compare
Collaborator
Author
|
@codex review |
Contributor
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 4e273d8e7b
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
anp-oai
force-pushed
the
codex/test-app-server-rpc-delay
branch
from
ae39168 to
b752ca1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Macrobenchmarks benefit from having a way to exercise remote-executor latency without depending on Docker.
This is a very minimal first cut, if we find that simulating network conditions is useful we can always expand this scope or switch to a more robust network shaping approach.
What
Stack