bench: add e2e benchmark entrypoints#31428
Draft
anp-oai wants to merge 1 commit into
Draft
Conversation
This was referenced Jul 7, 2026
38360b6 to
726589b
Compare
40d035e to
f8fd71a
Compare
726589b to
e6f4113
Compare
f8fd71a to
f9458bb
Compare
e6f4113 to
ecf0c9c
Compare
f9458bb to
7777895
Compare
anp-oai
added a commit
that referenced
this pull request
Jul 7, 2026
## Why Remote-executor integration tests need one host-agnostic exec-server fixture target instead of a Windows-only wrapper. ## What - rename the testing binary target to exec-server - make the fixture source and target host-agnostic - update Windows remote-executor test wiring to use the shared target ## Validation - bazel build //codex-rs/exec-server/testing:exec-server - bazel cquery --config=ci-windows-cross 'set(//codex-rs/exec-server/testing:exec-server //codex-rs/core/tests/remote_env_windows:smoke-test)' ## Stack 1. [#31422 test: generalize exec-server fixture](#31422) 2. [#31425 test: add TestAppServer builder](#31425) 3. [#31427 test: add delayed exec-server transport](#31427) 4. [#31295 bench: add cold skill load macrobenchmark](#31295) 5. [#31428 bench: add e2e benchmark entrypoints](#31428) 6. [#31429 ci: smoke Bazel e2e benchmarks](#31429)
ecf0c9c to
8ac3c16
Compare
7777895 to
67e8bf0
Compare
8ac3c16 to
0079a34
Compare
67e8bf0 to
b860399
Compare
anp-oai
added a commit
that referenced
this pull request
Jul 7, 2026
## Why Test callers need one composable way to create app-server fixtures instead of a growing family of overlapping constructor implementations. ## What - add a feature-complete TestAppServer::builder() - make the default builder own a temporary CODEX_HOME and select the automatic test environment - expose builder knobs for no automatic environment, explicit CODEX_HOME, program, arguments, plugin startup tasks, environment overrides, managed config, and JSON logging - keep the existing public constructor surface, but route every constructor through the builder so the new path is exercised immediately - remove the redundant private constructor ladders; caller migration and public constructor removal live in the optional cleanup stack ## Validation - just test -p codex-app-server (940/941 before updating the expected builder error wording) - just test -p codex-app-server auto_env_rejects_explicit_environment_config - just fix -p codex-app-server - just fmt ## Follow-up stacks Cleanup, optional for the benchmark work: 1. [#31451 test: migrate TestAppServer callers to builder](#31451) 2. [#31452 test: remove TestAppServer constructors](#31452) Benchmark infrastructure: 1. [#31427 test: add delayed exec-server transport](#31427) 2. [#31295 bench: add cold skill load macrobenchmark](#31295) 3. [#31428 bench: add e2e benchmark entrypoints](#31428) 4. [#31429 ci: smoke Bazel e2e benchmarks](#31429)
0079a34 to
ce11104
Compare
b860399 to
29179d5
Compare
29179d5 to
e5b20f0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Bazel-backed macrobenchmarks need stable local entrypoints that can grow without changing every caller.
What
Validation
Stack