Skip to content

636017 Move CashFlow report action tooltips to report objects (W1)#9528

Open
V-CWurtzen wants to merge 2 commits into
mainfrom
features/636017-CashFlow-move-page-action-tooltips-to-report
Open

636017 Move CashFlow report action tooltips to report objects (W1)#9528
V-CWurtzen wants to merge 2 commits into
mainfrom
features/636017-CashFlow-move-page-action-tooltips-to-report

Conversation

@V-CWurtzen

@V-CWurtzen V-CWurtzen commented Jul 16, 2026

Copy link
Copy Markdown

What & why

Moves the report action ToolTips for the CashFlow reports off the page actions that run them and onto the report objects themselves, and integrates that move into every forked country layer. The tooltip is now defined once on the report and applies wherever the report is invoked, and the now-duplicate ToolTip is removed from the page actions in W1 and its country forks.

Reports covered:

  • report 846 "Cash Flow Date List" — kept the descriptive tooltip.
  • report 852 "Cash Flow Dimensions - Detail" — only a Run the ... report. stub tooltip exists anywhere for this report, so it is hoisted as the sole option. Happy to replace it with a better-written tooltip if a reviewer can suggest one.

report "Suggest Worksheet Lines" is in the area but has no page-action tooltip, so it is left unchanged.

This is part of the "move report action tooltips to report objects" cleanup (CP0529-331 / slice 636017).

Changes

  • W1 (commit 1): report-level ToolTip added to CashFlowDateList.Report.al and CashFlowDimensionsDetail.Report.al; duplicate removed from the corresponding actions on AccountantRoleCenter.Page.al, AccountingManagerRoleCenter.Page.al, and FinanceManagerRoleCenter.Page.al. For "Cash Flow Date List" the descriptive variant is kept and the stub on Finance Manager RC dropped.
  • Country layers (commit 2): the W1 move is propagated to the forked country layers as required by the Miapp sync gate (VerifyMiappSync):
    • 39 role-center page forks (Accountant / Accounting Manager / Finance Manager across APAC, AT, AU, BE, CH, DACH, DE, ES, FI, FR, GB, IS, IT, NA, NL, NO, NZ, RU, SE): duplicate ToolTip removed from the covered actions.
    • 1 report fork (GB CashFlowDimensionsDetail.Report.al): report-level ToolTip added to match W1.
    • NA AccountantRoleCenter.Page.al: no-op integration (trailing newline only). The sync gate requires every fork of a changed W1 file to be in the changelist; this fork carries no covered action, so there is nothing to remove.

Total: 46 files (5 W1 + 41 country), tooltip-only.

Linked work

Fixes AB#636017

How I validated this

  • I read the full diff and it contains only changes I intended.
  • I built the affected app(s) locally with no new analyzer warnings.
  • I ran the change in Business Central and confirmed it behaves as expected.
  • I added or updated tests for the new behavior, or explained below why none are needed.

What I tested and the outcome

Metadata-only change (ToolTip property). The diff is tooltip-only across all files (report ToolTip additions + page-action ToolTip removals), with BOM/EOL preserved and no other lines changed; the only non-tooltip edit is a single trailing newline on NA AccountantRoleCenter.Page.al (no-op sync touch). The tooltip text moved onto / removed from each object is byte-identical to the standard English strings, so the end-user tooltip is unchanged — it is now sourced from the report object.

Country propagation was produced by running Invoke-Miapp to identify the fork set, then applying the move surgically (Invoke-Miapp's auto-merge mis-aligned on the structurally-divergent role centers, so its output was not used directly). The set of changed forks matches exactly what VerifyMiappSync requires — no missing forks, no extras.

No tests added: ToolTip is a design-time metadata property with no runtime behavior to assert; there is no existing tooltip test harness for these objects.

Risk & compatibility

Low. No code, schema, table, or behavior change — only the ToolTip design property moves from page action to report, in W1 and its country forks. No upgrade/data impact, no permission/telemetry impact, no breaking change. Same cleanup pattern already merged for Warehouse, Manufacturing, Service, Sales and Inventory, and landed as the Pricing pilot (#9433) on the new BCApps pipeline.

Move the report action ToolTips for the CashFlow reports off the page
actions that run them and onto the report objects, so each tooltip is
defined once and applies wherever the report is invoked:

  report 846 "Cash Flow Date List"
  report 852 "Cash Flow Dimensions - Detail"

Remove the now-duplicate ToolTip from the W1 page actions that run these
reports (Accountant, Accounting Manager and Finance Manager role centers).
"Cash Flow Date List" was referenced with a descriptive tooltip on two role
centers and a "Run the ... report." stub on a third; per the conflict rule
the descriptive text is kept and the stub dropped. "Cash Flow Dimensions -
Detail" had only the placeholder stub available, so that text is hoisted as
the sole option (a better tooltip can be authored later). The report
"Suggest Worksheet Lines" carries no page-action tooltip and is left
unchanged.

This commit covers the W1 base only; the duplicate ToolTip on the country
forks of these role centers will be removed in a follow-up commit on this
branch.
@V-CWurtzen V-CWurtzen requested a review from a team July 16, 2026 09:03
@github-actions github-actions Bot added this to the Version 29.0 milestone Jul 16, 2026
@github-actions

github-actions Bot commented Jul 16, 2026

Copy link
Copy Markdown
Contributor

Copilot PR Review

Iteration 2 · Outcome: completed

All 16 sub-skills ran; the diff is a mechanical ToolTip-property relocation (page action -> report object) with no logic, schema, security, or API surface changes, so no sub-skill found an applicable defect and the self-review pass surfaced no cross-cutting concern.

Knowledge source: https://github.com/microsoft/BCQuality@186d8a131465475c79244d994acb872cd5c0d4bf

Orchestrator pre-filter (2 file(s) excluded)

  • layer-disabled (knowledge) : 2 file(s)

Findings produced by the AL review agent v1.7.3. Reply 👎 on any inline comment to flag false positives.

Integrate the W1 CashFlow tooltip move into the forked country layers, as
required by the Miapp sync gate (VerifyMiappSync):

- 39 role-center page forks (Accountant / Accounting Manager / Finance
  Manager across APAC, AT, AU, BE, CH, DACH, DE, ES, FI, FR, GB, IS, IT,
  NA, NL, NO, NZ, RU, SE): removed the duplicate ToolTip from the
  "Cash Flow Date List" and "Cash Flow Dimensions - Detail" actions.
- 1 report fork (GB CashFlowDimensionsDetail.Report.al): added the same
  report-level ToolTip as W1.
- NA AccountantRoleCenter: no-op integration (adds trailing newline). The
  sync gate requires every fork of a changed W1 file in the changelist;
  this fork has no covered action, so there is nothing to remove.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Finance GitHub request for Finance area

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants