636017 Move Fixed Assets report action tooltips to report objects#9546
636017 Move Fixed Assets report action tooltips to report objects#9546V-CWurtzen wants to merge 2 commits into
Conversation
Move the report action ToolTips for 29 Fixed Assets reports onto the report objects and remove the now-duplicate ToolTip from the W1 page actions that run them (Fixed Asset card/list and FA/Insurance/Maintenance pages and role centers, plus the Accountant/Administrator role centers and Data Administration). Covers the Fixed Asset - Book Value/List/Register/G-L Analysis/Acquisition reports, the Insurance - Analysis/List/Coverage/Register set, Calculate Depreciation, Copy Depreciation Book, the Date Compress FA/Insurance/Maint. Ledger set, the Delete Empty FA/Insurance Registers set, and others. Where only a "Run the X report." stub existed (FA Posting Group - Net Change, Index Fixed Assets, Index Insurance, the Maintenance - Analysis/Details/ Next Service/Register set) it is hoisted as the sole option. Reports with ObsoleteState = Pending/Removed are skipped (3).
Integrate the W1 Fixed Assets tooltip move into the forked country layers, as required by the Miapp sync gate (VerifyMiappSync): - 59 page forks across 19 country layers: removed the duplicate ToolTip from the covered-report actions (462 lines). - 10 report forks (FR: CalculateDepreciation, CopyDepreciationBook, CancelFALedgerEntries, CopyFAEntriestoGLBudget, IndexFixedAssets, FixedAssetBookValue01/02; GB CopyDepreciationBook; IT/RU CalculateDepreciation): added the W1 report-level ToolTip. - 1 no-op integration (NA AccountantRoleCenter): the sync gate requires every fork of a changed W1 file in the changelist; it carries no covered action, so there is nothing to remove.
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| { | ||
| ApplicationArea = FixedAssets; | ||
| Caption = 'Index Fixed Assets'; | ||
| ToolTip = 'Run the Index Fixed Assets report.'; |
There was a problem hiding this comment.
Several of the newly-added Report ToolTips only restate the object's caption/name ("Run the X report.") instead of describing what the report shows or does, so they add no information beyond the caption already visible on the action/Tell Me entry.
This diverges from the surrounding tooltips in the same PR (e.g. 'Calculate Depreciation', 'Fixed Asset - Book Value 01') which describe purpose and content, and from the field-tooltip convention in BCQuality (microsoft/knowledge/style/tooltip-required-on-page-fields.md) that tooltips should describe what the item shows/does rather than just naming it. Affected locations: src/Layers/W1/BaseApp/FixedAssets/FixedAsset/IndexFixedAssets.Report.al:18 ('Run the Index Fixed Assets report.'), src/Layers/FR/BaseApp/FixedAssets/FixedAsset/IndexFixedAssets.Report.al:18 (same text), src/Layers/W1/BaseApp/FixedAssets/Insurance/IndexInsurance.Report.al:16 ('Run the Index Insurance report.'), src/Layers/W1/BaseApp/FixedAssets/Maintenance/MaintenanceAnalysis.Report.al:15 ('Run the Maintenance Analysis report.'), src/Layers/W1/BaseApp/FixedAssets/Maintenance/MaintenanceDetails.Report.al:15 ('Run the Maintenance Details report.'), src/Layers/W1/BaseApp/FixedAssets/Maintenance/MaintenanceNextService.Report.al:13 ('Run the Maintenance Next Service report.'), src/Layers/W1/BaseApp/FixedAssets/Maintenance/MaintenanceRegister.Report.al:14 ('Run the Maintenance Register report.'), and src/Layers/W1/BaseApp/FixedAssets/Reports/FAPostingGroupNetChange.Report.al:19 ('Run the FA Posting Group - Net Change report.'). Recommend rewriting each to describe the report's actual content/purpose, consistent with the other ToolTips added in this PR.
Agent judgement — not directly backed by a BCQuality knowledge article.
👍 useful · ❤️ especially valuable · 👎 wrong - reply with why
| { | ||
| ApplicationArea = FixedAssets; | ||
| Caption = 'Fixed Asset List'; | ||
| ToolTip = 'View the list of fixed assets that exist in the system .'; |
There was a problem hiding this comment.
New Report ToolTip has a stray space before the terminating period: "View the list of fixed assets that exist in the system ." should read "...in the system." (no space before the period).
This is user-facing text shown as a hover tooltip and in Tell Me search results.
Agent judgement — not directly backed by a BCQuality knowledge article.
👍 useful · ❤️ especially valuable · 👎 wrong - reply with why
Copilot PR ReviewIteration 1 · Outcome: completed
Knowledge source: https://github.com/microsoft/BCQuality@186d8a131465475c79244d994acb872cd5c0d4bf Findings by domainFindings split into Knowledge-backed (cite a BCQuality article) and Agent (the agent's own judgement, no matching BCQuality rule).
Totals: 0 knowledge-backed · 2 agent findings. Orchestrator pre-filter (2 file(s) excluded)
Findings produced by the AL review agent v1.7.3. Reply 👎 on any inline comment to flag false positives. |
1 participant
What & why
Moves the report action ToolTips for the Fixed Assets reports off the page actions that run them and onto the report objects themselves, and integrates that move into every forked country layer. The tooltip is now defined once on the report and applies wherever the report is invoked, and the now-duplicate
ToolTipis removed from the page actions in W1 and its country forks.29 reports covered — the
Fixed Asset - Book Value 01/02,Fixed Asset - List/Register/Acquisition List/G-L Analysisreports, theInsurance - Analysis/List/Coverage Details/Tot. Value Insured/Uninsured FAs/Registerset,Calculate Depreciation,Copy Depreciation Book,Create FA Depreciation Books,Cancel FA Ledger Entries,Copy FA Entries to G/L Budget, theDate Compress FA/Insurance/Maint. Ledgerset, theDelete Empty FA/Insurance Registersset, and others.Where only a
Run the X report.stub existed (FA Posting Group - Net Change,Index Fixed Assets,Index Insurance,Maintenance - Analysis/Details/Next Service,Maintenance Register), it is hoisted as the sole option — happy to replace with better wording if a reviewer suggests it. Reports withObsoleteState = Pending/Removedare skipped (3).This is part of the "move report action tooltips to report objects" cleanup (CP0529-331 / slice 636017).
Changes
ToolTipadded to the 29 reports; duplicate removed from the W1 actions that run them (Fixed Asset card/list and FA/Insurance/Maintenance pages and role centers, plus the Accountant/Administrator role centers and Data Administration). 41 files.VerifyMiappSync):ToolTipremoved from the covered actions (462 lines).CalculateDepreciation,CopyDepreciationBook,CancelFALedgerEntries,CopyFAEntriestoGLBudget,IndexFixedAssets,FixedAssetBookValue01/02;GB CopyDepreciationBook;IT/RU CalculateDepreciation): report-levelToolTipadded to match W1.NA AccountantRoleCenter): the sync gate requires every fork of a changed W1 file in the changelist; it carries no covered action, so there is nothing to remove.Total: 111 files (41 W1 + 70 country), tooltip-only.
Linked work
Fixes AB#636017
How I validated this
What I tested and the outcome
Metadata-only change (
ToolTipproperty). The diff is tooltip-only (reportToolTipadditions + page-actionToolTipremovals), with BOM/EOL preserved and no other lines changed; the only non-tooltip edit is a single trailing newline onNA AccountantRoleCenter.Page.al(no-op sync touch). Country propagation was produced by runningInvoke-Miappto identify the fork set, then applying the move surgically (Invoke-Miapp's auto-merge mis-aligned on the structurally-divergent role centers, so its output was not used directly). The set of changed forks matches exactly whatVerifyMiappSyncrequires — no missing forks, no extras.No tests added:
ToolTipis a design-time metadata property with no runtime behavior to assert; there is no existing tooltip test harness for these objects.Risk & compatibility
Low. No code, schema, table, or behavior change — only the
ToolTipdesign property moves from page action to report, in W1 and its country forks. No upgrade/data impact, no permission/telemetry impact, no breaking change. Same cleanup pattern already merged for Warehouse, Manufacturing, Service, Sales and Inventory, landed as the Pricing pilot (#9433), and applied to CashFlow (#9528), Finance (#9526), Bank (#9540), CRM (#9544) and Cost Accounting (#9545) on the new BCApps pipeline.