Skip to content

636017 Move Finance report action tooltips to report objects (W1, first batch)#9526

Open
V-CWurtzen wants to merge 3 commits into
mainfrom
features/636017-Finance-move-page-action-tooltips-to-report
Open

636017 Move Finance report action tooltips to report objects (W1, first batch)#9526
V-CWurtzen wants to merge 3 commits into
mainfrom
features/636017-Finance-move-page-action-tooltips-to-report

Conversation

@V-CWurtzen

@V-CWurtzen V-CWurtzen commented Jul 16, 2026

Copy link
Copy Markdown

What & why

Moves the report action ToolTips for four Finance reports off the page actions that run them and onto the report objects themselves, and integrates that move into every forked country layer. The tooltip is now defined once on the report and applies wherever the report is invoked, and the now-duplicate ToolTip is removed from the page actions in W1 and its country forks.

Reports covered in this batch:

  • report 597 "G/L Currency Revaluation"
  • report 94 "Close Income Statement"
  • report 24 "Sales Taxes Collected"
  • report 11 "G/L - VAT Reconciliation"

This is part of the "move report action tooltips to report objects" cleanup (CP0529-331 / slice 636017). It is the first batch of the Finance area — Finance is the largest area, so it is being rebuilt in batches; further reports will follow in later PRs.

Changes

  • W1 (commit 1): report-level ToolTip added to GLCurrencyRevaluation.Report.al, CloseIncomeStatement.Report.al, SalesTaxesCollected.Report.al, and GLVATReconciliation.Report.al; duplicate removed from the corresponding actions on ChartofAccounts.Page.al, AccountingManagerRoleCenter.Page.al, BookkeeperRoleCenter.Page.al, BusinessManagerRoleCenter.Page.al, and SmallBusinessOwnerRC.Page.al.
  • Country layers (commit 2): the W1 move is propagated to the forked country layers as required by the Miapp sync gate (VerifyMiappSync):
    • 50 role-center / Chart of Accounts page forks across APAC, AT, BE, CH, DACH, DE, ES, FI, FR, GB, IS, IT, NA, NL, RU: duplicate ToolTip removed from the covered actions.
    • 3 report forks (ES/IT CloseIncomeStatement.Report.al, NA SalesTaxesCollected.Report.al): report-level ToolTip added to match W1.
    • 3 NO role-center forks: no-op integration (blank line). The sync gate requires every fork of a changed W1 file to be in the changelist; these carry no covered action, so there is nothing to remove.
    • Incidental cleanup: a mislabeled ToolTip (EU-VAT-validation text) on the NA Bookkeeper "Sales Taxes Collected" action was removed along with the duplicate.

Total: 65 files (9 W1 + 56 country), tooltip-only.

Linked work

Fixes AB#636017

How I validated this

  • I read the full diff and it contains only changes I intended.
  • I built the affected app(s) locally with no new analyzer warnings.
  • I ran the change in Business Central and confirmed it behaves as expected.
  • I added or updated tests for the new behavior, or explained below why none are needed.

What I tested and the outcome

Metadata-only change (ToolTip property). The diff is tooltip-only (report ToolTip additions + page-action ToolTip removals), with BOM/EOL preserved and no other lines changed; the only non-tooltip edits are single trailing newlines on three NO role-center forks (no-op sync touches). Removed/added tooltip texts are byte-identical to the standard English strings, so the end-user tooltip is unchanged — it is now sourced from the report object.

Country propagation was produced by running Invoke-Miapp to identify the fork set, then applying the move surgically (Invoke-Miapp's auto-merge mis-aligned on the structurally-divergent role centers, so its output was not used directly). The set of changed forks matches exactly what VerifyMiappSync requires — no missing forks, no extras.

No tests added: ToolTip is a design-time metadata property with no runtime behavior to assert; there is no existing tooltip test harness for these objects.

Risk & compatibility

Low. No code, schema, table, or behavior change — only the ToolTip design property moves from page action to report, in W1 and its country forks. No upgrade/data impact, no permission/telemetry impact, no breaking change. Same cleanup pattern already merged for Warehouse, Manufacturing, Service, Sales and Inventory, landed as the Pricing pilot (#9433), and applied to CashFlow (#9528) on the new BCApps pipeline.

…st batch)

Move the report action ToolTips for four Finance reports off the page
actions that run them and onto the report objects, so each tooltip is
defined once and applies wherever the report is invoked:

  report 597 "G/L Currency Revaluation"
  report 94  "Close Income Statement"
  report 24  "Sales Taxes Collected"
  report 11  "G/L - VAT Reconciliation"

Remove the now-duplicate ToolTip from the W1 page actions that run these
reports (Chart of Accounts, Accounting Manager / Bookkeeper / Business
Manager / Small Business Owner role centers). The tooltip text moved onto
each report is byte-identical to what previously showed on the page action,
so the end-user tooltip is unchanged.

This commit covers the W1 base only. These pages have country forks that
carry the same action tooltip; that duplicate will be removed from the
forks in a follow-up commit on this branch.
of the Finance area to validate the AL-Go build/review loop before the
full area move.

Metadata-only change (ToolTip property); no
change. Part of the "move report action tooltips to report objects"
cleanup.
…res/636017-Finance-move-page-action-tooltips-to-report
@V-CWurtzen V-CWurtzen requested a review from a team July 16, 2026 08:49
@github-actions github-actions Bot added this to the Version 29.0 milestone Jul 16, 2026
@github-actions

github-actions Bot commented Jul 16, 2026

Copy link
Copy Markdown
Contributor

Copilot PR Review

Iteration 2 · Outcome: completed

All 16 sub-skills ran; the diff is a metadata-only ToolTip relocation (action -> report object) across 65 files with no functional, security, performance, or accessibility defects found. No knowledge-backed or agent findings met the emission bar.

Knowledge source: https://github.com/microsoft/BCQuality@186d8a131465475c79244d994acb872cd5c0d4bf

Orchestrator pre-filter (2 file(s) excluded)

  • layer-disabled (knowledge) : 2 file(s)

Findings produced by the AL review agent v1.7.3. Reply 👎 on any inline comment to flag false positives.

@V-CWurtzen

Copy link
Copy Markdown
Author

@microsoft-github-policy-service agree company="Abakion"

Integrate the W1 Finance tooltip move (first batch: G/L Currency Revaluation,
Close Income Statement, Sales Taxes Collected, G/L - VAT Reconciliation) into
the forked country layers, as required by the Miapp sync gate (VerifyMiappSync):

- 50 role-center / Chart of Accounts page forks across APAC, AT, BE, CH, DACH,
  DE, ES, FI, FR, GB, IS, IT, NA, NL, RU: removed the duplicate ToolTip from the
  covered-report actions (59 lines).
- 3 report forks (ES/IT CloseIncomeStatement, NA SalesTaxesCollected): added the
  same report-level ToolTip as W1.
- 3 NO role-center forks: no-op integration (blank line). The sync gate requires
  every fork of a changed W1 file in the changelist; these carry no covered
  action, so there is nothing to remove.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant