Skip to content

636017 Move Purchases report action tooltips to report objects#9549

Open
V-CWurtzen wants to merge 2 commits into
mainfrom
features/636017-Purchases-move-page-action-tooltips-to-report
Open

636017 Move Purchases report action tooltips to report objects#9549
V-CWurtzen wants to merge 2 commits into
mainfrom
features/636017-Purchases-move-page-action-tooltips-to-report

Conversation

@V-CWurtzen

@V-CWurtzen V-CWurtzen commented Jul 16, 2026

Copy link
Copy Markdown

What & why

Moves the report action ToolTips for the Purchases reports off the page actions that run them and onto the report objects themselves, and integrates that move into every forked country layer. The tooltip is now defined once on the report and applies wherever the report is invoked, and the now-duplicate ToolTip is removed from the page actions in W1 and its country forks.

18 reports covered — Purchase Statistics, Purchase Reservation Avail., the Vendor - Balance to Date/Detail Trial Balance/Trial Balance/Labels/Order Detail/Order Summary/Payment Receipt/Purchase List set, Vendor Item Catalog, Vendor Register, Vendor/Item Purchases, Date Compress Vendor Ledger, and the Delete Invoiced Purch. Orders/Invd Blnkt Purch Orders/Invd Purch. Ret. Orders set.

Where only a Run the X report. stub existed (Day Book Vendor Ledger Entry), it is hoisted as the sole option — happy to replace with better wording if a reviewer suggests it. Reports with ObsoleteState = Pending/Removed are skipped (5).

This is part of the "move report action tooltips to report objects" cleanup (CP0529-331 / slice 636017).

Changes

  • W1 (commit 1): report-level ToolTip added to the 18 reports; duplicate removed from the W1 actions that run them (purchase document lists, vendor pages and the Purchasing Agent role center, plus the Administrator role center and Data Administration). 31 files.
  • Country layers (commit 2): the W1 move is propagated to the forked country layers as required by the Miapp sync gate (VerifyMiappSync):
    • 55 page forks across 18 country layers: duplicate ToolTip removed from the covered actions (305 lines).
    • 8 report forks (APAC VendorLabels/VendorPaymentReceipt; BE VendorPaymentReceipt/VendorPurchaseList; ES DateCompressVendorLedger/VendorDetailTrialBalance; RU VendorOrderDetail/VendorOrderSummary): report-level ToolTip added to match W1.
    • 1 no-op integration (NA PurchasingAgentRoleCenter): the sync gate requires every fork of a changed W1 file in the changelist; it carries no covered action, so there is nothing to remove.

Total: 95 files (31 W1 + 64 country), tooltip-only.

Linked work

Fixes AB#636017

How I validated this

  • I read the full diff and it contains only changes I intended.
  • I built the affected app(s) locally with no new analyzer warnings.
  • I ran the change in Business Central and confirmed it behaves as expected.
  • I added or updated tests for the new behavior, or explained below why none are needed.

What I tested and the outcome

Metadata-only change (ToolTip property). The diff is tooltip-only (report ToolTip additions + page-action ToolTip removals), with BOM/EOL preserved and no other lines changed; the only non-tooltip edit is a single trailing newline on NA PurchasingAgentRoleCenter.Page.al (no-op sync touch). Country propagation was produced by running Invoke-Miapp to identify the fork set, then applying the move surgically (Invoke-Miapp's auto-merge mis-aligned on the structurally-divergent role centers, so its output was not used directly). The set of changed forks matches exactly what VerifyMiappSync requires — no missing forks, no extras.

No tests added: ToolTip is a design-time metadata property with no runtime behavior to assert; there is no existing tooltip test harness for these objects.

Risk & compatibility

Low. No code, schema, table, or behavior change — only the ToolTip design property moves from page action to report, in W1 and its country forks. No upgrade/data impact, no permission/telemetry impact, no breaking change. Same cleanup pattern already merged for Warehouse, Manufacturing, Service, Sales and Inventory, landed as the Pricing pilot (#9433), and applied to CashFlow (#9528), Finance (#9526), Bank (#9540), CRM (#9544), Cost Accounting (#9545), Fixed Assets (#9546) and Projects (#9548) on the new BCApps pipeline.

Move the report action ToolTips for 18 Purchases reports onto the report
objects and remove the now-duplicate ToolTip from the W1 page actions that
run them (purchase document lists, vendor pages and the Purchasing Agent
role center, plus the Administrator role center and Data Administration).

Covers Purchase Statistics, Purchase Reservation Avail., the Vendor -
Balance to Date / Detail Trial Balance / Trial Balance / Labels / Order
Detail / Order Summary / Payment Receipt / Purchase List set, Vendor Item
Catalog, Vendor Register, Vendor/Item Purchases, Date Compress Vendor
Ledger, and the Delete Invoiced Purch. Orders / Invd Blnkt Purch Orders /
Invd Purch. Ret. Orders set. Where only a "Run the X report." stub existed
(Day Book Vendor Ledger Entry) it is hoisted as the sole option. Reports
with ObsoleteState = Pending/Removed are skipped (5).
Integrate the W1 Purchases tooltip move into the forked country layers, as
required by the Miapp sync gate (VerifyMiappSync):
- 55 page forks across 18 country layers: removed the duplicate ToolTip
  from the covered-report actions (305 lines).
- 8 report forks (APAC VendorLabels/VendorPaymentReceipt; BE
  VendorPaymentReceipt/VendorPurchaseList; ES DateCompressVendorLedger/
  VendorDetailTrialBalance; RU VendorOrderDetail/VendorOrderSummary): added
  the W1 report-level ToolTip.
- 1 no-op integration (NA PurchasingAgentRoleCenter): the sync gate
  requires every fork of a changed W1 file in the changelist; it carries no
  covered action, so there is nothing to remove.
@V-CWurtzen V-CWurtzen requested a review from a team July 16, 2026 18:11
@github-actions github-actions Bot added this to the Version 29.0 milestone Jul 16, 2026
@github-actions

Copy link
Copy Markdown
Contributor

Copilot PR Review

Iteration 1 · Outcome: no-knowledge

All 16 sub-skills ran against the diff (a mechanical ToolTip de-duplication refactor moving action-level ToolTip text to the underlying RunObject Report's own ToolTip property across ~90 page/report files). No sub-skill found a knowledge-file match, and the super-skill self-review pass, after independently verifying that all 18 distinct RunObject targets whose action ToolTip was removed retain an equivalent ToolTip on the target report object, found no cross-cutting defect clearing the agent-finding precision bar.

Knowledge source: https://github.com/microsoft/BCQuality@186d8a131465475c79244d994acb872cd5c0d4bf

No findings were posted for this iteration.

Orchestrator pre-filter (2 file(s) excluded)

  • layer-disabled (knowledge) : 2 file(s)

Findings produced by the AL review agent v1.7.3. Reply 👎 on any inline comment to flag false positives.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant