636017 Move Bank report action tooltips to report objects#9540
636017 Move Bank report action tooltips to report objects#9540V-CWurtzen wants to merge 2 commits into
Conversation
Move the report action ToolTips for nine Bank reports onto the report objects and remove the now-duplicate ToolTip from the W1 page actions that run them (Bank Account List, Check Ledger Entries, Direct Debit Collections, the Accountant / Accounting Manager / Bookkeeper / Finance Manager and Administrator role centers, and Data Administration). Reports: Bank Acc. - Detail Trial Bal., Bank Account - Check Details, Bank Account - Labels, Bank Account - List, Bank Account Register, Bank Account Statement, Create Direct Debit Collection, Date Compress Bank Acc. Ledger, Delete Check Ledger Entries. Where only a "Run the X report." stub existed (Bank Account - Labels, Bank Account Register) it is hoisted as the sole option. Metadata-only change (ToolTip); tooltip text unchanged for end users.
Integrate the W1 Bank tooltip move into the forked country layers, as required by the Miapp sync gate (VerifyMiappSync): - 64 page forks across 19 country layers: removed the duplicate ToolTip from the covered-report actions (148 lines; includes fork-specific tooltip wordings the report now carries canonically). - 5 report forks (APAC BankAccountLabels, CH CreateDirectDebitCollection, ES/GB BankAccountList, NA BankAccountCheckDetails): added the W1 report-level ToolTip. - 3 no-op integrations (FR AccountingManager/Bookkeeper, NA Accountant): the sync gate requires every fork of a changed W1 file in the changelist; these carry no covered action, so there is nothing to remove.
This PR moves ToolTip text from page actions onto the RunObject-targeted Report and deletes the (duplicated) ToolTip from the action.That is safe on Role Center pages, because Business Central 2025 release wave 1 makes actions on Role Centers inherit Caption/ToolTip/AboutText/AboutTitle from the targeted object's own properties when the action does not set them. However, the same ToolTip deletion was also applied to actions on regular List pages, where this RunObject inheritance does not apply (Microsoft's RunObject property documentation scopes the auto-inheritance explicitly to 'actions on role centers'). As a result, these actions now render with no hover tooltip and nothing for screen readers to announce: action("Detail Trial Balance"), action("Check Details"), action("List"), and action("Bank Account Statements") in src/Layers/W1/BaseApp/Bank/BankAccount/BankAccountList.Page.al (PageType = List), and the equivalent actions in the BE, ES, NA, and RU layer overrides of the same page; action("Delete Entries") in src/Layers/W1/BaseApp/Bank/Check/CheckLedgerEntries.Page.al and its RU override; action("Create Direct Debit Collection") in src/Layers/W1/BaseApp/Bank/DirectDebit/DirectDebitCollections.Page.al; and action("Date Compress Bank Acc. Ledger") in src/Layers/W1/BaseApp/System/DataAdministration/DataAdministration.Page.al. Recommendation:
Agent judgement — not directly backed by a BCQuality knowledge article. Line mapping was unavailable, so this was posted as an issue comment. 👍 useful · ❤️ especially valuable · 👎 wrong - reply with why |
Copilot PR ReviewIteration 1 · Outcome: completed Knowledge source: https://github.com/microsoft/BCQuality@186d8a131465475c79244d994acb872cd5c0d4bf Findings by domainFindings split into Knowledge-backed (cite a BCQuality article) and Agent (the agent's own judgement, no matching BCQuality rule).
Totals: 0 knowledge-backed · 1 agent findings. Orchestrator pre-filter (2 file(s) excluded)
Findings produced by the AL review agent v1.7.3. Reply 👎 on any inline comment to flag false positives. |
1 participant
What & why
Moves the report action ToolTips for the Bank reports off the page actions that run them and onto the report objects themselves, and integrates that move into every forked country layer. The tooltip is now defined once on the report and applies wherever the report is invoked, and the now-duplicate
ToolTipis removed from the page actions in W1 and its country forks.Reports covered (9):
Bank Acc. - Detail Trial Bal.,Bank Account - Check Details,Bank Account - Labels,Bank Account - List,Bank Account Register,Bank Account Statement,Create Direct Debit Collection,Date Compress Bank Acc. Ledger,Delete Check Ledger Entries.Where only a
Run the X report.stub existed for a report (Bank Account - Labels,Bank Account Register), it is hoisted as the sole option — happy to replace with better wording if a reviewer suggests it.This is part of the "move report action tooltips to report objects" cleanup (CP0529-331 / slice 636017).
Changes
ToolTipadded to the 9 reports; duplicate removed from the W1 actions that run them (BankAccountList,CheckLedgerEntries,DirectDebitCollections, the Accountant / Accounting Manager / Bookkeeper / Finance Manager and Administrator role centers, and Data Administration). 18 files.VerifyMiappSync):ToolTipremoved from the covered actions (includes fork-specific tooltip wordings that the report now carries canonically).APAC BankAccountLabels,CH CreateDirectDebitCollection,ES/GB BankAccountList,NA BankAccountCheckDetails): report-levelToolTipadded to match W1.FR AccountingManager/Bookkeeper,NA Accountant): the sync gate requires every fork of a changed W1 file in the changelist; these carry no covered action, so there is nothing to remove.Total: 90 files (18 W1 + 72 country), tooltip-only.
Linked work
Fixes AB#636017
How I validated this
What I tested and the outcome
Metadata-only change (
ToolTipproperty). The diff is tooltip-only (reportToolTipadditions + page-actionToolTipremovals), with BOM/EOL preserved; the only non-tooltip edits are trailing-newline no-op sync touches on three role-center forks. Country propagation was produced by runningInvoke-Miappto identify the fork set, then applying the move surgically (Invoke-Miapp's auto-merge mis-aligned on the structurally-divergent role centers, so its output was not used directly). The set of changed forks matches exactly whatVerifyMiappSyncrequires — no missing forks, no extras.No tests added:
ToolTipis a design-time metadata property with no runtime behavior to assert; there is no existing tooltip test harness for these objects.Risk & compatibility
Low. No code, schema, table, or behavior change — only the
ToolTipdesign property moves from page action to report, in W1 and its country forks. No upgrade/data impact, no permission/telemetry impact, no breaking change. Same cleanup pattern already merged for Warehouse, Manufacturing, Service, Sales and Inventory, landed as the Pricing pilot (#9433), and applied to CashFlow (#9528) and Finance (#9526) on the new BCApps pipeline.