argo_workflows: add container-based config discovery support#24512
Draft
vitkyrka wants to merge 3 commits into
Draft
argo_workflows: add container-based config discovery support#24512vitkyrka wants to merge 3 commits into
vitkyrka wants to merge 3 commits into
Conversation
vitkyrka
added a commit
that referenced
this pull request
Jul 10, 2026
Also rename the inherited keda-discovery changelog entries (keda/changelog.d, datadog_checks_dev/changelog.d) to this PR's number, since they were carried over from the unmerged base branch and the changelog validator flags them against this PR otherwise. Environment: Datadog workspace Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Contributor
🎉 All green!🧪 All tests passed 🎯 Code Coverage (details) 🔗 Commit SHA: e5340cc | Docs | Datadog PR Page | Give us feedback! |
vitkyrka
changed the base branch from
vwhitchurch/keda-discovery
to
graphite-base/24512
July 15, 2026 10:57
vitkyrka
force-pushed
the
vwhitchurch/argo_workflows-discovery
branch
from
July 15, 2026 10:57
5c4f0bc to
2552737
Compare
vitkyrka
force-pushed
the
graphite-base/24512
branch
from
July 15, 2026 10:57
2c0dc75 to
3b1ed7c
Compare
vitkyrka
changed the base branch from
graphite-base/24512
to
vwhitchurch/velero-discovery
July 15, 2026 10:57
3 tasks
Contributor
Author
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
This was referenced Jul 15, 2026
vitkyrka
force-pushed
the
vwhitchurch/argo_workflows-discovery
branch
from
July 15, 2026 13:26
2552737 to
9f91003
Compare
This was referenced Jul 15, 2026
Add a from_ports discovery strategy scoped to the workflow-controller Deployment (port 9090), wire the kind-based E2E fixture to the new kube_discovery helpers, and add discovery E2E tests. Environment: Datadog workspace Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
vitkyrka
force-pushed
the
vwhitchurch/argo_workflows-discovery
branch
from
July 16, 2026 08:51
9f91003 to
e5340cc
Compare
vitkyrka
force-pushed
the
vwhitchurch/velero-discovery
branch
from
July 16, 2026 08:51
7e04aa5 to
c2e0447
Compare
3 tasks
Contributor
Validation ReportAll 21 validations passed. Show details
|
3 tasks
vitkyrka
changed the base branch from
vwhitchurch/velero-discovery
to
graphite-base/24512
July 16, 2026 13:09
This was referenced Jul 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

What does this PR do?
Adds Kubernetes container-based config discovery support to argo_workflows.
The port is taken from the
metricsnamed container port.The AD identifier
workflow-controlleris a generic name that could be used by something even not from Argo, so we use a CEL selector to narrow the image reference further down to something that containsargoproj/workflow-controller.Motivation
https://datadoghq.atlassian.net/browse/DSCVR-530
Review checklist (to be filled by reviewers)
qa/requiredif this PR needs QA validation, orqa/skip-qaif it does not. Exactly one of the two is required.backport/<branch-name>label to the PR and it will automatically open a backport PR once this one is merged