Skip to content

argo_workflows: add container-based config discovery support#24512

Draft
vitkyrka wants to merge 3 commits into
graphite-base/24512from
vwhitchurch/argo_workflows-discovery
Draft

argo_workflows: add container-based config discovery support#24512
vitkyrka wants to merge 3 commits into
graphite-base/24512from
vwhitchurch/argo_workflows-discovery

Conversation

@vitkyrka

@vitkyrka vitkyrka commented Jul 10, 2026

Copy link
Copy Markdown
Contributor

What does this PR do?

Adds Kubernetes container-based config discovery support to argo_workflows.

The port is taken from the metrics named container port.

The AD identifier workflow-controller is a generic name that could be used by something even not from Argo, so we use a CEL selector to narrow the image reference further down to something that contains argoproj/workflow-controller.

Motivation

https://datadoghq.atlassian.net/browse/DSCVR-530

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Add qa/required if this PR needs QA validation, or qa/skip-qa if it does not. Exactly one of the two is required.
  • If you need to backport this PR to another branch, you can add the backport/<branch-name> label to the PR and it will automatically open a backport PR once this one is merged

@vitkyrka vitkyrka added the qa/skip-qa Automatically skip this PR for the next QA label Jul 10, 2026 — with ddtool CLI
vitkyrka added a commit that referenced this pull request Jul 10, 2026
Also rename the inherited keda-discovery changelog entries
(keda/changelog.d, datadog_checks_dev/changelog.d) to this PR's
number, since they were carried over from the unmerged base branch
and the changelog validator flags them against this PR otherwise.

Environment: Datadog workspace

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
@datadog-datadog-prod-us1

datadog-datadog-prod-us1 Bot commented Jul 10, 2026

Copy link
Copy Markdown
Contributor

Tests  Code Coverage

🎉 All green!

🧪 All tests passed
❄️ No new flaky tests detected

🎯 Code Coverage (details)
Patch Coverage: 50.00%
Overall Coverage: 69.89% (-18.54%)

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: e5340cc | Docs | Datadog PR Page | Give us feedback!

@vitkyrka
vitkyrka changed the base branch from master to vwhitchurch/keda-discovery July 10, 2026 22:07
@vitkyrka
vitkyrka changed the base branch from vwhitchurch/keda-discovery to graphite-base/24512 July 15, 2026 10:57
@vitkyrka
vitkyrka force-pushed the vwhitchurch/argo_workflows-discovery branch from 5c4f0bc to 2552737 Compare July 15, 2026 10:57
@vitkyrka
vitkyrka force-pushed the graphite-base/24512 branch from 2c0dc75 to 3b1ed7c Compare July 15, 2026 10:57
@vitkyrka
vitkyrka changed the base branch from graphite-base/24512 to vwhitchurch/velero-discovery July 15, 2026 10:57

vitkyrka commented Jul 15, 2026

Copy link
Copy Markdown
Contributor Author

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

vitkyrka and others added 3 commits July 16, 2026 08:07
Add a from_ports discovery strategy scoped to the workflow-controller
Deployment (port 9090), wire the kind-based E2E fixture to the new
kube_discovery helpers, and add discovery E2E tests.

Environment: Datadog workspace

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
@vitkyrka
vitkyrka force-pushed the vwhitchurch/argo_workflows-discovery branch from 9f91003 to e5340cc Compare July 16, 2026 08:51
@dd-octo-sts

dd-octo-sts Bot commented Jul 16, 2026

Copy link
Copy Markdown
Contributor

Validation Report

All 21 validations passed.

Show details
Validation Description Status
agent-reqs Verify check versions match the Agent requirements file
ci Validate CI configuration and code coverage settings
codeowners Validate every integration has a CODEOWNERS entry
config Validate default configuration files against spec.yaml
dep Verify dependency pins are consistent and Agent-compatible
http Validate integrations use the HTTP wrapper correctly
imports Validate check imports do not use deprecated modules
integration-style Validate check code style conventions
jmx-metrics Validate JMX metrics definition files and config
labeler Validate PR labeler config matches integration directories
legacy-signature Validate no integration uses the legacy Agent check signature
license-headers Validate Python files have proper license headers
licenses Validate third-party license attribution list
metadata Validate metadata.csv metric definitions
models Validate configuration data models match spec.yaml
openmetrics Validate OpenMetrics integrations disable the metric limit
package Validate Python package metadata and naming
qa-label Validate the pull request declares whether it needs QA for the next Agent release
readmes Validate README files have required sections
saved-views Validate saved view JSON file structure and fields
version Validate version consistency between package and changelog

View full run

@vitkyrka
vitkyrka changed the base branch from vwhitchurch/velero-discovery to graphite-base/24512 July 16, 2026 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant