Skip to content

weaviate: add container-based config discovery support#24519

Draft
vitkyrka wants to merge 1 commit into
graphite-base/24519from
vwhitchurch/weaviate-discovery
Draft

weaviate: add container-based config discovery support#24519
vitkyrka wants to merge 1 commit into
graphite-base/24519from
vwhitchurch/weaviate-discovery

Conversation

@vitkyrka

@vitkyrka vitkyrka commented Jul 10, 2026

Copy link
Copy Markdown
Contributor

What does this PR do?

Adds container-based config discovery support to Weaviate.

The discovery config uses the standard named-port OpenMetrics strategy (discovery/openmetrics_from_named_ports). The template defaults to the metrics port name, which maps to Weaviate's Prometheus metrics container port (2112) in the Kind fixture, so no numeric port hint or integration-specific port-name override is needed.

Discovery currently intentionally only configures openmetrics_endpoint since this is the one identifiable via the named port. It does not populate the optionalweaviate_api_endpoint, so discovered instances collect OpenMetrics metrics only.

Motivation

DSCVR-544

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Add qa/required if this PR needs QA validation, or qa/skip-qa if it does not. Exactly one of the two is required.
  • If you need to backport this PR to another branch, you can add the backport/<branch-name> label to the PR and it will automatically open a backport PR once this one is merged

@vitkyrka vitkyrka added the qa/skip-qa Automatically skip this PR for the next QA label Jul 10, 2026
vitkyrka added a commit that referenced this pull request Jul 10, 2026
Environment: Datadog workspace

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
@datadog-prod-us1-4

datadog-prod-us1-4 Bot commented Jul 10, 2026

Copy link
Copy Markdown
Contributor

Tests  Code Coverage

🎉 All green!

🧪 All tests passed
❄️ No new flaky tests detected

🎯 Code Coverage (details)
Patch Coverage: 50.00%
Overall Coverage: 76.04% (-12.40%)

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 8ce2ddd | Docs | Datadog PR Page | Give us feedback!

@vitkyrka
vitkyrka changed the base branch from vwhitchurch/keda-discovery to graphite-base/24519 July 15, 2026 13:26
vitkyrka added a commit that referenced this pull request Jul 15, 2026
Environment: Datadog workspace

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
@vitkyrka
vitkyrka force-pushed the vwhitchurch/weaviate-discovery branch from 0c78349 to 92ec948 Compare July 15, 2026 13:26
@vitkyrka
vitkyrka force-pushed the graphite-base/24519 branch from 2c0dc75 to 7e04aa5 Compare July 15, 2026 13:26
@vitkyrka
vitkyrka changed the base branch from graphite-base/24519 to vwhitchurch/velero-discovery July 15, 2026 13:27

vitkyrka commented Jul 15, 2026

Copy link
Copy Markdown
Contributor Author

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

@vitkyrka
vitkyrka changed the base branch from vwhitchurch/velero-discovery to graphite-base/24519 July 16, 2026 08:51
@vitkyrka
vitkyrka force-pushed the vwhitchurch/weaviate-discovery branch from 92ec948 to 1bd4f19 Compare July 16, 2026 09:01
vitkyrka added a commit that referenced this pull request Jul 16, 2026
Environment: Datadog workspace

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
@vitkyrka
vitkyrka force-pushed the graphite-base/24519 branch from 7e04aa5 to c2e0447 Compare July 16, 2026 09:01
@vitkyrka
vitkyrka changed the base branch from graphite-base/24519 to vwhitchurch/velero-discovery July 16, 2026 09:01
Adds a `from_ports`-based discovery strategy scoped to weaviate's OpenMetrics
port (2112) and wires the kind-based E2E harness to exercise it against a
real Kubernetes cluster via the new kube_discovery helpers.

Environment: Datadog workspace

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
@vitkyrka
vitkyrka force-pushed the vwhitchurch/weaviate-discovery branch from 1bd4f19 to 8ce2ddd Compare July 16, 2026 12:08
@dd-octo-sts

dd-octo-sts Bot commented Jul 16, 2026

Copy link
Copy Markdown
Contributor

Validation Report

All 21 validations passed.

Show details
Validation Description Status
agent-reqs Verify check versions match the Agent requirements file
ci Validate CI configuration and code coverage settings
codeowners Validate every integration has a CODEOWNERS entry
config Validate default configuration files against spec.yaml
dep Verify dependency pins are consistent and Agent-compatible
http Validate integrations use the HTTP wrapper correctly
imports Validate check imports do not use deprecated modules
integration-style Validate check code style conventions
jmx-metrics Validate JMX metrics definition files and config
labeler Validate PR labeler config matches integration directories
legacy-signature Validate no integration uses the legacy Agent check signature
license-headers Validate Python files have proper license headers
licenses Validate third-party license attribution list
metadata Validate metadata.csv metric definitions
models Validate configuration data models match spec.yaml
openmetrics Validate OpenMetrics integrations disable the metric limit
package Validate Python package metadata and naming
qa-label Validate the pull request declares whether it needs QA for the next Agent release
readmes Validate README files have required sections
saved-views Validate saved view JSON file structure and fields
version Validate version consistency between package and changelog

View full run

@vitkyrka
vitkyrka changed the base branch from vwhitchurch/velero-discovery to graphite-base/24519 July 16, 2026 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation integration/weaviate qa/skip-qa Automatically skip this PR for the next QA

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant