argocd: add container-based config discovery support#24624
Draft
vitkyrka wants to merge 7 commits into
Draft
Conversation
Contributor
Author
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
🎉 All green!🧪 All tests passed 🎯 Code Coverage (details) 🔗 Commit SHA: 2afee3e | Docs | Datadog PR Page | Give us feedback! |
3 tasks
Contributor
Validation ReportAll 21 validations passed. Show details
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

What does this PR do?
Adds container-based config discovery support to argocd.
Discovery strategy: Argo CD uses shared
quay.io/argoproj/argocdimages across roles, so this PR uses a local discovery strategy that reads the container'skube_app_nametag and emits only that role's metrics endpoint. Thekube_app_nametags comes from theapp.kubernetes.io/namelabel set by the official Argo CD installation manifest.Port selection rationale: The default metrics service ports match the official installation manifest. The optional Source Hydrator commit server is not deployed by that default install manifest; its endpoint comes from Argo CD's official metrics docs.
Motivation
https://datadoghq.atlassian.net/browse/DSCVR-484
Review checklist (to be filled by reviewers)
qa/requiredif this PR needs QA validation, orqa/skip-qaif it does not. Exactly one of the two is required.backport/<branch-name>label to the PR and it will automatically open a backport PR once this one is merged