Skip to content

argocd: add container-based config discovery support#24624

Draft
vitkyrka wants to merge 7 commits into
vwhitchurch/velero-discoveryfrom
vwhitchurch/argocd-discovery
Draft

argocd: add container-based config discovery support#24624
vitkyrka wants to merge 7 commits into
vwhitchurch/velero-discoveryfrom
vwhitchurch/argocd-discovery

Conversation

@vitkyrka

@vitkyrka vitkyrka commented Jul 21, 2026

Copy link
Copy Markdown
Contributor

What does this PR do?

Adds container-based config discovery support to argocd.

Discovery strategy: Argo CD uses shared quay.io/argoproj/argocd images across roles, so this PR uses a local discovery strategy that reads the container'skube_app_name tag and emits only that role's metrics endpoint. The kube_app_name tags comes from the app.kubernetes.io/name label set by the official Argo CD installation manifest.

Port selection rationale: The default metrics service ports match the official installation manifest. The optional Source Hydrator commit server is not deployed by that default install manifest; its endpoint comes from Argo CD's official metrics docs.

Motivation

https://datadoghq.atlassian.net/browse/DSCVR-484

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Add qa/required if this PR needs QA validation, or qa/skip-qa if it does not. Exactly one of the two is required.
  • If you need to backport this PR to another branch, you can add the backport/<branch-name> label to the PR and it will automatically open a backport PR once this one is merged

Copy link
Copy Markdown
Contributor Author

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

@datadog-prod-us1-3

datadog-prod-us1-3 Bot commented Jul 21, 2026

Copy link
Copy Markdown

Tests  Code Coverage

🎉 All green!

🧪 All tests passed
❄️ No new flaky tests detected

🎯 Code Coverage (details)
Patch Coverage: 88.51%
Overall Coverage: 92.37% (+3.90%)

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 2afee3e | Docs | Datadog PR Page | Give us feedback!

@vitkyrka vitkyrka added the qa/skip-qa Automatically skip this PR for the next QA label Jul 21, 2026 — with ddtool CLI
@vitkyrka vitkyrka changed the title Add Argo CD Kubernetes discovery argocd: add container-based config discovery support Jul 21, 2026
@steveny91 steveny91 added the assets/no-deploy Prevents APW from deploying this PR in staging label Jul 22, 2026
@dd-octo-sts

dd-octo-sts Bot commented Jul 22, 2026

Copy link
Copy Markdown
Contributor

Validation Report

All 21 validations passed.

Show details
Validation Description Status
agent-reqs Verify check versions match the Agent requirements file
ci Validate CI configuration and code coverage settings
codeowners Validate every integration has a CODEOWNERS entry
config Validate default configuration files against spec.yaml
dep Verify dependency pins are consistent and Agent-compatible
http Validate integrations use the HTTP wrapper correctly
imports Validate check imports do not use deprecated modules
integration-style Validate check code style conventions
jmx-metrics Validate JMX metrics definition files and config
labeler Validate PR labeler config matches integration directories
legacy-signature Validate no integration uses the legacy Agent check signature
license-headers Validate Python files have proper license headers
licenses Validate third-party license attribution list
metadata Validate metadata.csv metric definitions
models Validate configuration data models match spec.yaml
openmetrics Validate OpenMetrics integrations disable the metric limit
package Validate Python package metadata and naming
qa-label Validate the pull request declares whether it needs QA for the next Agent release
readmes Validate README files have required sections
saved-views Validate saved view JSON file structure and fields
version Validate version consistency between package and changelog

View full run

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

assets/no-deploy Prevents APW from deploying this PR in staging documentation integration/argocd qa/skip-qa Automatically skip this PR for the next QA

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants