Skip to content

keda: add container-based config discovery support#24459

Draft
vitkyrka wants to merge 1 commit into
vwhitchurch/velero-discoveryfrom
vwhitchurch/keda-discovery
Draft

keda: add container-based config discovery support#24459
vitkyrka wants to merge 1 commit into
vwhitchurch/velero-discoveryfrom
vwhitchurch/keda-discovery

Conversation

@vitkyrka

@vitkyrka vitkyrka commented Jul 9, 2026

Copy link
Copy Markdown
Contributor

What does this PR do?

Adds container-based config discovery support to KEDA.

The discovery config uses the standard named-port OpenMetrics strategy (discovery/openmetrics_from_named_ports). The template defaults to the metrics port name, which maps to KEDA's Prometheus metrics container port.

Discovery covers the three KEDA component images exposed by the chart: keda, keda-metrics-apiserver, and keda-admission-webhooks. Each discovered instance configures openmetrics_endpoint from the pod IP and metrics named port.

Motivation

https://datadoghq.atlassian.net/browse/DSCVR-517

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Add qa/required if this PR needs QA validation, or qa/skip-qa if it does not. Exactly one of the two is required.
  • If you need to backport this PR to another branch, you can add the backport/<branch-name> label to the PR and it will automatically open a backport PR once this one is merged

@vitkyrka vitkyrka added the qa/skip-qa Automatically skip this PR for the next QA label Jul 9, 2026
vitkyrka added a commit that referenced this pull request Jul 9, 2026
Environment: Datadog workspace

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
@datadog-datadog-us1-prod

datadog-datadog-us1-prod Bot commented Jul 9, 2026

Copy link
Copy Markdown

Tests  Code Coverage

🎉 All green!

🧪 All tests passed
❄️ No new flaky tests detected

🎯 Code Coverage (details)
Patch Coverage: 50.00%
Overall Coverage: 86.96% (-1.52%)

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: ade09a4 | Docs | Datadog PR Page | Give us feedback!

vitkyrka added a commit that referenced this pull request Jul 10, 2026
Environment: Datadog workspace

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
vitkyrka added a commit that referenced this pull request Jul 10, 2026
Environment: Datadog workspace

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>

Co-authored-by: Vincent Whitchurch <vincent.whitchurch@datadoghq.com>
vitkyrka added a commit that referenced this pull request Jul 10, 2026
Environment: Datadog workspace

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>

Co-authored-by: Vincent Whitchurch <vincent.whitchurch@datadoghq.com>
vitkyrka added a commit that referenced this pull request Jul 10, 2026
This branch is based on the not-yet-merged vwhitchurch/keda-discovery
branch, so its own changelog.d entries (numbered for PR #24459) show up
in this PR's diff against master. CI's changelog check requires any
non-deleted changelog.d entry in the diff to bear the current PR's
number, so rename them to #24507 here; they will be superseded once
#24459 merges and this branch is rebased onto master.

Environment: Datadog workspace

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
vitkyrka added a commit that referenced this pull request Jul 14, 2026
This branch is based on the not-yet-merged vwhitchurch/keda-discovery
branch, so its own changelog.d entries (numbered for PR #24459) show up
in this PR's diff against master. CI's changelog check requires any
non-deleted changelog.d entry in the diff to bear the current PR's
number, so rename them to #24507 here; they will be superseded once

Environment: Datadog workspace

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
@vitkyrka
vitkyrka force-pushed the vwhitchurch/keda-discovery branch from 1f0cb65 to b12afcc Compare July 17, 2026 13:36
@vitkyrka
vitkyrka force-pushed the vwhitchurch/keda-discovery branch from b12afcc to d43155c Compare July 17, 2026 13:48
@vitkyrka
vitkyrka changed the base branch from master to graphite-base/24459 July 17, 2026 13:48
@vitkyrka
vitkyrka force-pushed the graphite-base/24459 branch from 9d36bc6 to e183434 Compare July 17, 2026 13:48
@vitkyrka
vitkyrka changed the base branch from graphite-base/24459 to vwhitchurch/velero-discovery July 17, 2026 13:48

vitkyrka commented Jul 17, 2026

Copy link
Copy Markdown
Contributor Author

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

Add a discovery strategy and auto_conf.yaml for keda.

Environment: Datadog workspace

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
@dd-octo-sts

dd-octo-sts Bot commented Jul 17, 2026

Copy link
Copy Markdown
Contributor

Validation Report

Validation Description Status
license-headers Validate Python files have proper license headers

Run ddev validate all changed --fix to attempt to auto-fix supported validations.

Passed validations (20)
Validation Description Status
agent-reqs Verify check versions match the Agent requirements file
ci Validate CI configuration and code coverage settings
codeowners Validate every integration has a CODEOWNERS entry
config Validate default configuration files against spec.yaml
dep Verify dependency pins are consistent and Agent-compatible
http Validate integrations use the HTTP wrapper correctly
imports Validate check imports do not use deprecated modules
integration-style Validate check code style conventions
jmx-metrics Validate JMX metrics definition files and config
labeler Validate PR labeler config matches integration directories
legacy-signature Validate no integration uses the legacy Agent check signature
licenses Validate third-party license attribution list
metadata Validate metadata.csv metric definitions
models Validate configuration data models match spec.yaml
openmetrics Validate OpenMetrics integrations disable the metric limit
package Validate Python package metadata and naming
qa-label Validate the pull request declares whether it needs QA for the next Agent release
readmes Validate README files have required sections
saved-views Validate saved view JSON file structure and fields
version Validate version consistency between package and changelog

View full run

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant