Skip to content

kuma: add container-based config discovery support#24522

Draft
vitkyrka wants to merge 1 commit into
graphite-base/24522from
vwhitchurch/kuma-discovery
Draft

kuma: add container-based config discovery support#24522
vitkyrka wants to merge 1 commit into
graphite-base/24522from
vwhitchurch/kuma-discovery

Conversation

@vitkyrka

@vitkyrka vitkyrka commented Jul 10, 2026

Copy link
Copy Markdown
Contributor

What does this PR do?

Adds container-based config discovery support to Kuma.

The OpenMetrics ports is identified via the diagnostics named port.

Motivation

DSCVR-558

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Add qa/required if this PR needs QA validation, or qa/skip-qa if it does not. Exactly one of the two is required.
  • If you need to backport this PR to another branch, you can add the backport/<branch-name> label to the PR and it will automatically open a backport PR once this one is merged

@vitkyrka vitkyrka added the qa/skip-qa Automatically skip this PR for the next QA label Jul 10, 2026 — with ddtool CLI
@dd-octo-sts dd-octo-sts Bot added documentation integration/kuma and removed qa/skip-qa Automatically skip this PR for the next QA labels Jul 10, 2026
vitkyrka added a commit that referenced this pull request Jul 10, 2026
Environment: Datadog workspace

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
@datadog-prod-us1-5

datadog-prod-us1-5 Bot commented Jul 10, 2026

Copy link
Copy Markdown

Tests  Code Coverage

🎉 All green!

🧪 All tests passed
❄️ No new flaky tests detected

🎯 Code Coverage (details)
Patch Coverage: 50.00%
Overall Coverage: 78.72% (-9.71%)

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: a8b2d11 | Docs | Datadog PR Page | Give us feedback!

@vitkyrka vitkyrka added the qa/skip-qa Automatically skip this PR for the next QA label Jul 10, 2026 — with ddtool CLI
@vitkyrka
vitkyrka marked this pull request as ready for review July 10, 2026 23:32
@vitkyrka
vitkyrka requested review from a team as code owners July 10, 2026 23:32
@vitkyrka
vitkyrka marked this pull request as draft July 11, 2026 02:53
Add a from_ports (openmetrics_from_ports template) discovery strategy and
auto_conf.yaml for the kuma-control-plane Deployment's diagnostics/metrics
port (5680, declared as a containerPort on the pod spec) so the Agent's
Kubernetes Autodiscovery listener can automatically generate an
openmetrics_endpoint configuration for it, and wire the kind-based E2E test
harness up to the new Kubernetes discovery e2e helpers
(setup_discovery_agent/save_kube_discovery_state/run_discovery_check_kubernetes/
assert_all_discovery_candidates_stable_kubernetes).

Environment: Datadog workspace

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
@vitkyrka
vitkyrka changed the base branch from vwhitchurch/keda-discovery to graphite-base/24522 July 16, 2026 12:46
@vitkyrka
vitkyrka force-pushed the graphite-base/24522 branch from 2c0dc75 to c2e0447 Compare July 16, 2026 12:46
@vitkyrka
vitkyrka force-pushed the vwhitchurch/kuma-discovery branch from 935ecfb to a8b2d11 Compare July 16, 2026 12:46
@vitkyrka
vitkyrka changed the base branch from graphite-base/24522 to vwhitchurch/velero-discovery July 16, 2026 12:46

vitkyrka commented Jul 16, 2026

Copy link
Copy Markdown
Contributor Author

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

@dd-octo-sts

dd-octo-sts Bot commented Jul 16, 2026

Copy link
Copy Markdown
Contributor

Validation Report

Validation Description Status
license-headers Validate Python files have proper license headers

Run ddev validate all changed --fix to attempt to auto-fix supported validations.

Passed validations (20)
Validation Description Status
agent-reqs Verify check versions match the Agent requirements file
ci Validate CI configuration and code coverage settings
codeowners Validate every integration has a CODEOWNERS entry
config Validate default configuration files against spec.yaml
dep Verify dependency pins are consistent and Agent-compatible
http Validate integrations use the HTTP wrapper correctly
imports Validate check imports do not use deprecated modules
integration-style Validate check code style conventions
jmx-metrics Validate JMX metrics definition files and config
labeler Validate PR labeler config matches integration directories
legacy-signature Validate no integration uses the legacy Agent check signature
licenses Validate third-party license attribution list
metadata Validate metadata.csv metric definitions
models Validate configuration data models match spec.yaml
openmetrics Validate OpenMetrics integrations disable the metric limit
package Validate Python package metadata and naming
qa-label Validate the pull request declares whether it needs QA for the next Agent release
readmes Validate README files have required sections
saved-views Validate saved view JSON file structure and fields
version Validate version consistency between package and changelog

View full run

@vitkyrka
vitkyrka changed the base branch from vwhitchurch/velero-discovery to graphite-base/24522 July 16, 2026 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant