feat(client): close the 9 metadata-family REST gaps (#3587 batch 1/5) - #3625
Merged
Conversation
Seven new meta methods, each URL-pinned in client.test.ts: getDiagnostics (spec-validation sweep), getReferences (reverse refs), getBookTree (ADR-0046 §6), getAudit (ADR-0010 §3.6 protection trail), publishItem / rollbackItem / diffItem (ADR-0033 per-item lifecycle). The two compound-name routes (GET|PUT /meta/:type/:section/:name) were already expressible — getItem/saveItem pass slashes through unencoded; the audit note claiming an encoding barrier described deleteItem, not them. Flipped to sdk with pinning tests locking the pass-through instead of adding methods. Ledger: 9 metadata rows gap→sdk; ratchet 43→34. client-sdk.mdx meta section updated (11→18 methods + examples). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01LX9ut3MK3KykE11S9bJmv5
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
Contributor
📓 Docs Drift CheckThis PR changes 2 package(s): 18 hand-written doc(s) reference the affected code and may need an implementation-accuracy re-verification:
|
os-zhuang
marked this pull request as ready for review
July 27, 2026 10:58
This was referenced Jul 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First of five batches closing the 43 REST↔client gaps the #3587 ledger carries (the REST-surface sibling of the dispatcher tranche #3569…#3579). This batch: the metadata family, 9 gaps → 0.
Seven new
client.metamethodsEach speaks the exact wire shape its
rest-server.tshandler mounts, and each is URL-pinned inclient.test.ts:getDiagnostics({type?, severity?, packageId?})GET /meta/diagnosticsgetReferences(type, name)GET /meta/:type/:name/referencesgetBookTree(name, {packageId?})GET /meta/book/:name/treegetAudit(type, name, {limit?})GET /meta/:type/:name/auditpublishItem(type, name, {message?})POST /meta/:type/:name/publishrollbackItem(type, name, toVersion, {message?})POST /meta/:type/:name/rollbackdiffItem(type, name, {from?, to?})GET /meta/:type/:name/diffThe two compound-name rows needed no new methods
The audit note claimed
meta.getItemURL-encodes the slash and so cannot reachGET|PUT /meta/:type/:section/:name. Re-verified against the source: that's wrong —getItem/saveIteminterpolate names unencoded (onlydeleteItemencodes), sogetItem('object', 'views/all_leads')already lands on the compound handler. Those two rows flip tosdkwith a pinning test locking the unencoded pass-through (the property the wrong note shows nothing guarded), and the note is corrected.Ledger & guard
gap→sdk; the two-sided conformance guard (rest + client halves) now proves each named method exists.client-sdk.mdx: meta namespace 11 → 18 methods, examples added for the lifecycle/introspection calls.Verification
@objectstack/client: 138/138 (+8 URL-pinning tests), baretscclean.@objectstack/rest: 394/394 (ledger guard green at the new ratchet).Remaining batches: reports 8, approvals 6 + record-shares 3, sharing-rules 5 + security-explain 2 + search 1, external-datasource 5 + data-actions 2 + email 1 + analytics 1.
🤖 Generated with Claude Code
https://claude.ai/code/session_01LX9ut3MK3KykE11S9bJmv5
Generated by Claude Code