feat(client): close the final 17 REST gaps — ratchet 17→0 (#3587 batches 4+5/5) - #3633
Merged
Merged
Conversation
…hes 4+5/5)
Batch 4 — sharing-rules 5 + security-explain 2 + search 1:
shares.rules.{list,save,get,delete,evaluate} administer tenant-wide
sharing rules (M10.17; delete 204-safe, grants cascade).
security.explain speaks the ADR-0090 D6 ExplainRequestSchema contract
via the POST transport (the GET query form is the same contract — both
ledger rows point at it). Top-level client.search covers global
cross-object search (M10.5).
Batch 5 — data-actions 2 + email 1 + analytics 1 + external-datasource 5:
data.clone (enable.clone duplication, overrides nested), data.export
(streaming CSV/JSON/XLSX; returns the raw Response — a file stream, not
a JSON envelope, and the ledger row says so), email.send (IEmailService;
branch on returned status), analytics.queryDataset (ADR-0021 REST
dataset-query dialect, distinct from query's dispatcher dialect), and
datasources.external.{listTables,draft,import,refreshCatalog,validate}
(ADR-0015 Addendum federation admin, 503-degrading direct-mounts).
Every REST route is now either SDK-expressed or carries a reviewed
non-sdk disposition; the ratchet rests at ZERO and stays there. Docs:
client-sdk.mdx surface table updated (data 12, analytics 4, security 4,
shares 8 + email/datasources/search rows).
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01LX9ut3MK3KykE11S9bJmv5
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
Contributor
📓 Docs Drift CheckThis PR changes 2 package(s): 18 hand-written doc(s) reference the affected code and may need an implementation-accuracy re-verification:
|
os-zhuang
marked this pull request as ready for review
July 27, 2026 11:27
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The closing act of the #3587 gap backlog. Batches 1–3 (#3625, #3626, #3629) took the ledger 43 → 17; this PR closes the remaining 17 across two batches and rests the ratchet at ZERO — every REST route is now either SDK-expressed or carries a reviewed non-sdk disposition, with the two-sided conformance guard holding the line.
Batch 4 — sharing-rules 5 + security-explain 2 + search 1
shares.rules.list({object?, activeOnly?})GET /sharing/rulesshares.rules.save(rule)POST /sharing/rules[VALIDATION_FAILED]shares.rules.get(idOrName)GET /sharing/rules/:idOrName[RULE_NOT_FOUND]shares.rules.delete(idOrName)DELETE /sharing/rules/:idOrNameshares.rules.evaluate(idOrName)POST /sharing/rules/:idOrName/evaluatesecurity.explain(request)POST /security/explainExplainRequestSchemacontract, two transportssearch(q, {objects?, limit?, perObject?})GET /searchBatch 5 — data-actions 2 + email 1 + analytics 1 + external-datasource 5
data.clone(object, id, overrides?)POST /data/:object/:id/cloneenable.clone; overrides nesteddata.export(object, opts?)GET /data/:object/exportResponse— a file stream (CSV/JSON/XLSX attachment), not a JSON envelope; the ledger row documents thisemail.send(message)POST /email/sendstatusanalytics.queryDataset(payload)POST /analytics/dataset/queryanalytics.query's dispatcher dialectdatasources.external.listTables/draft/import/refreshCatalog/validate/datasources/:name/external/…Ledger
gap→sdk(including the two direct-mount external-datasource rows the mock-server enumeration guards).gaprow demands an explicit, reviewed decision.client-sdk.mdxsurface table updated: data 12, analytics 4, security 4, shares 8, plusemail/datasources/searchrows.Verification
@objectstack/client: 163/163 (+10 URL-pinning tests across the two batches), baretscclean.@objectstack/rest: 394/394 (guard green at ratchet 0).🤖 Generated with Claude Code
https://claude.ai/code/session_01LX9ut3MK3KykE11S9bJmv5
Generated by Claude Code