feat(client): close the approvals (6) + record-shares (3) REST gaps (#3587 batch 3/5) - #3629
Merged
Merged
Conversation
…3587 batch 3/5) client.approvals gains the full request lifecycle beyond approve/reject: recall (submitter withdraw), revise / resubmit (the ADR-0044 send-back round-trip, both flow-moving), and the thread interactions remind / requestInfo / comment (comment carries attachments). Bodies follow the decision-route convention ({ actorId?, comment? }; the server defaults actor to the authenticated user). New client.shares namespace for per-record sharing grants under the data surface: list / grant / revoke on /data/:object/:id/shares (revoke is 204-safe). 501s cleanly without the sharing service. Each method URL-pinned in client.test.ts. Ledger: 9 rows gap→sdk; ratchet 26→17. client-sdk.mdx: shares row added and the previously missing approvals row documented (12 methods). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01LX9ut3MK3KykE11S9bJmv5
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
github-actions
Bot
added
documentation
Contributor
📓 Docs Drift CheckThis PR changes 2 package(s): 18 hand-written doc(s) reference the affected code and may need an implementation-accuracy re-verification:
|
os-zhuang
marked this pull request as ready for review
July 27, 2026 11:18
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Third of five batches closing the 43 REST↔client gaps the #3587 ledger carries. Batches 1–2 (metadata #3625, reports #3626) are merged; this batch: approvals 6 + record-shares 3 → 0. Ratchet 26 → 17.
client.approvals— the lifecycle beyond approve/rejectSix new methods, matching the decision-route body convention (
{ actorId?, comment? }, actor defaulting server-side to the authenticated user):recall(id, opts?)POST /approvals/requests/:id/recallrevise(id, opts?)POST /approvals/requests/:id/revisereturned, run parksresubmit(id, opts?)POST /approvals/requests/:id/resubmitresumed/autoRejectedverbatimremind(id, opts?)POST /approvals/requests/:id/remindrequestInfo(id, opts?)POST /approvals/requests/:id/request-infocomment(id, {comment, attachments?})POST /approvals/requests/:id/commentNew
client.shares— per-record sharing grantslist(object, recordId)/grant(object, recordId, {recipientType, recipientId, accessLevel, …})/revoke(object, recordId, shareId)on/data/:object/:id/shares, resolved via the discovereddataroute.revokeis 204-safe (same empty-body guard the reports batch established). 501[NOT_IMPLEMENTED]without the sharing service.Ledger & docs
gap→sdk; ratchet comment updated (remaining: data-actions 2, search 1, email 1, analytics 1, security-explain 2, sharing-rules 5, external-datasource 5).client-sdk.mdx:sharesrow added, and the previously missingapprovalsrow documented (12 methods).Verification
@objectstack/client: 153/153 (+9 URL-pinning tests, incl. a parameterized five-route pin), baretscclean.@objectstack/rest: 394/394 (guard green at ratchet 17).🤖 Generated with Claude Code
https://claude.ai/code/session_01LX9ut3MK3KykE11S9bJmv5
Generated by Claude Code